pgsql: Skip citext_utf8 test on Windows.

Skip citext_utf8 test on Windows. Back-patch of commit cff4e5a3 to 15 and 16, per request from Oleg Tselebrovskiy. Original commit message: On other Windows build farm animals it is already skipped because they don't use UTF-8 encoding. On "hamerkop", UTF-8 is used, and then the test fails. It

pgsql: Skip citext_utf8 test on Windows.

Skip citext_utf8 test on Windows. Back-patch of commit cff4e5a3 to 15 and 16, per request from Oleg Tselebrovskiy. Original commit message: On other Windows build farm animals it is already skipped because they don't use UTF-8 encoding. On "hamerkop", UTF-8 is used, and then the test fails. It

pgsql: Minor refactoring of assign_backendlist_entry()

Minor refactoring of assign_backendlist_entry() Make assign_backendlist_entry() responsible just for allocating the Backend struct. Linking it to the RegisteredBgWorker is the caller's responsibility now. Seems more clear that way. Discussion: https://www.postgresql.org/message-id/835232c0-a5f7-

pgsql: Fix outdated comment; all running bgworkers are in BackendList

Fix outdated comment; all running bgworkers are in BackendList Before commit 8a02b3d732, only bgworkers that connected to a database had an entry in the Backendlist. Commit 8a02b3d732 changed that, but forgot to update this comment. Discussion: https://www.postgresql.org/message-id/835232c0-a5f7

pgsql: Switch PgStat_Kind from an enum to a uint32 type

Switch PgStat_Kind from an enum to a uint32 type A follow-up patch is planned to make cumulative statistics pluggable, and using a type is useful in the internal routines used by pgstats as PgStat_Kind may have a value that was not originally in the enum removed here, once made pluggable. While o

pgsql: Add redo LSN to pgstats files

Add redo LSN to pgstats files This is used in the startup process to check that the pgstats file we are reading includes the redo LSN referring to the shutdown checkpoint where it has been written. The redo LSN in the pgstats file needs to match with what the control file has. This is intended t

pgsql: Convert some extern variables to static, Windows code

Convert some extern variables to static, Windows code Similar to 720b0eaae9b, discovered by MinGW. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/c27090bd605a54d00c808ce1656a097fddd118f7 Modified Files -- src/bin/pg_upgrade/parallel.c | 8 src/

pgsql: Convert an extern variable to static

Convert an extern variable to static Similar to 720b0eaae9b, fixes new code from bd15b7db489. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/6bbbd7f65f44256a6aea6cb4fd2432a954d37f9e Modified Files -- src/bin/pg_dump/pg_dump.c | 2 +- 1 file changed, 1 i

pgsql: pg_createsubscriber: Rename option --socket-directory to --socke

pg_createsubscriber: Rename option --socket-directory to --socketdir For consistency with the equivalent option in pg_upgrade. Reviewed-by: Hayato Kuroda Reviewed-by: Euler Taveira Discussion: https://www.postgresql.org/message-id/flat/1ed82b9b-8e20-497d-a2f8-aebdd793d595%40eisentraut.org Bra

pgsql: pg_createsubscriber: Rename option --socket-directory to --socke

pg_createsubscriber: Rename option --socket-directory to --socketdir For consistency with the equivalent option in pg_upgrade. Reviewed-by: Hayato Kuroda Reviewed-by: Euler Taveira Discussion: https://www.postgresql.org/message-id/flat/1ed82b9b-8e20-497d-a2f8-aebdd793d595%40eisentraut.org Bra

pgsql: Update comment in portal.h.

Update comment in portal.h. We store tuples into the portal's tuple store for a PORTAL_ONE_MOD_WITH query as well. Back-patch to all supported branches. Reviewed by Andy Fan. Discussion: https://postgr.es/m/CAPmGK14HVYBZYZtHabjeCd-e31VT%3Dwx6rQNq8QfehywLcpZ2Hw%40mail.gmail.com Branch -- R

pgsql: Update comment in portal.h.

Update comment in portal.h. We store tuples into the portal's tuple store for a PORTAL_ONE_MOD_WITH query as well. Back-patch to all supported branches. Reviewed by Andy Fan. Discussion: https://postgr.es/m/CAPmGK14HVYBZYZtHabjeCd-e31VT%3Dwx6rQNq8QfehywLcpZ2Hw%40mail.gmail.com Branch -- R

pgsql: Update comment in portal.h.

Update comment in portal.h. We store tuples into the portal's tuple store for a PORTAL_ONE_MOD_WITH query as well. Back-patch to all supported branches. Reviewed by Andy Fan. Discussion: https://postgr.es/m/CAPmGK14HVYBZYZtHabjeCd-e31VT%3Dwx6rQNq8QfehywLcpZ2Hw%40mail.gmail.com Branch -- m

pgsql: Update comment in portal.h.

Update comment in portal.h. We store tuples into the portal's tuple store for a PORTAL_ONE_MOD_WITH query as well. Back-patch to all supported branches. Reviewed by Andy Fan. Discussion: https://postgr.es/m/CAPmGK14HVYBZYZtHabjeCd-e31VT%3Dwx6rQNq8QfehywLcpZ2Hw%40mail.gmail.com Branch -- R

pgsql: Update comment in portal.h.

Update comment in portal.h. We store tuples into the portal's tuple store for a PORTAL_ONE_MOD_WITH query as well. Back-patch to all supported branches. Reviewed by Andy Fan. Discussion: https://postgr.es/m/CAPmGK14HVYBZYZtHabjeCd-e31VT%3Dwx6rQNq8QfehywLcpZ2Hw%40mail.gmail.com Branch -- R

pgsql: Update comment in portal.h.

Update comment in portal.h. We store tuples into the portal's tuple store for a PORTAL_ONE_MOD_WITH query as well. Back-patch to all supported branches. Reviewed by Andy Fan. Discussion: https://postgr.es/m/CAPmGK14HVYBZYZtHabjeCd-e31VT%3Dwx6rQNq8QfehywLcpZ2Hw%40mail.gmail.com Branch -- R

pgsql: Update comment in portal.h.

Update comment in portal.h. We store tuples into the portal's tuple store for a PORTAL_ONE_MOD_WITH query as well. Back-patch to all supported branches. Reviewed by Andy Fan. Discussion: https://postgr.es/m/CAPmGK14HVYBZYZtHabjeCd-e31VT%3Dwx6rQNq8QfehywLcpZ2Hw%40mail.gmail.com Branch -- R

pgsql: Convert node test compile-time settings into run-time parameters

Convert node test compile-time settings into run-time parameters This converts COPY_PARSE_PLAN_TREES WRITE_READ_PARSE_PLAN_TREES RAW_EXPRESSION_COVERAGE_TEST into run-time parameters debug_copy_parse_plan_trees debug_write_read_parse_plan_trees debug_raw_expression_cover