pgsql: Add prefetching support on macOS

2024-08-27 Thread Peter Eisentraut
Add prefetching support on macOS macOS doesn't have posix_fadvise(), but fcntl() with the F_RDADVISE command does the same thing. Some related documentation has been generalized to not mention posix_advise() specifically anymore. Reviewed-by: Thomas Munro Discussion: https://www.postgresql.org

Re: pgsql: Restrict accesses to non-system views and foreign tables during

2024-08-27 Thread Masahiko Sawada
On Tue, Aug 27, 2024 at 6:29 AM Tom Lane wrote: > > Peter Eisentraut writes: > > Maybe in the documentation it would also be appropriate to mention that > > this is meant to be used by pg_dump, not for general use -- unless it is? > > I'd vote against that. I think other catalog-scanning tools m

pgsql: Message style improvements

2024-08-27 Thread Peter Eisentraut
Message style improvements Branch -- REL_17_STABLE Details --- https://git.postgresql.org/pg/commitdiff/0be079ec9706eb80f0142b0d7deba245024acdce Modified Files -- src/bin/pg_amcheck/pg_amcheck.c | 4 ++-- src/bin/pg_amcheck/t/003_check.pl | 2 +- src/bin

pgsql: Message style improvements

2024-08-27 Thread Peter Eisentraut
Message style improvements Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/2e6a8047f0c94b4ac1c3e80faecd628ae552a6c3 Modified Files -- src/bin/pg_amcheck/pg_amcheck.c | 4 ++-- src/bin/pg_amcheck/t/003_check.pl | 2 +- src/bin/pg_com

pgsql: Fix misplaced translator comments

2024-08-27 Thread Peter Eisentraut
Fix misplaced translator comments They did not immediately precede the code they were applying to. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/dc26ff2f228174efed9bf285ee8f8065ea295799 Modified Files -- src/backend/replication/logical/slotsync.c | 11

pgsql: Fix misplaced translator comments

2024-08-27 Thread Peter Eisentraut
Fix misplaced translator comments They did not immediately precede the code they were applying to. Branch -- REL_17_STABLE Details --- https://git.postgresql.org/pg/commitdiff/203b5ceee88c377110260e8c69083ef24b54fc68 Modified Files -- src/backend/replication/logical/slotsync

Re: pgsql: Restrict accesses to non-system views and foreign tables during

2024-08-27 Thread Tom Lane
Peter Eisentraut writes: > Maybe in the documentation it would also be appropriate to mention that > this is meant to be used by pg_dump, not for general use -- unless it is? I'd vote against that. I think other catalog-scanning tools might like to use this too. regards

Re: pgsql: Restrict accesses to non-system views and foreign tables during

2024-08-27 Thread Peter Eisentraut
On 26.08.24 21:05, Masahiko Sawada wrote: Maybe using the word "prohibit" makes it a bit clear? For example, I think that would be much clearer, yes. In guc_tables.c: Prohibits access to non-system relations of specified kinds End with period. In doc: Set relation kinds of non-system rela