pgsql: Fix unfairness in all-cached parallel seq scan.

2024-08-30 Thread Thomas Munro
Fix unfairness in all-cached parallel seq scan. Commit b5a9b18c introduced block streaming infrastructure with a special fast path for all-cached scans, and commit b7b0f3f2 connected the infrastructure up to sequential scans. One of the fast path micro-optimizations had an unintended consequence:

pgsql: Fix unfairness in all-cached parallel seq scan.

2024-08-30 Thread Thomas Munro
Fix unfairness in all-cached parallel seq scan. Commit b5a9b18c introduced block streaming infrastructure with a special fast path for all-cached scans, and commit b7b0f3f2 connected the infrastructure up to sequential scans. One of the fast path micro-optimizations had an unintended consequence:

pgsql: Stabilize 039_end_of_wal test.

2024-08-30 Thread Thomas Munro
Stabilize 039_end_of_wal test. The first test was sensitive to the insert LSN after setting up the catalogs, which depended on environmental things like the locales on the OS and usernames. Switch to a new WAL file before the first test, as a simple way to put every computer into the same state.

pgsql: Stabilize 039_end_of_wal test.

2024-08-30 Thread Thomas Munro
Stabilize 039_end_of_wal test. The first test was sensitive to the insert LSN after setting up the catalogs, which depended on environmental things like the locales on the OS and usernames. Switch to a new WAL file before the first test, as a simple way to put every computer into the same state.

pgsql: Stabilize 039_end_of_wal test.

2024-08-30 Thread Thomas Munro
Stabilize 039_end_of_wal test. The first test was sensitive to the insert LSN after setting up the catalogs, which depended on environmental things like the locales on the OS and usernames. Switch to a new WAL file before the first test, as a simple way to put every computer into the same state.

pgsql: Stabilize 039_end_of_wal test.

2024-08-30 Thread Thomas Munro
Stabilize 039_end_of_wal test. The first test was sensitive to the insert LSN after setting up the catalogs, which depended on environmental things like the locales on the OS and usernames. Switch to a new WAL file before the first test, as a simple way to put every computer into the same state.

pgsql: Stabilize 039_end_of_wal test.

2024-08-30 Thread Thomas Munro
Stabilize 039_end_of_wal test. The first test was sensitive to the insert LSN after setting up the catalogs, which depended on environmental things like the locales on the OS and usernames. Switch to a new WAL file before the first test, as a simple way to put every computer into the same state.

pgsql: Stabilize 039_end_of_wal test.

2024-08-30 Thread Thomas Munro
Stabilize 039_end_of_wal test. The first test was sensitive to the insert LSN after setting up the catalogs, which depended on environmental things like the locales on the OS and usernames. Switch to a new WAL file before the first test, as a simple way to put every computer into the same state.

pgsql: Stabilize 039_end_of_wal test.

2024-08-30 Thread Thomas Munro
Stabilize 039_end_of_wal test. The first test was sensitive to the insert LSN after setting up the catalogs, which depended on environmental things like the locales on the OS and usernames. Switch to a new WAL file before the first test, as a simple way to put every computer into the same state.

pgsql: Clarify restrict_nonsystem_relation_kind description.

2024-08-30 Thread Masahiko Sawada
Clarify restrict_nonsystem_relation_kind description. This change improves the description of the restrict_nonsystem_relation_kind parameter in guc_table.c and the documentation for better clarity. Backpatch to 12, where this GUC parameter was introduced. Reviewed-by: Peter Eisentraut Discussion

pgsql: Clarify restrict_nonsystem_relation_kind description.

2024-08-30 Thread Masahiko Sawada
Clarify restrict_nonsystem_relation_kind description. This change improves the description of the restrict_nonsystem_relation_kind parameter in guc_table.c and the documentation for better clarity. Backpatch to 12, where this GUC parameter was introduced. Reviewed-by: Peter Eisentraut Discussion

pgsql: Clarify restrict_nonsystem_relation_kind description.

2024-08-30 Thread Masahiko Sawada
Clarify restrict_nonsystem_relation_kind description. This change improves the description of the restrict_nonsystem_relation_kind parameter in guc_table.c and the documentation for better clarity. Backpatch to 12, where this GUC parameter was introduced. Reviewed-by: Peter Eisentraut Discussion

pgsql: Clarify restrict_nonsystem_relation_kind description.

2024-08-30 Thread Masahiko Sawada
Clarify restrict_nonsystem_relation_kind description. This change improves the description of the restrict_nonsystem_relation_kind parameter in guc_table.c and the documentation for better clarity. Backpatch to 12, where this GUC parameter was introduced. Reviewed-by: Peter Eisentraut Discussion

pgsql: Clarify restrict_nonsystem_relation_kind description.

2024-08-30 Thread Masahiko Sawada
Clarify restrict_nonsystem_relation_kind description. This change improves the description of the restrict_nonsystem_relation_kind parameter in guc_table.c and the documentation for better clarity. Backpatch to 12, where this GUC parameter was introduced. Reviewed-by: Peter Eisentraut Discussion

pgsql: Clarify restrict_nonsystem_relation_kind description.

2024-08-30 Thread Masahiko Sawada
Clarify restrict_nonsystem_relation_kind description. This change improves the description of the restrict_nonsystem_relation_kind parameter in guc_table.c and the documentation for better clarity. Backpatch to 12, where this GUC parameter was introduced. Reviewed-by: Peter Eisentraut Discussion

pgsql: Clarify restrict_nonsystem_relation_kind description.

2024-08-30 Thread Masahiko Sawada
Clarify restrict_nonsystem_relation_kind description. This change improves the description of the restrict_nonsystem_relation_kind parameter in guc_table.c and the documentation for better clarity. Backpatch to 12, where this GUC parameter was introduced. Reviewed-by: Peter Eisentraut Discussion

pgsql: Make postgres_fdw's query_cancel test less flaky.

2024-08-30 Thread Tom Lane
Make postgres_fdw's query_cancel test less flaky. This test occasionally shows +WARNING: could not get result of cancel request due to timeout which appears to be because the cancel request is sometimes unluckily sent to the remote session between queries, and then it's ignored. This patch tri

pgsql: Make postgres_fdw's query_cancel test less flaky.

2024-08-30 Thread Tom Lane
Make postgres_fdw's query_cancel test less flaky. This test occasionally shows +WARNING: could not get result of cancel request due to timeout which appears to be because the cancel request is sometimes unluckily sent to the remote session between queries, and then it's ignored. This patch tri

Re: pgsql: Implement pg_wal_replay_wait() stored procedure

2024-08-30 Thread Peter Eisentraut
On 02.08.24 20:22, Alexander Korotkov wrote: Implement pg_wal_replay_wait() stored procedure Why is this under src/backend/command/? Wouldn't it belong under src/backend/utils/adt/? pg_wal_replay_wait() is to be used on standby and specifies waiting for the specific WAL location to be repl

pgsql: Remove one memoize test case added by commit 069d0ff02.

2024-08-30 Thread Tom Lane
Remove one memoize test case added by commit 069d0ff02. This test case turns out to depend on the assumption that a non-Var subquery output that's underneath an outer join will always get wrapped in a PlaceHolderVar. But that behavior causes performance regressions in some cases compared to what

pgsql: Avoid inserting PlaceHolderVars in cases where pre-v16 PG did no

2024-08-30 Thread Tom Lane
Avoid inserting PlaceHolderVars in cases where pre-v16 PG did not. Commit 2489d76c4 removed some logic from pullup_replace_vars() that avoided wrapping a PlaceHolderVar around a pulled-up subquery output expression if the expression could be proven to go to NULL anyway (because it contained Vars o

pgsql: Avoid inserting PlaceHolderVars in cases where pre-v16 PG did no

2024-08-30 Thread Tom Lane
Avoid inserting PlaceHolderVars in cases where pre-v16 PG did not. Commit 2489d76c4 removed some logic from pullup_replace_vars() that avoided wrapping a PlaceHolderVar around a pulled-up subquery output expression if the expression could be proven to go to NULL anyway (because it contained Vars o

pgsql: Avoid inserting PlaceHolderVars in cases where pre-v16 PG did no

2024-08-30 Thread Tom Lane
Avoid inserting PlaceHolderVars in cases where pre-v16 PG did not. Commit 2489d76c4 removed some logic from pullup_replace_vars() that avoided wrapping a PlaceHolderVar around a pulled-up subquery output expression if the expression could be proven to go to NULL anyway (because it contained Vars o

pgsql: Update list of acknowledgments in release notes

2024-08-30 Thread Peter Eisentraut
Update list of acknowledgments in release notes current through df80b1d6cd Branch -- REL_17_STABLE Details --- https://git.postgresql.org/pg/commitdiff/df51201f34f21ae313076e8f1a475c59a2ff2f5f Modified Files -- doc/src/sgml/release-17.sgml | 12 1 file changed, 1