pgsql: pgbench: Improve result outputs related to failed transactions.

2024-10-10 Thread Tatsuo Ishii
pgbench: Improve result outputs related to failed transactions. Previously, per-script statistics were never output when all transactions failed due to serialization or deadlock errors. However, it is reasonable to report such information if there are ones even when there are no successful transa

pgsql: Adjust EXPLAIN's output for disabled nodes

2024-10-10 Thread David Rowley
Adjust EXPLAIN's output for disabled nodes c01743aa4 added EXPLAIN output to display the plan node's disabled_node count whenever that count is above 0. Seemingly, there weren't many people who liked that output as each parent of a disabled node would also have a "Disabled Nodes" output due to th

Re: pgsql: Doc: add check to detect non-breaking spaces in the docs.

2024-10-10 Thread Tatsuo Ishii
> On Tue, Oct 8, 2024 at 7:26 AM Tatsuo Ishii wrote: >> Doc: add check to detect non-breaking spaces in the docs. > > Please consider that the make-based build system will likely be > removed at some point in the future in favor of the meson build > system. > > It doesn't seem like we're super-c

pgsql: Don't hard-code the input file name in gen_tabcomplete.pl's outp

2024-10-10 Thread Tom Lane
Don't hard-code the input file name in gen_tabcomplete.pl's output. Use $ARGV[0], that is the specified input file name, in #line directives generated by gen_tabcomplete.pl. This makes code coverage reports work properly in the meson build system (where the input file name will be a relative path

pgsql: Avoid possible segfault in psql's tab completion.

2024-10-10 Thread Tom Lane
Avoid possible segfault in psql's tab completion. Fix oversight in bd1276a3c: the "words_after_create" stanza in psql_completion() requires previous_words_count > 0, since it uses prev_wd. This condition was formerly assured by the if-else chain above it, but no more. If there were no previous w

Re: pgsql: Doc: add check to detect non-breaking spaces in the docs.

2024-10-10 Thread Robert Haas
On Tue, Oct 8, 2024 at 7:26 AM Tatsuo Ishii wrote: > Doc: add check to detect non-breaking spaces in the docs. Please consider that the make-based build system will likely be removed at some point in the future in favor of the meson build system. It doesn't seem like we're super-close to being r

pgsql: Improve descriptions of some pg_stat_checkpoints functions in pg

2024-10-10 Thread Fujii Masao
Improve descriptions of some pg_stat_checkpoints functions in pg_proc.dat. Previously, the descriptions of pg_stat_get_checkpointer_num_requested(), pg_stat_get_checkpointer_restartpoints_requested(), and pg_stat_get_checkpointer_restartpoints_performed() in pg_proc.dat referred to "backend". This