pgsql: Add error pattern checks for some TAP tests for non-existing obj

2025-01-22 Thread Michael Paquier
Add error pattern checks for some TAP tests for non-existing objects Some tests are updated to use command_fails_like(), gaining a check for the error output generated. The test changed in pg_amcheck has come up after noticing that an incorrect option name still made the test to pass, while the c

pgsql: Improve TAP tests of pg_basebackup

2025-01-22 Thread Michael Paquier
Improve TAP tests of pg_basebackup This addresses some minor issues with the TAP tests of pg_basebackup: - Remove three duplicated tests used for incorrect option combinations. - Add more pattern checks for commands doomed to fail, to make sure that the error generated is the expected one. These

pgsql: Support RN (roman-numeral format) in to_number().

2025-01-22 Thread Tom Lane
Support RN (roman-numeral format) in to_number(). We've long had roman-numeral output support in to_char(), but lacked the reverse conversion. Here it is. Author: Hunaid Sohail Reviewed-by: Maciek Sakrejda Reviewed-by: Tom Lane Reviewed-by: Tomas Vondra Discussion: https://postgr.es/m/CAMWA

pgsql: Fix comment about AVX-512 popcount support.

2025-01-22 Thread Nathan Bossart
Fix comment about AVX-512 popcount support. Since commit f78667bd91, we've used __attribute__((target(...))) instead of extra compiler flags for AVX-512 support, but this comment still says that we put the code in a separate file because it might require extra compiler flags. Let's just remove th

pgsql: Repair incorrect handling of AfterTriggerSharedData.ats_modified

2025-01-22 Thread Tom Lane
Repair incorrect handling of AfterTriggerSharedData.ats_modifiedcols. This patch fixes two distinct errors that both ultimately trace to commit 71d60e2aa, which added the ats_modifiedcols field. The more severe error is that ats_modifiedcols wasn't accounted for in afterTriggerAddEvent's scanning

pgsql: Repair incorrect handling of AfterTriggerSharedData.ats_modified

2025-01-22 Thread Tom Lane
Repair incorrect handling of AfterTriggerSharedData.ats_modifiedcols. This patch fixes two distinct errors that both ultimately trace to commit 71d60e2aa, which added the ats_modifiedcols field. The more severe error is that ats_modifiedcols wasn't accounted for in afterTriggerAddEvent's scanning

pgsql: Repair incorrect handling of AfterTriggerSharedData.ats_modified

2025-01-22 Thread Tom Lane
Repair incorrect handling of AfterTriggerSharedData.ats_modifiedcols. This patch fixes two distinct errors that both ultimately trace to commit 71d60e2aa, which added the ats_modifiedcols field. The more severe error is that ats_modifiedcols wasn't accounted for in afterTriggerAddEvent's scanning

pgsql: Repair incorrect handling of AfterTriggerSharedData.ats_modified

2025-01-22 Thread Tom Lane
Repair incorrect handling of AfterTriggerSharedData.ats_modifiedcols. This patch fixes two distinct errors that both ultimately trace to commit 71d60e2aa, which added the ats_modifiedcols field. The more severe error is that ats_modifiedcols wasn't accounted for in afterTriggerAddEvent's scanning

pgsql: Repair incorrect handling of AfterTriggerSharedData.ats_modified

2025-01-22 Thread Tom Lane
Repair incorrect handling of AfterTriggerSharedData.ats_modifiedcols. This patch fixes two distinct errors that both ultimately trace to commit 71d60e2aa, which added the ats_modifiedcols field. The more severe error is that ats_modifiedcols wasn't accounted for in afterTriggerAddEvent's scanning

pgsql: Repair incorrect handling of AfterTriggerSharedData.ats_modified

2025-01-22 Thread Tom Lane
Repair incorrect handling of AfterTriggerSharedData.ats_modifiedcols. This patch fixes two distinct errors that both ultimately trace to commit 71d60e2aa, which added the ats_modifiedcols field. The more severe error is that ats_modifiedcols wasn't accounted for in afterTriggerAddEvent's scanning

pgsql: Fix \dRp+ output when describing publications with a lower serve

2025-01-22 Thread Amit Kapila
Fix \dRp+ output when describing publications with a lower server version. The psql was not careful that the new column "Generated columns" won't be present in the lower version. This was introduced in recent commit 7054186c4e. Author: Vignesh C Reviewed-by: Peter Smith Discussion: https://postg