pgsql: Print out error position for some ALTER TABLE ALTER COLUMN type

2025-01-26 Thread Michael Paquier
Print out error position for some ALTER TABLE ALTER COLUMN type A ParseState exists in ATPrepAlterColumnType() since its introduction in 077db40fa1f3, and it has never relied on a query string that could be used to point at a location in the origin string on error. The output of some regression t

pgsql: pg_amcheck: Fix test failure on Windows with non-existing role

2025-01-26 Thread Michael Paquier
pg_amcheck: Fix test failure on Windows with non-existing role For SSPI auth extra users need to be explicitly allowed, or we get "SSPI authentication failed" instead of the expected "role does not exist" error. This report also means that the test has never worked on Windows since its introducti

pgsql: Test postmaster with program_options_handling_ok() et al.

2025-01-26 Thread Noah Misch
Test postmaster with program_options_handling_ok() et al. Most executables already get that testing. To occupy the customary 001_basic.pl name, this renumbers the new-in-October tests of src/test/postmaster/t. Reviewed by Thomas Munro. Discussion: https://postgr.es/m/20241215022701.a1.nmi...@go

pgsql: Add missing CommandCounterIncrement

2025-01-26 Thread Álvaro Herrera
Add missing CommandCounterIncrement For commit b663b9436e75 I thought this was useless, but turns out not to be for the case where a partitioned table has two identical foreign key constraints which can both be matched by the same constraint in a partition during attach. This CCI makes the match