pgsql: Fix incorrect format placeholders

2025-04-09 Thread Peter Eisentraut
Fix incorrect format placeholders for commits 8f427187db7, 6ee3b91bad2 Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/9ad19295e934e261bb22463d71af3f69699053ea Modified Files -- src/bin/pg_dump/pg_dump.c | 4 ++-- 1 file changed, 2 insertions(+), 2 delet

pgsql: Update wording in optimizer/README for EquivalenceClasses

2025-04-09 Thread David Rowley
Update wording in optimizer/README for EquivalenceClasses d69d45a5a changed how em_is_child members are stored in EquivalenceClasses. Children are no longer stored in the ec_members list. optimizer/README mentioned that most operations "should ignore child members", but that felt a little untrue

pgsql: Cosmetic fixes for pg_createsubscriber's -all option.

2025-04-09 Thread Amit Kapila
Cosmetic fixes for pg_createsubscriber's -all option. Author: Peter Smith Reviewed-by: Amit Kapila Discussion: https://postgr.es/m/CAHut+PsmSCQ-ENSDQ0YOUcsgzT=gg-e9jyxbvxd51a_dmxh...@mail.gmail.com Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/d438515c29c3cc539

Re: pgsql: Use extended stats for precise estimation of bucket size in hash

2025-04-09 Thread Robins Tharakan
Hi, On Mon, 10 Mar 2025 at 22:18, Alexander Korotkov wrote: > > Use extended stats for precise estimation of bucket size in hash join After this commit, I see a recurrence of an error similar to the one fixed in e28033fe1af8037e0fec8bb3a32fabbe18ac06b1 https://www.postgresql.org/message-id/188

pgsql: ci: Check for missing dependencies in meson builds

2025-04-09 Thread Tomas Vondra
ci: Check for missing dependencies in meson builds Extends the Linux and Windows meson builds with a check for missing dependencies by running ninja -t missingdeps after the build. This highlights unindended dependencies. Reviewed-by: Andres Freund https://postgr.es/m/caldsspi5fj0a7ug7fmw2

pgsql: pg_upgrade: Mention that we preserve database OIDs in a comment.

2025-04-09 Thread Nathan Bossart
pg_upgrade: Mention that we preserve database OIDs in a comment. Oversight in commit aa01051418. Reported-by: Tom Lane Discussion: https://postgr.es/m/4055696.1744134682%40sss.pgh.pa.us Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/e2665efd0f4d2ae90d3245f9425d37

pgsql: Fix performance issue in deadlock-parallel isolation test.

2025-04-09 Thread Tom Lane
Fix performance issue in deadlock-parallel isolation test. With debug_discard_caches = 1, the runtime of this test script increased by about a factor of 10 after commit 0dca5d68d. That's causing some of our buildfarm animals to fail with a timeout. The reason for the increased time is that now w

pgsql: Fix test races between syscache-update-pruned.spec and autovacuu

2025-04-09 Thread Noah Misch
Fix test races between syscache-update-pruned.spec and autovacuum. This spec fails ~3% of my Valgrind runs, and the spec has failed on Valgrind buildfarm member skink at a similar rate. Two problems contributed to that: - A competing buffer pin triggered VACUUM's lazy_scan_noprune() path, causin

Re: pgsql: Make cancel request keys longer

2025-04-09 Thread Heikki Linnakangas
On 08/04/2025 20:06, Peter Eisentraut wrote: On 02.04.25 15:43, Heikki Linnakangas wrote: Make cancel request keys longer This patch changed the signature of ProcSignal() -ProcSignalInit(bool cancel_key_valid, int32 cancel_key) +ProcSignalInit(char *cancel_key, int cancel_key_len) but did no

pgsql: Update config.guess and config.sub

2025-04-09 Thread Peter Eisentraut
Update config.guess and config.sub Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/306dd6e727bf7a4e76f02cb31c2e22ac3b0deca3 Modified Files -- config/config.guess | 11 +- config/config.sub | 729 +++- 2 fi

pgsql: Fix a few oversights in the longer cancel keys patch

2025-04-09 Thread Heikki Linnakangas
Fix a few oversights in the longer cancel keys patch Change MyCancelKeyLength's type from uint8 to int. While it always fits in a uint8, plain int is less surprising, as there's no particular reason for it to be uint8. Fix one ProcSignalInit caller that passed 'false' instead of NULL for the poin

Re: pgsql: Make cancel request keys longer

2025-04-09 Thread Peter Eisentraut
On 09.04.25 10:53, Heikki Linnakangas wrote: On 08/04/2025 22:41, Heikki Linnakangas wrote: On 08/04/2025 20:06, Peter Eisentraut wrote: While I was looking at this, I suggest to make the first argument void *.  This is consistent for passing binary data. Ok, sure. On second thoughts, -1 on

Re: pgsql: Make cancel request keys longer

2025-04-09 Thread Heikki Linnakangas
On 08/04/2025 22:41, Heikki Linnakangas wrote: On 08/04/2025 20:06, Peter Eisentraut wrote: While I was looking at this, I suggest to make the first argument void *.  This is consistent for passing binary data. Ok, sure. On second thoughts, -1 on that. 'void *' is appropriate for functions

pgsql: Perform missed catversion bump

2025-04-09 Thread Daniel Gustafsson
Perform missed catversion bump Commit c57971034e69ca renamed an argument for a function but missed to bump the catversion to reflect this. Reported-by: David Rowley Discussion: https://postgr.es/m/CAApHDvqOega=dptu3h2c5fjwjeuagcmdib_svfhkqqgunjv...@mail.gmail.com Branch -- master Details