pgsql: doc: Mention naming convention used by injection points

2025-04-21 Thread Michael Paquier
doc: Mention naming convention used by injection points All the injection points used in the tree have relied on an implied rule: their names should be made of lower-case characters, with dashes between the words used. This commit adds a light mention about that in the docs, encouraging the pract

pgsql: doc: Mention naming convention used by injection points

2025-04-21 Thread Michael Paquier
doc: Mention naming convention used by injection points All the injection points used in the tree have relied on an implied rule: their names should be made of lower-case characters, with dashes between the words used. This commit adds a light mention about that in the docs, encouraging the pract

pgsql: Doc: reword text explaining the --maintenance-db option

2025-04-21 Thread David Rowley
Doc: reword text explaining the --maintenance-db option The previous text was a little clumsy. Here we improve that. Author: David Rowley Reported-by: Noboru Saito Reviewed-by: David G. Johnston Discussion: https://postgr.es/m/caam3qnjtv5ybjpwdfvoyn2gz9zgslfm1ugjgptsxmwfifoz...@mail.gmail.co

pgsql: Doc: reword text explaining the --maintenance-db option

2025-04-21 Thread David Rowley
Doc: reword text explaining the --maintenance-db option The previous text was a little clumsy. Here we improve that. Author: David Rowley Reported-by: Noboru Saito Reviewed-by: David G. Johnston Discussion: https://postgr.es/m/caam3qnjtv5ybjpwdfvoyn2gz9zgslfm1ugjgptsxmwfifoz...@mail.gmail.co

pgsql: Doc: reword text explaining the --maintenance-db option

2025-04-21 Thread David Rowley
Doc: reword text explaining the --maintenance-db option The previous text was a little clumsy. Here we improve that. Author: David Rowley Reported-by: Noboru Saito Reviewed-by: David G. Johnston Discussion: https://postgr.es/m/caam3qnjtv5ybjpwdfvoyn2gz9zgslfm1ugjgptsxmwfifoz...@mail.gmail.co

pgsql: Doc: reword text explaining the --maintenance-db option

2025-04-21 Thread David Rowley
Doc: reword text explaining the --maintenance-db option The previous text was a little clumsy. Here we improve that. Author: David Rowley Reported-by: Noboru Saito Reviewed-by: David G. Johnston Discussion: https://postgr.es/m/caam3qnjtv5ybjpwdfvoyn2gz9zgslfm1ugjgptsxmwfifoz...@mail.gmail.co

pgsql: Doc: reword text explaining the --maintenance-db option

2025-04-21 Thread David Rowley
Doc: reword text explaining the --maintenance-db option The previous text was a little clumsy. Here we improve that. Author: David Rowley Reported-by: Noboru Saito Reviewed-by: David G. Johnston Discussion: https://postgr.es/m/caam3qnjtv5ybjpwdfvoyn2gz9zgslfm1ugjgptsxmwfifoz...@mail.gmail.co

pgsql: Doc: reword text explaining the --maintenance-db option

2025-04-21 Thread David Rowley
Doc: reword text explaining the --maintenance-db option The previous text was a little clumsy. Here we improve that. Author: David Rowley Reported-by: Noboru Saito Reviewed-by: David G. Johnston Discussion: https://postgr.es/m/caam3qnjtv5ybjpwdfvoyn2gz9zgslfm1ugjgptsxmwfifoz...@mail.gmail.co

pgsql: Rename injection point for invalidation messages at end of trans

2025-04-21 Thread Michael Paquier
Rename injection point for invalidation messages at end of transaction This injection point was named "AtEOXact_Inval-with-transInvalInfo", not respecting the implied naming convention that injection points should use lower-case characters, with terms separated by dashes. All the other points def

pgsql: Rename injection point for invalidation messages at end of trans

2025-04-21 Thread Michael Paquier
Rename injection point for invalidation messages at end of transaction This injection point was named "AtEOXact_Inval-with-transInvalInfo", not respecting the implied naming convention that injection points should use lower-case characters, with terms separated by dashes. All the other points def

pgsql: Doc: various fixups

2025-04-21 Thread David Rowley
Doc: various fixups * Use tags for CONNECTION_* #defines We were using an inconsistent mix of and sometimes tags. * Use tag for libpq There was a mix of and Also fix a whitespace issue. None of these seem critical enough mistakes to backpatch. Author: Noboru Saito Discussion: https:/

pgsql: Doc: fix incorrect punctuation

2025-04-21 Thread David Rowley
Doc: fix incorrect punctuation Author: Noboru Saito Discussion: https://postgr.es/m/caam3qnjtv5ybjpwdfvoyn2gz9zgslfm1ugjgptsxmwfifoz...@mail.gmail.com Backpatch-through: 17 Branch -- REL_17_STABLE Details --- https://git.postgresql.org/pg/commitdiff/12bf43410aba58a577a8519e031a0e24631e

pgsql: Doc: fix incorrect punctuation

2025-04-21 Thread David Rowley
Doc: fix incorrect punctuation Author: Noboru Saito Discussion: https://postgr.es/m/caam3qnjtv5ybjpwdfvoyn2gz9zgslfm1ugjgptsxmwfifoz...@mail.gmail.com Backpatch-through: 17 Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/d010cc6ccacf88926255d3ae2d67dad3e332ae8a M

pgsql: Fix INITCAP() word boundaries for PG_UNICODE_FAST.

2025-04-21 Thread Jeff Davis
Fix INITCAP() word boundaries for PG_UNICODE_FAST. Word boundaries are based on whether a character is alphanumeric or not. For the PG_UNICODE_FAST collation, alphanumeric includes non-ASCII digits; whereas for the PG_C_UTF8 collation, it only includes digits 0-9. Pass down the right information f

pgsql: Use the same cmd_context throughout a walsender's lifetime.

2025-04-21 Thread Tom Lane
Use the same cmd_context throughout a walsender's lifetime. exec_replication_command created a cmd_context to work in and then deleted it on exit. This is pretty dangerous because some replication commands start/finish transactions. In the wake of commit 1afe31f03, that could lead to re-selectin

pgsql: MemoryContextCreate: assert parent is valid and different from n

2025-04-21 Thread Tom Lane
MemoryContextCreate: assert parent is valid and different from node. The case of "node == parent" might seem impossible, since we just allocated the new node. But it's possible if parent is a dangling reference to a recently-deleted context. In fact, given aset.c's habit of recycling contexts, i