pgsql: Doc: Specify the interaction of publish_generated_columns with c

2025-04-28 Thread Amit Kapila
Doc: Specify the interaction of publish_generated_columns with column list. Author: Peter Smith Reviewed-by: David G. Johnston Reviewed-by: Amit Kapila Discussion: https://postgr.es/m/cahut+ptnjlinffh-3f9cxh0wnwqjdktjqnbvmzdz1y+zkt_...@mail.gmail.com Branch -- master Details --- http

pgsql: Add maintenance_io_concurrency flag to some read stream users

2025-04-28 Thread Melanie Plageman
Add maintenance_io_concurrency flag to some read stream users Index vacuuming and [auto]prewarm AIO concurrency should be governed by maintenance_io_concurrency. As such, pass those read stream users the READ_STREAM_MAINTENANCE flag which will calculate their read stream distance with maintenance_

pgsql: Fix obsolete nbtree array advancement comment.

2025-04-28 Thread Peter Geoghegan
Fix obsolete nbtree array advancement comment. Checking if another primitive scan is required after all once the next leaf page was moved from _bt_checkkeys to its _bt_readpage caller by commit 9a2e2a28. Update a comment that incorrectly described the recheck mechanism as something that takes pla

Re: pgsql: Improve nbtree skip scan primitive scan scheduling.

2025-04-28 Thread Peter Geoghegan
On Sun, Apr 27, 2025 at 1:06 PM Mark Dilger wrote: > I can confirm that your patch fixes the problem, having spent some four hours > trying to find other test cases which still fail, finding none. Great. I pushed essentially the same patch to HEAD just now. Thanks for the report! -- Peter Geo

pgsql: Make NULL tuple values always advance skip arrays.

2025-04-28 Thread Peter Geoghegan
Make NULL tuple values always advance skip arrays. _bt_check_compare neglected to handle a case that can arise when the scan's keys are temporarily treated as nonrequired, as an optimization: whenever a NULL tuple value was encountered that had a skip array whose current element wasn't already NUL

pgsql: Fix pg_dump for inherited validated not-null constraints

2025-04-28 Thread Álvaro Herrera
Fix pg_dump for inherited validated not-null constraints When a child constraint is validated and the parent constraint it derives from isn't, pg_dump must be coerced into printing the child constraint; failing to do would result in a dump that restores the constraint as not valid, which would be

pgsql: pg_combinebackup: Message style improvements

2025-04-28 Thread Peter Eisentraut
pg_combinebackup: Message style improvements Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/c061000311029d2ef0129ad5eee32e698221d43d Modified Files -- src/bin/pg_combinebackup/copy_file.c| 2 +- src/bin/pg_combinebackup/pg_combinebackup.c | 2 +-

pgsql: Restore comments in ChangeVarNodesExtended()

2025-04-28 Thread Alexander Korotkov
Restore comments in ChangeVarNodesExtended() This commit restores comments in ChangeVarNodesExtended(), which were accidentally removed by fc069a3a6319. Reported-by: Richard Guo Discussion: https://postgr.es/m/CAMbWs49PE3CvnV8vrQ0Dr%3DHqgZZmX0tdNbzVNJxqc8yg-8kDQQ%40mail.gmail.com Branch --