pgsql: doc: Clarify use of _ccnew and _ccold in REINDEX CONCURRENTLY

2025-05-19 Thread Michael Paquier
doc: Clarify use of _ccnew and _ccold in REINDEX CONCURRENTLY Invalid indexes are suffixed with "_ccnew" or "_ccold". The documentation missed to mention the initial underscore. ChooseRelationName() may also append an extra number if indexes with a similar name already exist; let's add a note abo

pgsql: doc: Clarify use of _ccnew and _ccold in REINDEX CONCURRENTLY

2025-05-19 Thread Michael Paquier
doc: Clarify use of _ccnew and _ccold in REINDEX CONCURRENTLY Invalid indexes are suffixed with "_ccnew" or "_ccold". The documentation missed to mention the initial underscore. ChooseRelationName() may also append an extra number if indexes with a similar name already exist; let's add a note abo

pgsql: doc: Clarify use of _ccnew and _ccold in REINDEX CONCURRENTLY

2025-05-19 Thread Michael Paquier
doc: Clarify use of _ccnew and _ccold in REINDEX CONCURRENTLY Invalid indexes are suffixed with "_ccnew" or "_ccold". The documentation missed to mention the initial underscore. ChooseRelationName() may also append an extra number if indexes with a similar name already exist; let's add a note abo

pgsql: doc: Clarify use of _ccnew and _ccold in REINDEX CONCURRENTLY

2025-05-19 Thread Michael Paquier
doc: Clarify use of _ccnew and _ccold in REINDEX CONCURRENTLY Invalid indexes are suffixed with "_ccnew" or "_ccold". The documentation missed to mention the initial underscore. ChooseRelationName() may also append an extra number if indexes with a similar name already exist; let's add a note abo

pgsql: doc: Clarify use of _ccnew and _ccold in REINDEX CONCURRENTLY

2025-05-19 Thread Michael Paquier
doc: Clarify use of _ccnew and _ccold in REINDEX CONCURRENTLY Invalid indexes are suffixed with "_ccnew" or "_ccold". The documentation missed to mention the initial underscore. ChooseRelationName() may also append an extra number if indexes with a similar name already exist; let's add a note abo

pgsql: doc: Clarify use of _ccnew and _ccold in REINDEX CONCURRENTLY

2025-05-19 Thread Michael Paquier
doc: Clarify use of _ccnew and _ccold in REINDEX CONCURRENTLY Invalid indexes are suffixed with "_ccnew" or "_ccold". The documentation missed to mention the initial underscore. ChooseRelationName() may also append an extra number if indexes with a similar name already exist; let's add a note abo

pgsql: aio: Fix possible state confusions due to interrupt processing

2025-05-19 Thread Andres Freund
aio: Fix possible state confusions due to interrupt processing elog()/ereport() process interrupts, iff the log message is < ERROR and the log message will be emitted. aio's debug messages are emitted via ereport(), but in some places the code is not ready for interrupts to be processed. Fix the

pgsql: Fix deparsing FETCH FIRST ROWS WITH TIES

2025-05-19 Thread Heikki Linnakangas
Fix deparsing FETCH FIRST ROWS WITH TIES In the grammar, is a c_expr, which accepts only a limited set of simple constants and expressions without parens. The deparsing logic didn't quite match the grammar rule, and failed to use parens e.g. for "5::bigint". To fix, always surround the expressi

pgsql: Fix deparsing FETCH FIRST ROWS WITH TIES

2025-05-19 Thread Heikki Linnakangas
Fix deparsing FETCH FIRST ROWS WITH TIES In the grammar, is a c_expr, which accepts only a limited set of integer literals and simple expressions without parens. The deparsing logic didn't quite match the grammar rule, and failed to use parens e.g. for "5::bigint". To fix, always surround the e

pgsql: Fix deparsing FETCH FIRST ROWS WITH TIES

2025-05-19 Thread Heikki Linnakangas
Fix deparsing FETCH FIRST ROWS WITH TIES In the grammar, is a c_expr, which accepts only a limited set of integer literals and simple expressions without parens. The deparsing logic didn't quite match the grammar rule, and failed to use parens e.g. for "5::bigint". To fix, always surround the e

pgsql: Fix deparsing FETCH FIRST ROWS WITH TIES

2025-05-19 Thread Heikki Linnakangas
Fix deparsing FETCH FIRST ROWS WITH TIES In the grammar, is a c_expr, which accepts only a limited set of integer literals and simple expressions without parens. The deparsing logic didn't quite match the grammar rule, and failed to use parens e.g. for "5::bigint". To fix, always surround the e

pgsql: Fix deparsing FETCH FIRST ROWS WITH TIES

2025-05-19 Thread Heikki Linnakangas
Fix deparsing FETCH FIRST ROWS WITH TIES In the grammar, is a c_expr, which accepts only a limited set of integer literals and simple expressions without parens. The deparsing logic didn't quite match the grammar rule, and failed to use parens e.g. for "5::bigint". To fix, always surround the e

pgsql: Fix deparsing FETCH FIRST ROWS WITH TIES

2025-05-19 Thread Heikki Linnakangas
Fix deparsing FETCH FIRST ROWS WITH TIES In the grammar, is a c_expr, which accepts only a limited set of integer literals and simple expressions without parens. The deparsing logic didn't quite match the grammar rule, and failed to use parens e.g. for "5::bigint". To fix, always surround the e

pgsql: Don't retreat slot's confirmed_flush LSN.

2025-05-19 Thread Amit Kapila
Don't retreat slot's confirmed_flush LSN. Prevent moving the confirmed_flush backwards, as this could lead to data duplication issues caused by replicating already replicated changes. This can happen when a client acknowledges an LSN it doesn't have to do anything for, and thus didn't store persi

pgsql: Don't retreat slot's confirmed_flush LSN.

2025-05-19 Thread Amit Kapila
Don't retreat slot's confirmed_flush LSN. Prevent moving the confirmed_flush backwards, as this could lead to data duplication issues caused by replicating already replicated changes. This can happen when a client acknowledges an LSN it doesn't have to do anything for, and thus didn't store persi

pgsql: Don't retreat slot's confirmed_flush LSN.

2025-05-19 Thread Amit Kapila
Don't retreat slot's confirmed_flush LSN. Prevent moving the confirmed_flush backwards, as this could lead to data duplication issues caused by replicating already replicated changes. This can happen when a client acknowledges an LSN it doesn't have to do anything for, and thus didn't store persi

pgsql: Don't retreat slot's confirmed_flush LSN.

2025-05-19 Thread Amit Kapila
Don't retreat slot's confirmed_flush LSN. Prevent moving the confirmed_flush backwards, as this could lead to data duplication issues caused by replicating already replicated changes. This can happen when a client acknowledges an LSN it doesn't have to do anything for, and thus didn't store persi

pgsql: Don't retreat slot's confirmed_flush LSN.

2025-05-19 Thread Amit Kapila
Don't retreat slot's confirmed_flush LSN. Prevent moving the confirmed_flush backwards, as this could lead to data duplication issues caused by replicating already replicated changes. This can happen when a client acknowledges an LSN it doesn't have to do anything for, and thus didn't store persi

pgsql: Don't retreat slot's confirmed_flush LSN.

2025-05-19 Thread Amit Kapila
Don't retreat slot's confirmed_flush LSN. Prevent moving the confirmed_flush backwards, as this could lead to data duplication issues caused by replicating already replicated changes. This can happen when a client acknowledges an LSN it doesn't have to do anything for, and thus didn't store persi