pgsql: doc: Fix incorrect UUID index entry in function documentation.

2025-06-23 Thread Fujii Masao
doc: Fix incorrect UUID index entry in function documentation. Previously, the UUID functions documentation defined the "UUID" index entry to link to the UUID data type page, even though that entry already exists there. Instead, the UUID functions page should define its own index entry linking to

pgsql: doc: Fix incorrect UUID index entry in function documentation.

2025-06-23 Thread Fujii Masao
doc: Fix incorrect UUID index entry in function documentation. Previously, the UUID functions documentation defined the "UUID" index entry to link to the UUID data type page, even though that entry already exists there. Instead, the UUID functions page should define its own index entry linking to

pgsql: doc: Fix incorrect UUID index entry in function documentation.

2025-06-23 Thread Fujii Masao
doc: Fix incorrect UUID index entry in function documentation. Previously, the UUID functions documentation defined the "UUID" index entry to link to the UUID data type page, even though that entry already exists there. Instead, the UUID functions page should define its own index entry linking to

pgsql: doc: Fix incorrect UUID index entry in function documentation.

2025-06-23 Thread Fujii Masao
doc: Fix incorrect UUID index entry in function documentation. Previously, the UUID functions documentation defined the "UUID" index entry to link to the UUID data type page, even though that entry already exists there. Instead, the UUID functions page should define its own index entry linking to

pgsql: psql: Rename meta-command \close to \close_prepared

2025-06-23 Thread Michael Paquier
psql: Rename meta-command \close to \close_prepared \close has been introduced in d55322b0da60 to be able to close a prepared statement using the extended protocol in psql. Per discussion, the name "close" is ambiguous. At the SQL level, CLOSE is used to close a cursor. At protocol level, the c

pgsql: Fix missing comment update in 1462aad2e4.

2025-06-23 Thread Amit Kapila
Fix missing comment update in 1462aad2e4. Remove the part of comment that says we don't allow toggling two_phase option as that is supported in commit 1462aad2e4. Author: Hayato Kuroda Author: Amit Kapila Discussion: https://postgr.es/m/oscpr01mb1496656725f3951aee8749ebdf5...@oscpr01mb14966.jp

Re: pgsql: Improve runtime and output of tests for replication slots checkp

2025-06-23 Thread Jelte Fennema-Nio
On Mon, 23 Jun 2025 at 20:50, Alexander Korotkov wrote: > I decided to remove the test while we're investigating the issue. It > might take a bit longer for us to fix, but that wouldn't distort > others' work. Sounds good. I reset the backoff of all jobs in the CFBot database, so that the commit

pgsql: Temporarily remove 046_checkpoint_logical_slot.pl

2025-06-23 Thread Alexander Korotkov
Temporarily remove 046_checkpoint_logical_slot.pl This new test was intended to check the handling of the replication slot's restart lsn fixed in ca307d5cec90. However, it also reveals another issue related to logical decoding. This commit temporarily removes this test to keep the buildfarm and

Re: pgsql: Improve runtime and output of tests for replication slots checkp

2025-06-23 Thread Alexander Korotkov
On Mon, Jun 23, 2025 at 4:33 PM Amit Kapila wrote: > On Mon, Jun 23, 2025 at 6:01 PM Alexander Korotkov > wrote: > > > > On Mon, Jun 23, 2025 at 3:00 PM Jelte Fennema-Nio > > wrote: > > > On Mon, 23 Jun 2025 at 12:24, Alexander Korotkov > > > wrote: > > > > On Mon, Jun 23, 2025 at 3:29 AM Mi

pgsql: Remove excess assert from InvalidatePossiblyObsoleteSlot()

2025-06-23 Thread Alexander Korotkov
Remove excess assert from InvalidatePossiblyObsoleteSlot() ca307d5cec90 introduced keeping WAL segments by slot's last saved restart LSN. It also added an assertion that the slot's restart LSN never goes backward. However, situations when the restart LSN goes backward have been spotted by buildfar

pgsql: Include _mm512_zextsi128_si512() in AVX-512 configure probes.

2025-06-23 Thread Tom Lane
Include _mm512_zextsi128_si512() in AVX-512 configure probes. Commit 43da39430 added a dependency on this intrinsic to our AVX-512 CRC code. It turns out this intrinsic was added to gcc later than the other ones we were using, so that there are platforms where the new code fails to compile. Sinc

Re: pgsql: Improve runtime and output of tests for replication slots checkp

2025-06-23 Thread Amit Kapila
On Mon, Jun 23, 2025 at 6:01 PM Alexander Korotkov wrote: > > On Mon, Jun 23, 2025 at 3:00 PM Jelte Fennema-Nio wrote: > > On Mon, 23 Jun 2025 at 12:24, Alexander Korotkov > > wrote: > > > On Mon, Jun 23, 2025 at 3:29 AM Michael Paquier > > > wrote: > > > > > Yeah, that's what I think too. T

Re: pgsql: Improve runtime and output of tests for replication slots checkp

2025-06-23 Thread vignesh C
On Sun, 22 Jun 2025 at 05:46, Alexander Korotkov wrote: > > On Sat, Jun 21, 2025 at 2:42 AM Tom Lane wrote: > > > > Alexander Korotkov writes: > > > And I see the following variable values. > > > > > (lldb) p/x targetPagePtr > > > (XLogRecPtr) 0x29004000 > > > (lldb) p/x RecPtr > > > (XL

Re: pgsql: Improve runtime and output of tests for replication slots checkp

2025-06-23 Thread Alexander Korotkov
On Mon, Jun 23, 2025 at 3:00 PM Jelte Fennema-Nio wrote: > On Mon, 23 Jun 2025 at 12:24, Alexander Korotkov wrote: > > On Mon, Jun 23, 2025 at 3:29 AM Michael Paquier wrote: > > > > Yeah, that's what I think too. The unintentional omission of a > > > > pre-shutdown delay in the 046 test has exp

Re: pgsql: Improve runtime and output of tests for replication slots checkp

2025-06-23 Thread Jelte Fennema-Nio
On Mon, 23 Jun 2025 at 12:24, Alexander Korotkov wrote: > > On Mon, Jun 23, 2025 at 3:29 AM Michael Paquier wrote: > > > Yeah, that's what I think too. The unintentional omission of a > > > pre-shutdown delay in the 046 test has exposed some pre-existing > > > fragility in pg_logical_slot_get_ch

pgsql: Properly fix AVX-512 CRC calculation bug

2025-06-23 Thread John Naylor
Properly fix AVX-512 CRC calculation bug The problem that led to the workaround in f83f14881c7 was not in fact a compiler bug, but a failure to zero the upper bits of the vector register containing the initial scalar CRC value. Fix that and revert the workaround. Diagnosed-by: Nathan Bossart Dia

Re: pgsql: Improve runtime and output of tests for replication slots checkp

2025-06-23 Thread Alexander Korotkov
On Mon, Jun 23, 2025 at 3:29 AM Michael Paquier wrote: > > Yeah, that's what I think too. The unintentional omission of a > > pre-shutdown delay in the 046 test has exposed some pre-existing > > fragility in pg_logical_slot_get_changes(). So I'm not in favor > > of changing 046 till we understan