pgsql: Fix typo in system_views.sql's definition of pg_stat_activity

2025-06-30 Thread Michael Paquier
Fix typo in system_views.sql's definition of pg_stat_activity backend_xmin used a lower-character 's' instead of the upper-character 'S' like the other attributes. This is harmless, but let's be consistent. Issue introduced in dd1a3bccca24. Author: Daisuke Higuchi Discussion: https://postgr.e

pgsql: Improve error handling of libxml2 calls in xml.c

2025-06-30 Thread Michael Paquier
Improve error handling of libxml2 calls in xml.c This commit fixes some defects in the backend's xml.c, found upon inspection of the internals of libxml2: - xmlEncodeSpecialChars() can fail on malloc(), returning NULL back to the caller. xmltext() assumed that this could never happen. Like other

pgsql: De-reserve keywords EXECUTE and STRICT in PL/pgSQL.

2025-06-30 Thread Tom Lane
De-reserve keywords EXECUTE and STRICT in PL/pgSQL. On close inspection, there does not seem to be a strong reason why these should be fully-reserved keywords. I guess they just escaped consideration in previous attempts to minimize PL/pgSQL's list of reserved words. Author: Tom Lane Reviewed-b

pgsql: Improve error report for PL/pgSQL reserved word used as a field

2025-06-30 Thread Tom Lane
Improve error report for PL/pgSQL reserved word used as a field name. The current code in resolve_column_ref (dating to commits 01f7d2990 and fe24d7816) believes that not finding a RECFIELD datum is a can't-happen case, in consequence of which I didn't spend a whole lot of time considering what to

pgsql: Add new OID alias type regdatabase.

2025-06-30 Thread Nathan Bossart
Add new OID alias type regdatabase. This provides a convenient way to look up a database's OID. For example, the query SELECT * FROM pg_shdepend WHERE dbid = (SELECT oid FROM pg_database WHERE datname = current_database()); can now be simplified to SELECT * FROM p

pgsql: aio: Fix reference to outdated name

2025-06-30 Thread Andres Freund
aio: Fix reference to outdated name Reported-by: Antonin Houska Author: Antonin Houska Discussion: https://postgr.es/m/5250.1751266701@localhost Backpatch-through: 18, where da7226993fd4 introduced this Branch -- REL_18_STABLE Details --- https://git.postgresql.org/pg/commitdiff/95163c

pgsql: aio: Fix reference to outdated name

2025-06-30 Thread Andres Freund
aio: Fix reference to outdated name Reported-by: Antonin Houska Author: Antonin Houska Discussion: https://postgr.es/m/5250.1751266701@localhost Backpatch-through: 18, where da7226993fd4 introduced this Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/f20a347e1a613

pgsql: Avoid uninitialized value error in TAP tests' Cluster->psql

2025-06-30 Thread Andrew Dunstan
Avoid uninitialized value error in TAP tests' Cluster->psql If the method is called in scalar context and we didn't pass in a stderr handle, one won't be created. However, some error paths assume that it exists, so in this case create a dummy stderr to avoid the resulting perl error. Per gripe fr

pgsql: pgflex: propagate environment to flex subprocess

2025-06-30 Thread Peter Eisentraut
pgflex: propagate environment to flex subprocess Python's subprocess.run docs say that if the env argument is not None, it will be used "instead of the default behavior of inheriting the current process’ environment". However, the environment should be preserved, only adding FLEX_TMP_DIR to it.

pgsql: Remove unused #include's in src/backend/utils/adt/*

2025-06-30 Thread Peter Eisentraut
Remove unused #include's in src/backend/utils/adt/* Author: Aleksander Alekseev Reviewed-by: Tom Lane Discussion: https://postgr.es/m/CAJ7c6TOowVbR-0NEvvDm6a_mag18krR0XJ2FKrc9DHXj7hFRtQ%40mail.gmail.com Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/cc2ac0e6f99e

pgsql: doc: Fix typo in pg_sync_replication_slots documentation

2025-06-30 Thread Daniel Gustafsson
doc: Fix typo in pg_sync_replication_slots documentation Commit 1546e17f9d0 accidentally misspelled additionally as additionaly. Backpatch to v17 to match where the original commit was backpatched. Author: Daniel Gustafsson Backpatch-through: 17 Branch -- REL_18_STABLE Details --- htt

pgsql: Fix whitespace

2025-06-30 Thread Peter Eisentraut
Fix whitespace Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/a6a4641252ed166ba187d7fbe0504ddb5a5f0e33 Modified Files -- src/tools/git_changelog | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

pgsql: psql: Improve tab completion for COPY command.

2025-06-30 Thread Fujii Masao
psql: Improve tab completion for COPY command. Previously, tab completion for COPY only suggested plain tables and partitioned tables, even though materialized views are also valid for COPY TO (since commit 534874fac0b), and foreign tables are valid for COPY FROM. This commit enhances tab complet

pgsql: doc: explain pgstatindex fragmentation

2025-06-30 Thread Peter Eisentraut
doc: explain pgstatindex fragmentation It was quite hard to guess what leaf_fragmentation meant without looking at pgstattuple's code. This patch aims to give to the user a better idea of what it means. Author: Frédéric Yhuel Author: Laurenz Albe Reviewed-by: Bertrand Drouvot Reviewed-by: Ben

pgsql: pgbench: Use standard option handling test routines

2025-06-30 Thread Peter Eisentraut
pgbench: Use standard option handling test routines Run program_XXX tests instead of its own tests. This ensures consistency with the test suites of other programs and enforces common policies, such as help line length. Author: Hayato Kuroda Reviewed-by: Fujii Masao Discussion: https://www.po

pgsql: doc: Some copy-editing around prefix operators

2025-06-30 Thread Peter Eisentraut
doc: Some copy-editing around prefix operators When postfix operators where dropped in 1ed6b8956, the CREATE OPERATOR docs were not updated to make the RIGHTARG argument mandatory in the grammar. While at it, make the RIGHTARG docs more concise. Also, the operator docs were mentioning "infix" in

pgsql: doc: Fix typo in pg_sync_replication_slots documentation

2025-06-30 Thread Daniel Gustafsson
doc: Fix typo in pg_sync_replication_slots documentation Commit 1546e17f9d0 accidentally misspelled additionally as additionaly. Backpatch to v17 to match where the original commit was backpatched. Author: Daniel Gustafsson Backpatch-through: 17 Branch -- REL_17_STABLE Details --- htt

pgsql: doc: Fix typo in pg_sync_replication_slots documentation

2025-06-30 Thread Daniel Gustafsson
doc: Fix typo in pg_sync_replication_slots documentation Commit 1546e17f9d0 accidentally misspelled additionally as additionaly. Backpatch to v17 to match where the original commit was backpatched. Author: Daniel Gustafsson Backpatch-through: 17 Branch -- master Details --- https://gi