Re: pgsql: Fix up misuse of "volatile" in contrib/xml2.

2025-07-09 Thread Michael Paquier
On Wed, Jul 09, 2025 at 11:49:55AM -0400, Tom Lane wrote: > Not sure. Yesterday I saw such warnings from arowana, > boa, dhole, rhinoceros, and shelduck, eg > > arowana | 2025-07-08 04:54:18 | xpath.c:274:6: warning: 'workspace' > may be used uninitialized in this function [-Wmaybe-uninit

pgsql: btree_gist: Merge the last two versions into version 1.8

2025-07-09 Thread Michael Paquier
btree_gist: Merge the last two versions into version 1.8 During the development cycle of v18, btree_gist has been bumped once to 1.8 for the addition of translate_cmptype support functions (originally 7406ab623fee, renamed in 32edf732e8dc). 1.9 has added sortsupport functions (e4309f73f698). The

pgsql: btree_gist: Merge the last two versions into version 1.8

2025-07-09 Thread Michael Paquier
btree_gist: Merge the last two versions into version 1.8 During the development cycle of v18, btree_gist has been bumped once to 1.8 for the addition of translate_cmptype support functions (originally 7406ab623fee, renamed in 32edf732e8dc). 1.9 has added sortsupport functions (e4309f73f698). The

pgsql: injection_points: Add injection_points_list()

2025-07-09 Thread Michael Paquier
injection_points: Add injection_points_list() This function can be used to retrieve the information about all the injection points attached to a cluster, providing coverage for InjectionPointList() introduced in 7b2eb72b1b8c. The original proposal turned around a system function, but that would n

pgsql: Add pg_assume(expr) macro

2025-07-09 Thread Andres Freund
Add pg_assume(expr) macro This macro can be used to avoid compiler warnings, particularly when using -O3 and not using assertions, and to get the compiler to generate better code. A subsequent commit introduces a first user. Reviewed-by: Tom Lane Discussion: https://postgr.es/m/3prdb6hkep3dugl

pgsql: Use pg_assume() to avoid compiler warning below exec_set_found()

2025-07-09 Thread Andres Freund
Use pg_assume() to avoid compiler warning below exec_set_found() The warning, visible when building with -O3 and a recent-ish gcc, is due to gcc not realizing that found is a byvalue type and therefore will never be interpreted as a varlena type. Discussion: https://postgr.es/m/3prdb6hkep3duglhs

pgsql: Link libpq with libdl if the platform needs that.

2025-07-09 Thread Tom Lane
Link libpq with libdl if the platform needs that. Since b0635bfda, libpq uses dlopen() and related functions. On some platforms these are not supplied by libc, but by a separate library libdl, in which case we need to make sure that that dependency is known to the linker. Meson seems to take car

pgsql: Link libpq with libdl if the platform needs that.

2025-07-09 Thread Tom Lane
Link libpq with libdl if the platform needs that. Since b0635bfda, libpq uses dlopen() and related functions. On some platforms these are not supplied by libc, but by a separate library libdl, in which case we need to make sure that that dependency is known to the linker. Meson seems to take car

Re: pgsql: Fix up misuse of "volatile" in contrib/xml2.

2025-07-09 Thread Tom Lane
Michael Paquier writes: > On Tue, Jul 08, 2025 at 09:00:39PM +, Tom Lane wrote: >> Also fix a number of places where variables that are assigned to >> within a PG_TRY and then used after it were not initialized or >> not marked as volatile. (A few buildfarm members were issuing >> "may be use

pgsql: Change wchar2char() and char2wchar() to accept a locale_t.

2025-07-09 Thread Jeff Davis
Change wchar2char() and char2wchar() to accept a locale_t. These are libc-specific functions, so should require a locale_t rather than a pg_locale_t (which could use another provider). Discussion: https://postgr.es/m/a8666c391dfcabe79868d95f7160eac533ace718.camel%40j-davis.com Branch -- mas

pgsql: Minor tweaks for pg_test_timing.

2025-07-09 Thread Tom Lane
Minor tweaks for pg_test_timing. Increase the size of the "direct" histogram to 10K elements, so that we can precisely track loop times up to 10 microseconds. (Going further than that seems pretty uninteresting, even for very old and slow machines.) Relabel "Per loop time" as "Average loop time"

pgsql: Introduce pg_dsm_registry_allocations view.

2025-07-09 Thread Nathan Bossart
Introduce pg_dsm_registry_allocations view. This commit adds a new system view that provides information about entries in the dynamic shared memory (DSM) registry. Specifically, it returns the name, type, and size of each entry. Note that since we cannot discover the size of dynamic shared memor

pgsql: Fix tab-completion for COPY and \copy options.

2025-07-09 Thread Masahiko Sawada
Fix tab-completion for COPY and \copy options. Commit c273d9d8ce4 reworked tab-completion of COPY and \copy in psql and added support for completing options within WITH clauses. However, the same COPY options were suggested for both COPY TO and COPY FROM commands, even though some options are only

pgsql: Fix tab-completion for COPY and \copy options.

2025-07-09 Thread Masahiko Sawada
Fix tab-completion for COPY and \copy options. Commit c273d9d8ce4 reworked tab-completion of COPY and \copy in psql and added support for completing options within WITH clauses. However, the same COPY options were suggested for both COPY TO and COPY FROM commands, even though some options are only

pgsql: Fix tab-completion for COPY and \copy options.

2025-07-09 Thread Masahiko Sawada
Fix tab-completion for COPY and \copy options. Commit c273d9d8ce4 reworked tab-completion of COPY and \copy in psql and added support for completing options within WITH clauses. However, the same COPY options were suggested for both COPY TO and COPY FROM commands, even though some options are only

pgsql: Fix tab-completion for COPY and \copy options.

2025-07-09 Thread Masahiko Sawada
Fix tab-completion for COPY and \copy options. Commit c273d9d8ce4 reworked tab-completion of COPY and \copy in psql and added support for completing options within WITH clauses. However, the same COPY options were suggested for both COPY TO and COPY FROM commands, even though some options are only

pgsql: Fix tab-completion for COPY and \copy options.

2025-07-09 Thread Masahiko Sawada
Fix tab-completion for COPY and \copy options. Commit c273d9d8ce4 reworked tab-completion of COPY and \copy in psql and added support for completing options within WITH clauses. However, the same COPY options were suggested for both COPY TO and COPY FROM commands, even though some options are only

pgsql: Fix tab-completion for COPY and \copy options.

2025-07-09 Thread Masahiko Sawada
Fix tab-completion for COPY and \copy options. Commit c273d9d8ce4 reworked tab-completion of COPY and \copy in psql and added support for completing options within WITH clauses. However, the same COPY options were suggested for both COPY TO and COPY FROM commands, even though some options are only

pgsql: psql: Improve psql tab completion for GRANT/REVOKE on large obje

2025-07-09 Thread Fujii Masao
psql: Improve psql tab completion for GRANT/REVOKE on large objects. This commit enhances psql's tab completion to support TO/FROM after "GRANT/REVOKE ... ON LARGE OBJECT ...". Additionally, since "ALTER DEFAULT PRIVILEGES" now supports large objects, tab completion is also updated for "GRANT/REVO

pgsql: Hide ICU C++ APIs from pg_locale.h

2025-07-09 Thread John Naylor
Hide ICU C++ APIs from pg_locale.h The cpluspluscheck script wraps our headers in `extern "C"`. This disables name mangling, which is necessary for the C++ templates in system ICU headers. cpluspluscheck thus fails when the build is configured with ICU (the default). CI worked around this by disab