Re: pgsql: injection_points: Add injection_points_list()

2025-07-12 Thread Michael Paquier
On Thu, Jul 10, 2025 at 01:24:48PM +0300, Aleksander Alekseev wrote: > In injection_points_list() isn't `memset(values, 0, sizeof(values))` > redundant? Yes, I'm just finding this to be a cleaner practice. > Also perhaps we want to pfree inj_points. This is freed with the memory context of the f

pgsql: Remove XLogCtl->ckptFullXid.

2025-07-12 Thread Nathan Bossart
Remove XLogCtl->ckptFullXid. A few code paths set this variable, but its value is never used. Oversight in commit 2fc7af5e96. Reviewed-by: Aleksander Alekseev Discussion: https://postgr.es/m/aHFyE1bs9YR93dQ1%40nathan Branch -- master Details --- https://git.postgresql.org/pg/commitdif

pgsql: Replace float8 with int in date2isoweek() and date2isoyear().

2025-07-12 Thread Tom Lane
Replace float8 with int in date2isoweek() and date2isoyear(). The values of the "result" variables in these functions are always integers; using a float8 variable accomplishes nothing except to incur useless conversions to and from float. While that wastes a few nanoseconds, these functions aren'

pgsql: Remove long-unused TransactionIdIsActive()

2025-07-12 Thread Andres Freund
Remove long-unused TransactionIdIsActive() TransactionIdIsActive() has not been used since bb38fb0d43c, in 2014. There are no known uses in extensions either and it's hard to see valid uses for it. Therefore remove TransactionIdIsActive(). Discussion: https://postgr.es/m/odgftbtwp5oq7cxjgf4kjkmy