pgsql: Refactor non-supported compression error message in toast_compre

2025-07-15 Thread Michael Paquier
Refactor non-supported compression error message in toast_compression.c This code used a NO_LZ4_SUPPORT() macro to issue an error in the code paths where LZ4 [de]compression is attempted but the build does not support it. This commit refactors the code to use a more flexible error message so as i

pgsql: pgoutput: Initialize missing default for "origin" parameter.

2025-07-15 Thread Fujii Masao
pgoutput: Initialize missing default for "origin" parameter. The pgoutput plugin initializes optional parameters like "binary" with default values at the start of processing. However, the "origin" parameter was previously missed and left without explicit initialization. Although the PGOutputData

pgsql: doc: Document default values for pgoutput options in protocol.sg

2025-07-15 Thread Fujii Masao
doc: Document default values for pgoutput options in protocol.sgml. The pgoutput plugin options are described in the logical streaming replication protocol documentation, but their default values were previously not mentioned. This made it less convenient for users, for example, when specifying th

pgsql: doc: Fix confusing description of streaming option in START_REPL

2025-07-15 Thread Fujii Masao
doc: Fix confusing description of streaming option in START_REPLICATION. Previously, the documentation described the streaming option as a boolean, which is outdated since it's no longer a boolean as of protocol version 4. This could confuse users. This commit updates the description to remove th

pgsql: doc: Fix confusing description of streaming option in START_REPL

2025-07-15 Thread Fujii Masao
doc: Fix confusing description of streaming option in START_REPLICATION. Previously, the documentation described the streaming option as a boolean, which is outdated since it's no longer a boolean as of protocol version 4. This could confuse users. This commit updates the description to remove th

pgsql: doc: Fix confusing description of streaming option in START_REPL

2025-07-15 Thread Fujii Masao
doc: Fix confusing description of streaming option in START_REPLICATION. Previously, the documentation described the streaming option as a boolean, which is outdated since it's no longer a boolean as of protocol version 4. This could confuse users. This commit updates the description to remove th

pgsql: doc: Fix confusing description of streaming option in START_REPL

2025-07-15 Thread Fujii Masao
doc: Fix confusing description of streaming option in START_REPLICATION. Previously, the documentation described the streaming option as a boolean, which is outdated since it's no longer a boolean as of protocol version 4. This could confuse users. This commit updates the description to remove th

pgsql: doc: Clarify that total_vacuum_time excludes VACUUM FULL.

2025-07-15 Thread Fujii Masao
doc: Clarify that total_vacuum_time excludes VACUUM FULL. The last_vacuum and vacuum_count fields in pg_stat_all_tables already state that they do not include VACUUM FULL. However, total_vacuum_time, which also excludes VACUUM FULL, did not mention this. This could mislead users into thinking VACU

pgsql: doc: Clarify that total_vacuum_time excludes VACUUM FULL.

2025-07-15 Thread Fujii Masao
doc: Clarify that total_vacuum_time excludes VACUUM FULL. The last_vacuum and vacuum_count fields in pg_stat_all_tables already state that they do not include VACUUM FULL. However, total_vacuum_time, which also excludes VACUUM FULL, did not mention this. This could mislead users into thinking VACU

pgsql: Doc: clarify description of regexp fields in pg_ident.conf.

2025-07-15 Thread Tom Lane
Doc: clarify description of regexp fields in pg_ident.conf. The grammar was a little shaky and confusing here, so word-smith it a bit. Also, adjust the comments in pg_ident.conf.sample to use the same terminology as the SGML docs, in particular "DATABASE-USERNAME" not "PG-USERNAME". Back-patch a

pgsql: Doc: clarify description of regexp fields in pg_ident.conf.

2025-07-15 Thread Tom Lane
Doc: clarify description of regexp fields in pg_ident.conf. The grammar was a little shaky and confusing here, so word-smith it a bit. Also, adjust the comments in pg_ident.conf.sample to use the same terminology as the SGML docs, in particular "DATABASE-USERNAME" not "PG-USERNAME". Back-patch a

pgsql: Doc: clarify description of regexp fields in pg_ident.conf.

2025-07-15 Thread Tom Lane
Doc: clarify description of regexp fields in pg_ident.conf. The grammar was a little shaky and confusing here, so word-smith it a bit. Also, adjust the comments in pg_ident.conf.sample to use the same terminology as the SGML docs, in particular "DATABASE-USERNAME" not "PG-USERNAME". Back-patch a

pgsql: Doc: clarify description of regexp fields in pg_ident.conf.

2025-07-15 Thread Tom Lane
Doc: clarify description of regexp fields in pg_ident.conf. The grammar was a little shaky and confusing here, so word-smith it a bit. Also, adjust the comments in pg_ident.conf.sample to use the same terminology as the SGML docs, in particular "DATABASE-USERNAME" not "PG-USERNAME". Back-patch a

pgsql: Doc: clarify description of regexp fields in pg_ident.conf.

2025-07-15 Thread Tom Lane
Doc: clarify description of regexp fields in pg_ident.conf. The grammar was a little shaky and confusing here, so word-smith it a bit. Also, adjust the comments in pg_ident.conf.sample to use the same terminology as the SGML docs, in particular "DATABASE-USERNAME" not "PG-USERNAME". Back-patch a

pgsql: Doc: clarify description of regexp fields in pg_ident.conf.

2025-07-15 Thread Tom Lane
Doc: clarify description of regexp fields in pg_ident.conf. The grammar was a little shaky and confusing here, so word-smith it a bit. Also, adjust the comments in pg_ident.conf.sample to use the same terminology as the SGML docs, in particular "DATABASE-USERNAME" not "PG-USERNAME". Back-patch a

pgsql: Doc: clarify description of regexp fields in pg_ident.conf.

2025-07-15 Thread Tom Lane
Doc: clarify description of regexp fields in pg_ident.conf. The grammar was a little shaky and confusing here, so word-smith it a bit. Also, adjust the comments in pg_ident.conf.sample to use the same terminology as the SGML docs, in particular "DATABASE-USERNAME" not "PG-USERNAME". Back-patch a

pgsql: Clarify the ra != rb case in compareJsonbContainers().

2025-07-15 Thread Tom Lane
Clarify the ra != rb case in compareJsonbContainers(). It's impossible to reach this case with either ra or rb being WJB_DONE, because our earlier checks that the structure and length of the inputs match should guarantee that we reach their ends simultaneously. However, the comment completely fai

pgsql: Silence uninitialized-value warnings in compareJsonbContainers()

2025-07-15 Thread Tom Lane
Silence uninitialized-value warnings in compareJsonbContainers(). Because not every path through JsonbIteratorNext() sets val->type, some compilers complain that compareJsonbContainers() is comparing possibly-uninitialized values. The paths that don't set it return WJB_DONE, WJB_END_ARRAY, or WJB

pgsql: Silence uninitialized-value warnings in compareJsonbContainers()

2025-07-15 Thread Tom Lane
Silence uninitialized-value warnings in compareJsonbContainers(). Because not every path through JsonbIteratorNext() sets val->type, some compilers complain that compareJsonbContainers() is comparing possibly-uninitialized values. The paths that don't set it return WJB_DONE, WJB_END_ARRAY, or WJB

pgsql: Silence uninitialized-value warnings in compareJsonbContainers()

2025-07-15 Thread Tom Lane
Silence uninitialized-value warnings in compareJsonbContainers(). Because not every path through JsonbIteratorNext() sets val->type, some compilers complain that compareJsonbContainers() is comparing possibly-uninitialized values. The paths that don't set it return WJB_DONE, WJB_END_ARRAY, or WJB

pgsql: Silence uninitialized-value warnings in compareJsonbContainers()

2025-07-15 Thread Tom Lane
Silence uninitialized-value warnings in compareJsonbContainers(). Because not every path through JsonbIteratorNext() sets val->type, some compilers complain that compareJsonbContainers() is comparing possibly-uninitialized values. The paths that don't set it return WJB_DONE, WJB_END_ARRAY, or WJB

pgsql: Silence uninitialized-value warnings in compareJsonbContainers()

2025-07-15 Thread Tom Lane
Silence uninitialized-value warnings in compareJsonbContainers(). Because not every path through JsonbIteratorNext() sets val->type, some compilers complain that compareJsonbContainers() is comparing possibly-uninitialized values. The paths that don't set it return WJB_DONE, WJB_END_ARRAY, or WJB

pgsql: Silence uninitialized-value warnings in compareJsonbContainers()

2025-07-15 Thread Tom Lane
Silence uninitialized-value warnings in compareJsonbContainers(). Because not every path through JsonbIteratorNext() sets val->type, some compilers complain that compareJsonbContainers() is comparing possibly-uninitialized values. The paths that don't set it return WJB_DONE, WJB_END_ARRAY, or WJB

pgsql: Silence uninitialized-value warnings in compareJsonbContainers()

2025-07-15 Thread Tom Lane
Silence uninitialized-value warnings in compareJsonbContainers(). Because not every path through JsonbIteratorNext() sets val->type, some compilers complain that compareJsonbContainers() is comparing possibly-uninitialized values. The paths that don't set it return WJB_DONE, WJB_END_ARRAY, or WJB

pgsql: Tag refs/tags/REL_18_BETA2 was created

2025-07-15 Thread noreply
Tag refs/tags/REL_18_BETA2 was created.

pgsql: Doc: clarify description of current-date/time functions.

2025-07-15 Thread Tom Lane
Doc: clarify description of current-date/time functions. Minor wordsmithing of the func.sgml paragraph describing statement_timestamp() and allied functions: don't switch between "statement" and "command" when those are being used to mean about the same thing. Also, add some text to protocol.sgml

pgsql: Doc: clarify description of current-date/time functions.

2025-07-15 Thread Tom Lane
Doc: clarify description of current-date/time functions. Minor wordsmithing of the func.sgml paragraph describing statement_timestamp() and allied functions: don't switch between "statement" and "command" when those are being used to mean about the same thing. Also, add some text to protocol.sgml

pgsql: Doc: clarify description of current-date/time functions.

2025-07-15 Thread Tom Lane
Doc: clarify description of current-date/time functions. Minor wordsmithing of the func.sgml paragraph describing statement_timestamp() and allied functions: don't switch between "statement" and "command" when those are being used to mean about the same thing. Also, add some text to protocol.sgml

pgsql: Doc: clarify description of current-date/time functions.

2025-07-15 Thread Tom Lane
Doc: clarify description of current-date/time functions. Minor wordsmithing of the func.sgml paragraph describing statement_timestamp() and allied functions: don't switch between "statement" and "command" when those are being used to mean about the same thing. Also, add some text to protocol.sgml

pgsql: Doc: clarify description of current-date/time functions.

2025-07-15 Thread Tom Lane
Doc: clarify description of current-date/time functions. Minor wordsmithing of the func.sgml paragraph describing statement_timestamp() and allied functions: don't switch between "statement" and "command" when those are being used to mean about the same thing. Also, add some text to protocol.sgml

pgsql: Doc: clarify description of current-date/time functions.

2025-07-15 Thread Tom Lane
Doc: clarify description of current-date/time functions. Minor wordsmithing of the func.sgml paragraph describing statement_timestamp() and allied functions: don't switch between "statement" and "command" when those are being used to mean about the same thing. Also, add some text to protocol.sgml

pgsql: Doc: clarify description of current-date/time functions.

2025-07-15 Thread Tom Lane
Doc: clarify description of current-date/time functions. Minor wordsmithing of the func.sgml paragraph describing statement_timestamp() and allied functions: don't switch between "statement" and "command" when those are being used to mean about the same thing. Also, add some text to protocol.sgml

pgsql: psql: Fix tab-completion after GRANT/REVOKE on LARGE OBJECT and

2025-07-15 Thread Fujii Masao
psql: Fix tab-completion after GRANT/REVOKE on LARGE OBJECT and FOREIGN SERVER. Previously, when pressing Tab after GRANT or REVOKE ... ON LARGE OBJECT or ON FOREIGN SERVER, TO or FROM was incorrectly suggested by psql's tab-completion. This was not appropriate, as those clauses are not valid at t

pgsql: Fix comments in index.c

2025-07-15 Thread Michael Paquier
Fix comments in index.c This comment paragraph referred to text_eq(), but the name of the function in charge of "text" comparisons is called texteq(). Author: Jian He Discussion: https://postgr.es/m/cacjufxhl--xnccco1lgksygzygivhzmftcaxosg8+ezxwtj...@mail.gmail.com Branch -- master Detail