pgsql: Apply some fat commas to commands of TAP tests

2025-08-20 Thread Michael Paquier
Apply some fat commas to commands of TAP tests This is similar to 19c6e92b13b2, in order to keep the style used in the scripts consistent for the option names and values used in commands. The places updated in this commit have been added recently in 71ea0d679543. These changes are cosmetic; there

pgsql: doc: Improve description of wal_compression

2025-08-20 Thread Michael Paquier
doc: Improve description of wal_compression The description of this GUC provides a list of the situations where full-page writes are generated. However, it is not completely exact, mentioning only the cases where full_page_writes=on or base backups. It is possible to generate full-page writes in

pgsql: doc: Improve description of wal_compression

2025-08-20 Thread Michael Paquier
doc: Improve description of wal_compression The description of this GUC provides a list of the situations where full-page writes are generated. However, it is not completely exact, mentioning only the cases where full_page_writes=on or base backups. It is possible to generate full-page writes in

pgsql: doc: Improve description of wal_compression

2025-08-20 Thread Michael Paquier
doc: Improve description of wal_compression The description of this GUC provides a list of the situations where full-page writes are generated. However, it is not completely exact, mentioning only the cases where full_page_writes=on or base backups. It is possible to generate full-page writes in

pgsql: doc: Improve description of wal_compression

2025-08-20 Thread Michael Paquier
doc: Improve description of wal_compression The description of this GUC provides a list of the situations where full-page writes are generated. However, it is not completely exact, mentioning only the cases where full_page_writes=on or base backups. It is possible to generate full-page writes in

pgsql: doc: Improve description of wal_compression

2025-08-20 Thread Michael Paquier
doc: Improve description of wal_compression The description of this GUC provides a list of the situations where full-page writes are generated. However, it is not completely exact, mentioning only the cases where full_page_writes=on or base backups. It is possible to generate full-page writes in

pgsql: doc: Improve description of wal_compression

2025-08-20 Thread Michael Paquier
doc: Improve description of wal_compression The description of this GUC provides a list of the situations where full-page writes are generated. However, it is not completely exact, mentioning only the cases where full_page_writes=on or base backups. It is possible to generate full-page writes in

pgsql: doc: Improve description of wal_compression

2025-08-20 Thread Michael Paquier
doc: Improve description of wal_compression The description of this GUC provides a list of the situations where full-page writes are generated. However, it is not completely exact, mentioning only the cases where full_page_writes=on or base backups. It is possible to generate full-page writes in

pgsql: Fix re-execution of a failed SQLFunctionCache entry.

2025-08-20 Thread Tom Lane
Fix re-execution of a failed SQLFunctionCache entry. If we error out during execution of a SQL-language function, we will often leave behind non-null pointers in its SQLFunctionCache's cplan and eslist fields. This is problematic if the SQLFunctionCache is re-used, because those pointers will poi

pgsql: Fix re-execution of a failed SQLFunctionCache entry.

2025-08-20 Thread Tom Lane
Fix re-execution of a failed SQLFunctionCache entry. If we error out during execution of a SQL-language function, we will often leave behind non-null pointers in its SQLFunctionCache's cplan and eslist fields. This is problematic if the SQLFunctionCache is re-used, because those pointers will poi

pgsql: Minor error message enhancement

2025-08-20 Thread Peter Eisentraut
Minor error message enhancement In refuseDupeIndexAttach(), change from errdetail("Another index is already attached for partition \"%s\"."...) to errdetail("Another index \"%s\" is already attached for partition \"%s\"."...) so we can easily understand which index is already attached

Re: pgsql: Move SQL-callable code related to multixacts into its own file

2025-08-20 Thread Tom Lane
Bertrand Drouvot writes: > On Tue, Aug 19, 2025 at 11:27:25AM -0400, Tom Lane wrote: >> I think "make world-bin" >> or "make install-world" are the accepted targets for building everything. > From what I can see, only: > check-world: > checkprep: > installcheck-world: > build src/test/modules. I

Re: pgsql: Move SQL-callable code related to multixacts into its own file

2025-08-20 Thread Michael Paquier
On Tue, Aug 19, 2025 at 12:31:14PM +0200, Alvaro Herrera wrote: > Hmm, don't you find strange that dbcommands.h is still included there? > I wondered about that and found out that we have get_database_name() > declared there. It sort-of makes sense, because it was originally done > by scanning pg_