pgsql: Minor fixups of test_bitmapset.c

2025-09-30 Thread David Rowley
Minor fixups of test_bitmapset.c The macro's comment had become outdated from a prior version and there's now no longer a need for the do/while loop (or my misplaced semi-colon). Author: David Rowley Discussion: https://postgr.es/m/[email protected].

pgsql: pgbench: Fix error reporting in readCommandResponse().

2025-09-30 Thread Fujii Masao
pgbench: Fix error reporting in readCommandResponse(). pgbench uses readCommandResponse() to process server responses. When readCommandResponse() encounters an error during a call to PQgetResult() to fetch the current result, it attempts to report it with an additional error message from PQerrorMe

pgsql: pgbench: Fix error reporting in readCommandResponse().

2025-09-30 Thread Fujii Masao
pgbench: Fix error reporting in readCommandResponse(). pgbench uses readCommandResponse() to process server responses. When readCommandResponse() encounters an error during a call to PQgetResult() to fetch the current result, it attempts to report it with an additional error message from PQerrorMe

Re: pgsql: Make some use of anonymous unions [pgcrypto]

2025-09-30 Thread David Rowley
On Tue, 30 Sept 2025 at 23:37, Peter Eisentraut wrote: > src/common/cryptohash.c| 36 ++-- This seems to be causing some trouble: https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=sifaka&dt=2025-09-30%2010%3A57%3A42 David

pgsql: Make some use of anonymous unions [pgcrypto]

2025-09-30 Thread Peter Eisentraut
Make some use of anonymous unions [pgcrypto] Make some use of anonymous unions, which are allowed as of C11, as examples and encouragement for future code, and to test compilers. This commit changes some structures in pgcrypto. Reviewed-by: Chao Li Discussion: https://www.postgresql.org/messag

pgsql: Make some use of anonymous unions [plpython]

2025-09-30 Thread Peter Eisentraut
Make some use of anonymous unions [plpython] Make some use of anonymous unions, which are allowed as of C11, as examples and encouragement for future code, and to test compilers. This commit changes some structures in plpython. Reviewed-by: Chao Li Discussion: https://www.postgresql.org/messag

pgsql: Do a tiny bit of header file maintenance

2025-09-30 Thread Álvaro Herrera
Do a tiny bit of header file maintenance Stop including utils/relcache.h in access/genam.h, and stop including htup_details.h in nodes/tidbitmap.h. Both these files (genam.h and tidbitmap.h) are widely used in other header files, so it's in our best interest that they remain as lean as reasonable