pgsql: Add test tracking WAL receiver shutdown for primary_conninfo upd

Add test tracking WAL receiver shutdown for primary_conninfo updates The test introduced by this commit checks that a reload of primary_conninfo leads to a WAL receiver restarted, by looking at the request generated in the server logs. This is something for what there was no coverage. This has c

pgsql: doc: rewrite random_page_cost description

doc: rewrite random_page_cost description This removes some of the specifics of how the default was set, and adds a mention of latency as a reason the value is lower than the storage hardware might suggest. It still mentions caching. Discussion: https://postgr.es/m/cakanmmk_nspyr53lobuwqd59a-8

pgsql: doc: rewrite random_page_cost description

doc: rewrite random_page_cost description This removes some of the specifics of how the default was set, and adds a mention of latency as a reason the value is lower than the storage hardware might suggest. It still mentions caching. Discussion: https://postgr.es/m/cakanmmk_nspyr53lobuwqd59a-8

pgsql: doc: rewrite random_page_cost description

doc: rewrite random_page_cost description This removes some of the specifics of how the default was set, and adds a mention of latency as a reason the value is lower than the storage hardware might suggest. It still mentions caching. Discussion: https://postgr.es/m/cakanmmk_nspyr53lobuwqd59a-8

pgsql: doc: rewrite random_page_cost description

doc: rewrite random_page_cost description This removes some of the specifics of how the default was set, and adds a mention of latency as a reason the value is lower than the storage hardware might suggest. It still mentions caching. Discussion: https://postgr.es/m/cakanmmk_nspyr53lobuwqd59a-8

pgsql: doc: rewrite random_page_cost description

doc: rewrite random_page_cost description This removes some of the specifics of how the default was set, and adds a mention of latency as a reason the value is lower than the storage hardware might suggest. It still mentions caching. Discussion: https://postgr.es/m/cakanmmk_nspyr53lobuwqd59a-8

pgsql: doc: rewrite random_page_cost description

doc: rewrite random_page_cost description This removes some of the specifics of how the default was set, and adds a mention of latency as a reason the value is lower than the storage hardware might suggest. It still mentions caching. Discussion: https://postgr.es/m/cakanmmk_nspyr53lobuwqd59a-8

pgsql: doc: rewrite random_page_cost description

doc: rewrite random_page_cost description This removes some of the specifics of how the default was set, and adds a mention of latency as a reason the value is lower than the storage hardware might suggest. It still mentions caching. Discussion: https://postgr.es/m/cakanmmk_nspyr53lobuwqd59a-8

pgsql: ci: macos: Upgrade to Sequoia

ci: macos: Upgrade to Sequoia Author: Nazir Bilal Yavuz Discussion: https://postgr.es/m/CAN55FZ3kO4vLq56PWrfJ7Fw6Wz8DhEN9j9GX3aScx%2BWOirtK-g%40mail.gmail.com Backpatch: 15-, where CI support was added Branch -- REL_16_STABLE Details --- https://git.postgresql.org/pg/commitdiff/fca4f5f

pgsql: ci: macos: Upgrade to Sequoia

ci: macos: Upgrade to Sequoia Author: Nazir Bilal Yavuz Discussion: https://postgr.es/m/CAN55FZ3kO4vLq56PWrfJ7Fw6Wz8DhEN9j9GX3aScx%2BWOirtK-g%40mail.gmail.com Backpatch: 15-, where CI support was added Branch -- REL_18_STABLE Details --- https://git.postgresql.org/pg/commitdiff/a7e7bca

pgsql: ci: macos: Upgrade to Sequoia

ci: macos: Upgrade to Sequoia Author: Nazir Bilal Yavuz Discussion: https://postgr.es/m/CAN55FZ3kO4vLq56PWrfJ7Fw6Wz8DhEN9j9GX3aScx%2BWOirtK-g%40mail.gmail.com Backpatch: 15-, where CI support was added Branch -- REL_17_STABLE Details --- https://git.postgresql.org/pg/commitdiff/d6e6abc

pgsql: ci: macos: Upgrade to Sequoia

ci: macos: Upgrade to Sequoia Author: Nazir Bilal Yavuz Discussion: https://postgr.es/m/CAN55FZ3kO4vLq56PWrfJ7Fw6Wz8DhEN9j9GX3aScx%2BWOirtK-g%40mail.gmail.com Backpatch: 15-, where CI support was added Branch -- REL_15_STABLE Details --- https://git.postgresql.org/pg/commitdiff/a027ce3

pgsql: ci: macos: Upgrade to Sequoia

ci: macos: Upgrade to Sequoia Author: Nazir Bilal Yavuz Discussion: https://postgr.es/m/CAN55FZ3kO4vLq56PWrfJ7Fw6Wz8DhEN9j9GX3aScx%2BWOirtK-g%40mail.gmail.com Backpatch: 15-, where CI support was added Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/9c398fdf48176c

pgsql: ci: Fix Windows and MinGW task names

ci: Fix Windows and MinGW task names They use Windows Server 2022, not 2019. Author: Nazir Bilal Yavuz Discussion: https://postgr.es/m/flat/can55fz1osam+852bmqdj+kgfg+07knj6dm3pjbgbtyak4qw...@mail.gmail.com Branch -- REL_16_STABLE Details --- https://git.postgresql.org/pg/commitdiff/2

pgsql: ci: Fix Windows and MinGW task names

ci: Fix Windows and MinGW task names They use Windows Server 2022, not 2019. Author: Nazir Bilal Yavuz Discussion: https://postgr.es/m/flat/can55fz1osam+852bmqdj+kgfg+07knj6dm3pjbgbtyak4qw...@mail.gmail.com Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/0a8a4be8

pgsql: ci: Fix Windows and MinGW task names

ci: Fix Windows and MinGW task names They use Windows Server 2022, not 2019. Author: Nazir Bilal Yavuz Discussion: https://postgr.es/m/flat/can55fz1osam+852bmqdj+kgfg+07knj6dm3pjbgbtyak4qw...@mail.gmail.com Branch -- REL_18_STABLE Details --- https://git.postgresql.org/pg/commitdiff/3

pgsql: ci: Fix Windows and MinGW task names

ci: Fix Windows and MinGW task names They use Windows Server 2022, not 2019. Author: Nazir Bilal Yavuz Discussion: https://postgr.es/m/flat/can55fz1osam+852bmqdj+kgfg+07knj6dm3pjbgbtyak4qw...@mail.gmail.com Branch -- REL_17_STABLE Details --- https://git.postgresql.org/pg/commitdiff/3

pgsql: ci: Fix Windows and MinGW task names

ci: Fix Windows and MinGW task names They use Windows Server 2022, not 2019. Author: Nazir Bilal Yavuz Discussion: https://postgr.es/m/flat/can55fz1osam+852bmqdj+kgfg+07knj6dm3pjbgbtyak4qw...@mail.gmail.com Branch -- REL_15_STABLE Details --- https://git.postgresql.org/pg/commitdiff/4

pgsql: Use BumpContext contexts in TupleHashTables, and do some code cl

Use BumpContext contexts in TupleHashTables, and do some code cleanup. For all extant uses of TupleHashTables, execGrouping.c itself does nothing with the "tablecxt" except to allocate new hash entries in it, and the callers do nothing with it except to reset the whole context. So this is an ideal

pgsql: Mark ItemPointer arguments as const throughout

Mark ItemPointer arguments as const throughout This is a follow up 991295f. I searched over src/ and made all ItemPointer arguments as const as much as possible. Note: We cut out from the original patch the pieces that would have created incompatibilities in the index or table AM APIs. Those co

pgsql: Simplify coding in ProcessQuery

Simplify coding in ProcessQuery The original is pretty baroque for no apparent reason; arguably, commit 2f9661311b83 should have done this. Noted while reviewing related code for bug #18984. This is cosmetic (though I'm surprised that my compiler generates shorter assembly this way), so no backp

pgsql: Fix some confusing uses of const

Fix some confusing uses of const There are a few places where we have typedef struct FooData { ... } FooData; typedef FooData *Foo; and then function declarations with bar(const Foo x) which isn't incorrect but probably meant bar(const FooData *x) meaning that the thing x poi

pgsql: docs: Link to the correct protocol version inspection function

docs: Link to the correct protocol version inspection function The docs for max_protocol_version suggested PQprotocolVersion() instead of PQfullProtocolVersion() to find out the exact protocol version. Since PQprotocolVersion() only returns the major protocol version, that is bad advice. Author:

pgsql: docs: Link to the correct protocol version inspection function

docs: Link to the correct protocol version inspection function The docs for max_protocol_version suggested PQprotocolVersion() instead of PQfullProtocolVersion() to find out the exact protocol version. Since PQprotocolVersion() only returns the major protocol version, that is bad advice. Author:

pgsql: const-qualify ItemPointer comparison functions

const-qualify ItemPointer comparison functions Add const qualifiers to ItemPointerEquals() and ItemPointerCompare(). This will allow further changes up the stack. It also complements commit aeb767ca0b0, as we now have all of itemptr.h appropriately const-qualified. Author: Chao Li Discussion:

pgsql: formatting.c cleanup: Remove unnecessary zeroize macros

formatting.c cleanup: Remove unnecessary zeroize macros Replace with initializer or memset(). Reviewed-by: Chao Li Discussion: https://www.postgresql.org/message-id/flat/6dd9d208-a3ed-49b5-b03d-8617261da973%40eisentraut.org Branch -- master Details --- https://git.postgresql.org/pg/co

pgsql: formatting.c cleanup: Improve formatting of some struct declarat

formatting.c cleanup: Improve formatting of some struct declarations This makes future editing easier. Reviewed-by: Chao Li Discussion: https://www.postgresql.org/message-id/flat/6dd9d208-a3ed-49b5-b03d-8617261da973%40eisentraut.org Branch -- master Details --- https://git.postgresql.

pgsql: formatting.c cleanup: Remove unnecessary extra line breaks in er

formatting.c cleanup: Remove unnecessary extra line breaks in error message literals Reviewed-by: Chao Li Discussion: https://www.postgresql.org/message-id/flat/6dd9d208-a3ed-49b5-b03d-8617261da973%40eisentraut.org Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/