pgsql: Add test for postgresql.conf.sample line syntax

2025-11-14 Thread Daniel Gustafsson
Add test for postgresql.conf.sample line syntax All GUCs in postgresql.conf.sample should be set to the default value and be commented out. This syntax was however not tested for, making omissions easy to miss. Add a test which check all lines for syntax. Author: Daniel Gustafsson Reviewed-by:

pgsql: Comment out autovacuum_worker_slots in postgresql.conf.sample.

2025-11-14 Thread Nathan Bossart
Comment out autovacuum_worker_slots in postgresql.conf.sample. All settings in this file should be commented out. In addition to fixing that, also fix the indentation for this line. Oversight in commit c758119e5b. Reported-by: Daniel Gustafsson Author: Daniel Gustafsson Discussion: https://po

pgsql: Comment out autovacuum_worker_slots in postgresql.conf.sample.

2025-11-14 Thread Nathan Bossart
Comment out autovacuum_worker_slots in postgresql.conf.sample. All settings in this file should be commented out. In addition to fixing that, also fix the indentation for this line. Oversight in commit c758119e5b. Reported-by: Daniel Gustafsson Author: Daniel Gustafsson Discussion: https://po

pgsql: Add note about CreateStatistics()'s selective use of check_right

2025-11-14 Thread Nathan Bossart
Add note about CreateStatistics()'s selective use of check_rights. Commit 5e4fcbe531 added a check_rights parameter to this function for use by ALTER TABLE commands that re-create statistics objects. However, we intentionally ignore check_rights when verifying relation ownership because this funct

pgsql: Add note about CreateStatistics()'s selective use of check_right

2025-11-14 Thread Nathan Bossart
Add note about CreateStatistics()'s selective use of check_rights. Commit 5e4fcbe531 added a check_rights parameter to this function for use by ALTER TABLE commands that re-create statistics objects. However, we intentionally ignore check_rights when verifying relation ownership because this funct

pgsql: Add note about CreateStatistics()'s selective use of check_right

2025-11-14 Thread Nathan Bossart
Add note about CreateStatistics()'s selective use of check_rights. Commit 5e4fcbe531 added a check_rights parameter to this function for use by ALTER TABLE commands that re-create statistics objects. However, we intentionally ignore check_rights when verifying relation ownership because this funct

pgsql: Add note about CreateStatistics()'s selective use of check_right

2025-11-14 Thread Nathan Bossart
Add note about CreateStatistics()'s selective use of check_rights. Commit 5e4fcbe531 added a check_rights parameter to this function for use by ALTER TABLE commands that re-create statistics objects. However, we intentionally ignore check_rights when verifying relation ownership because this funct

pgsql: Add note about CreateStatistics()'s selective use of check_right

2025-11-14 Thread Nathan Bossart
Add note about CreateStatistics()'s selective use of check_rights. Commit 5e4fcbe531 added a check_rights parameter to this function for use by ALTER TABLE commands that re-create statistics objects. However, we intentionally ignore check_rights when verifying relation ownership because this funct

pgsql: Add note about CreateStatistics()'s selective use of check_right

2025-11-14 Thread Nathan Bossart
Add note about CreateStatistics()'s selective use of check_rights. Commit 5e4fcbe531 added a check_rights parameter to this function for use by ALTER TABLE commands that re-create statistics objects. However, we intentionally ignore check_rights when verifying relation ownership because this funct

Re: pgsql: doc: remove verbiage about "receiving" data from rep. slots

2025-11-14 Thread Bruce Momjian
On Fri, Nov 14, 2025 at 12:14:15PM -0500, Andres Freund wrote: > > Patch applied. I can keep improving it as we get more ideas. > > I'm rather baffled by the process here. You pushed a patch, without any > review, which also wasn't previously posted publicly, that made things > worse. Then, after

Re: pgsql: doc: remove verbiage about "receiving" data from rep. slots

2025-11-14 Thread Andres Freund
On 2025-11-14 10:46:30 -0500, Bruce Momjian wrote: > On Fri, Nov 14, 2025 at 09:55:37AM -0500, Andres Freund wrote: > > On 2025-11-14 09:49:02 -0500, Bruce Momjian wrote: > > > On Fri, Nov 14, 2025 at 09:25:20AM -0500, Andres Freund wrote: > > > > Hi, > > > > > > > > On 2025-11-14 09:12:33 -0500,

Re: pgsql: doc: remove verbiage about "receiving" data from rep. slots

2025-11-14 Thread Bruce Momjian
On Fri, Nov 14, 2025 at 09:55:37AM -0500, Andres Freund wrote: > Hi, > > On 2025-11-14 09:49:02 -0500, Bruce Momjian wrote: > > On Fri, Nov 14, 2025 at 09:25:20AM -0500, Andres Freund wrote: > > > Hi, > > > > > > On 2025-11-14 09:12:33 -0500, Bruce Momjian wrote: > > > > On Fri, Nov 14, 2025 at 0

pgsql: doc: clarify that logical slots track transaction activity

2025-11-14 Thread Bruce Momjian
doc: clarify that logical slots track transaction activity Previously it only mentioned WAL retention. Discussion: https://postgr.es/m/pexmenhqptw5h4ma4qasz3cvjtynivxprqifgghdjtmkxdig2g@djg7bk2p6pts Backpatch-through: master Branch -- master Details --- https://git.postgresql.org/pg/

Re: pgsql: doc: remove verbiage about "receiving" data from rep. slots

2025-11-14 Thread Andres Freund
Hi, On 2025-11-14 09:49:02 -0500, Bruce Momjian wrote: > On Fri, Nov 14, 2025 at 09:25:20AM -0500, Andres Freund wrote: > > Hi, > > > > On 2025-11-14 09:12:33 -0500, Bruce Momjian wrote: > > > On Fri, Nov 14, 2025 at 09:05:07AM -0500, Andres Freund wrote: > > > > Hi, > > > > > > > > On 2025-11-1

Re: pgsql: doc: remove verbiage about "receiving" data from rep. slots

2025-11-14 Thread Bruce Momjian
On Fri, Nov 14, 2025 at 09:25:20AM -0500, Andres Freund wrote: > Hi, > > On 2025-11-14 09:12:33 -0500, Bruce Momjian wrote: > > On Fri, Nov 14, 2025 at 09:05:07AM -0500, Andres Freund wrote: > > > Hi, > > > > > > On 2025-11-14 09:02:12 -0500, Andres Freund wrote: > > > > On 2025-11-14 13:56:06 +0

Re: pgsql: doc: remove verbiage about "receiving" data from rep. slots

2025-11-14 Thread Andres Freund
Hi, On 2025-11-14 09:12:33 -0500, Bruce Momjian wrote: > On Fri, Nov 14, 2025 at 09:05:07AM -0500, Andres Freund wrote: > > Hi, > > > > On 2025-11-14 09:02:12 -0500, Andres Freund wrote: > > > On 2025-11-14 13:56:06 +, Bruce Momjian wrote: > > > > doc: remove verbiage about "receiving" data

Re: pgsql: doc: remove verbiage about "receiving" data from rep. slots

2025-11-14 Thread Bruce Momjian
On Fri, Nov 14, 2025 at 09:05:07AM -0500, Andres Freund wrote: > Hi, > > On 2025-11-14 09:02:12 -0500, Andres Freund wrote: > > On 2025-11-14 13:56:06 +, Bruce Momjian wrote: > > > doc: remove verbiage about "receiving" data from rep. slots > > > > > > The slots are just LSN markers, not som

pgsql: doc: double-quote use of %f, %p, and %r in literal commands.

2025-11-14 Thread Bruce Momjian
doc: double-quote use of %f, %p, and %r in literal commands. Path expansion might expose characters like spaces which would cause command failure, so double-quote the examples. While %f doesn't need quoting since it uses a fixed character set, it is best to be consistent. Discussion: https://po

Re: pgsql: doc: remove verbiage about "receiving" data from rep. slots

2025-11-14 Thread Andres Freund
Hi, On 2025-11-14 09:02:12 -0500, Andres Freund wrote: > On 2025-11-14 13:56:06 +, Bruce Momjian wrote: > > doc: remove verbiage about "receiving" data from rep. slots > > > > The slots are just LSN markers, not something to receive from. > > I think this is wrong. Logical slots also preser

Re: pgsql: doc: remove verbiage about "receiving" data from rep. slots

2025-11-14 Thread Andres Freund
Hi, On 2025-11-14 13:56:06 +, Bruce Momjian wrote: > doc: remove verbiage about "receiving" data from rep. slots > > The slots are just LSN markers, not something to receive from. I think this is wrong. Logical slots also preserve resources other than WAL. Greetings, Andres Freund

pgsql: doc: remove verbiage about "receiving" data from rep. slots

2025-11-14 Thread Bruce Momjian
doc: remove verbiage about "receiving" data from rep. slots The slots are just LSN markers, not something to receive from. Backpatch-through: master Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/a554389fb5f96baba834c28bd4fc802fa1c8065f Modified Files --

pgsql: pgbench: Fix assertion failure with multiple \syncpipeline in pi

2025-11-14 Thread Fujii Masao
pgbench: Fix assertion failure with multiple \syncpipeline in pipeline mode. Previously, when pgbench ran a custom script that triggered retriable errors (e.g., deadlocks) followed by multiple \syncpipeline commands in pipeline mode, the following assertion failure could occur: Assertion fail

pgsql: pgbench: Fix assertion failure with multiple \syncpipeline in pi

2025-11-14 Thread Fujii Masao
pgbench: Fix assertion failure with multiple \syncpipeline in pipeline mode. Previously, when pgbench ran a custom script that triggered retriable errors (e.g., deadlocks) followed by multiple \syncpipeline commands in pipeline mode, the following assertion failure could occur: Assertion fail

pgsql: pgbench: Fix assertion failure with multiple \syncpipeline in pi

2025-11-14 Thread Fujii Masao
pgbench: Fix assertion failure with multiple \syncpipeline in pipeline mode. Previously, when pgbench ran a custom script that triggered retriable errors (e.g., deadlocks) followed by multiple \syncpipeline commands in pipeline mode, the following assertion failure could occur: Assertion fail

pgsql: Doc: add IDs to copy.sgml's and

2025-11-14 Thread Álvaro Herrera
Doc: add IDs to copy.sgml's and In the spirit of commit 78ee60ed84bb. Author: jian he Discussion: https://postgr.es/m/cacjufxfspxcwsvr+_vscz3bysh4-dpe19ivyeta30unhwnw...@mail.gmail.com Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/e4018f891dec09ff95ac97e5b1a2