pgsql: Remove obsolete cast

2025-11-19 Thread Peter Eisentraut
Remove obsolete cast The upstream timezone code uses a bool variable as an array subscript. Back when PostgreSQL's bool was char, this would have caused a warning from gcc -Wchar-subscripts, which is included in -Wall. But this has been obsolete since probably commit d26a810ebf9, but certainly si

pgsql: doc: Update pg_upgrade documentation to match recent description

2025-11-19 Thread Fujii Masao
doc: Update pg_upgrade documentation to match recent description changes. Commit 792353f7d52 updated the pg_dump and pg_dumpall documentation to clarify which statistics are not included in their output. The pg_upgrade documentation contained a nearly identical description, but it was not updated

pgsql: doc: Update pg_upgrade documentation to match recent description

2025-11-19 Thread Fujii Masao
doc: Update pg_upgrade documentation to match recent description changes. Commit 792353f7d52 updated the pg_dump and pg_dumpall documentation to clarify which statistics are not included in their output. The pg_upgrade documentation contained a nearly identical description, but it was not updated

pgsql: Add HINT listing valid encodings to encode() and decode() errors

2025-11-19 Thread Fujii Masao
Add HINT listing valid encodings to encode() and decode() errors. This commit updates encode() and decode() so that when an invalid encoding is specified, their error message includes a HINT listing all valid encodings. This helps users quickly see which encodings are supported without needing to

pgsql: Drop support for MSVCRT's float formatting quirk.

2025-11-19 Thread Thomas Munro
Drop support for MSVCRT's float formatting quirk. Commit f1885386 added code to remove an unnecessary leading zero from the exponent in a float formatted by the system snprintf(). The C standard doesn't allow unnecessary digits beyond two, and the tests pass without this on Windows' modern UCRT (

pgsql: Drop support for MSVCRT's %I64 format strings.

2025-11-19 Thread Thomas Munro
Drop support for MSVCRT's %I64 format strings. MSVCRT predated C99 and invented non-standard placeholders for 64-bit numbers, and then later used them in standard macros when C99 arrived. The macros just use %lld etc when building with UCRT, so there should be no way for our interposed sprintf.c

pgsql: Speed up eqjoinsel() with lots of MCV entries.

2025-11-19 Thread Tom Lane
Speed up eqjoinsel() with lots of MCV entries. If both sides of the operator have most-common-value statistics, eqjoinsel wants to check which MCVs have matches on the other side. Formerly it did this with a dumb compare-all-the-entries loop, which had O(N^2) behavior for long MCV lists. When tha

pgsql: Print new OldestXID value in pg_resetwal when it's being changed

2025-11-19 Thread Heikki Linnakangas
Print new OldestXID value in pg_resetwal when it's being changed Commit 74cf7d46a91d added the --oldest-transaction-id option to pg_resetwal, but forgot to update the code that prints all the new values that are being set. Fix that. Reviewed-by: Bertrand Drouvot Discussion: https://www.postgres

pgsql: Print new OldestXID value in pg_resetwal when it's being changed

2025-11-19 Thread Heikki Linnakangas
Print new OldestXID value in pg_resetwal when it's being changed Commit 74cf7d46a91d added the --oldest-transaction-id option to pg_resetwal, but forgot to update the code that prints all the new values that are being set. Fix that. Reviewed-by: Bertrand Drouvot Discussion: https://www.postgres

pgsql: Print new OldestXID value in pg_resetwal when it's being changed

2025-11-19 Thread Heikki Linnakangas
Print new OldestXID value in pg_resetwal when it's being changed Commit 74cf7d46a91d added the --oldest-transaction-id option to pg_resetwal, but forgot to update the code that prints all the new values that are being set. Fix that. Reviewed-by: Bertrand Drouvot Discussion: https://www.postgres

pgsql: Print new OldestXID value in pg_resetwal when it's being changed

2025-11-19 Thread Heikki Linnakangas
Print new OldestXID value in pg_resetwal when it's being changed Commit 74cf7d46a91d added the --oldest-transaction-id option to pg_resetwal, but forgot to update the code that prints all the new values that are being set. Fix that. Reviewed-by: Bertrand Drouvot Discussion: https://www.postgres

pgsql: Print new OldestXID value in pg_resetwal when it's being changed

2025-11-19 Thread Heikki Linnakangas
Print new OldestXID value in pg_resetwal when it's being changed Commit 74cf7d46a91d added the --oldest-transaction-id option to pg_resetwal, but forgot to update the code that prints all the new values that are being set. Fix that. Reviewed-by: Bertrand Drouvot Discussion: https://www.postgres

pgsql: Print new OldestXID value in pg_resetwal when it's being changed

2025-11-19 Thread Heikki Linnakangas
Print new OldestXID value in pg_resetwal when it's being changed Commit 74cf7d46a91d added the --oldest-transaction-id option to pg_resetwal, but forgot to update the code that prints all the new values that are being set. Fix that. Reviewed-by: Bertrand Drouvot Discussion: https://www.postgres

pgsql: doc: Update formula for vacuum insert threshold.

2025-11-19 Thread Nathan Bossart
doc: Update formula for vacuum insert threshold. Oversight in commit 06eae9e621. Reviewed-by: Melanie Plageman Discussion: https://postgr.es/m/aRODeqFUVkGDJSPP%40nathan Backpatch-through: 18 Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/cbdce71b9984e9bb2d8b3a4a8

pgsql: doc: Update formula for vacuum insert threshold.

2025-11-19 Thread Nathan Bossart
doc: Update formula for vacuum insert threshold. Oversight in commit 06eae9e621. Reviewed-by: Melanie Plageman Discussion: https://postgr.es/m/aRODeqFUVkGDJSPP%40nathan Backpatch-through: 18 Branch -- REL_18_STABLE Details --- https://git.postgresql.org/pg/commitdiff/c99436f433220d9672

pgsql: Fix indentation

2025-11-19 Thread Peter Eisentraut
Fix indentation for commit 0fc33b00536 Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/86b276a4a9b4b2c63ef00765f0e2867e1bcac4ca Modified Files -- src/backend/utils/misc/guc.c | 12 ++-- 1 file changed, 10 insertions(+), 2 deletions(-)