pgsql: Replace pointer comparisons and assignments to literal zero with

2025-12-01 Thread Peter Eisentraut
Replace pointer comparisons and assignments to literal zero with NULL While 0 is technically correct, NULL is the semantically appropriate choice for pointers. Author: Bertrand Drouvot Discussion: https://www.postgresql.org/message-id/aS1AYnZmuRZ8g%2B5G%40ip-10-97-1-34.eu-west-3.compute.interna

pgsql: Update comment related to C99

2025-12-01 Thread Peter Eisentraut
Update comment related to C99 One could do more work here to eliminate the Windows difference described in the comment, but that can be a separate project. The purpose of this change is to update comments that might confusingly indicate that C99 is not required. Reviewed-by: Thomas Munro Discus

pgsql: Update some timestamp[tz] functions to use soft-error reporting

2025-12-01 Thread Michael Paquier
Update some timestamp[tz] functions to use soft-error reporting This commit updates two functions that convert "timestamptz" to "timestamp", and vice-versa, to use the soft error reporting rather than a their own logic to do the same. These are now named as follows: - timestamp2timestamptz_safe()

pgsql: Make regex "max_chr" depend on encoding, not provider.

2025-12-01 Thread Jeff Davis
Make regex "max_chr" depend on encoding, not provider. The regex mechanism scans through the first "max_chr" character values to cache character property ranges (isalpha, etc.). For single-byte encodings, there's no sense in scanning beyond UCHAR_MAX; but for UTF-8 it makes sense to cache higher c

pgsql: Change some callers to use pg_ascii_toupper().

2025-12-01 Thread Jeff Davis
Change some callers to use pg_ascii_toupper(). The input is ASCII anyway, so it's better to be clear that it's not locale-dependent. Discussion: https://postgr.es/m/[email protected] Branch -- master Details --- https://git.postgresql.org/pg/com

pgsql: Fix ON CONFLICT ON CONSTRAINT during REINDEX CONCURRENTLY

2025-12-01 Thread Álvaro Herrera
Fix ON CONFLICT ON CONSTRAINT during REINDEX CONCURRENTLY When REINDEX CONCURRENTLY is processing the index that supports a constraint, there are periods during which multiple indexes match the constraint index's definition. Those must all be included in the set of inferred index for INSERT ON CO

pgsql: Fix a strict aliasing violation

2025-12-01 Thread Peter Eisentraut
Fix a strict aliasing violation This one is almost a textbook example of an aliasing violation, and it is straightforward to fix, so clean it up. (The warning only shows up if you remove the -fno-strict-aliasing option.) Also, move the code after the error checking. Doesn't make a difference te