Re: pgsql: Fix page modification outside of critical section in GIN

On Sun, Feb 9, 2020 at 8:05 PM Tom Lane wrote: > > I wrote: > > Alexander Korotkov writes: > >> Fix page modification outside of critical section in GIN > > > I happened to notice, while reviewing stuff for the release notes, > > that this patch does

pgsql: Avoid full scan of GIN indexes when possible

t5Cc0%3DzMve92vocPzD%2BXiZgiZs1kjY0cj%3DXBg%40mail.gmail.com Author: Nikita Glukhov, Alexander Korotkov, Tom Lane, Julien Rouhaud Reviewed-by: Julien Rouhaud, Tomas Vondra, Tom Lane Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/4b754d6c16e16cc1a1adf12ab0f48603069a

pgsql: Fix page modification outside of critical section in GIN

Fix page modification outside of critical section in GIN By oversight 52ac6cd2d0 makes ginDeletePage() sets pd_prune_xid of page to be deleted before entering the critical section. It appears that only versions 11 and later were affected by this oversight. Backpatch-through: 11 Branch --

pgsql: Fix page modification outside of critical section in GIN

Fix page modification outside of critical section in GIN By oversight 52ac6cd2d0 makes ginDeletePage() sets pd_prune_xid of page to be deleted before entering the critical section. It appears that only versions 11 and later were affected by this oversight. Backpatch-through: 11 Branch --

pgsql: Fix page modification outside of critical section in GIN

Fix page modification outside of critical section in GIN By oversight 52ac6cd2d0 makes ginDeletePage() sets pd_prune_xid of page to be deleted before entering the critical section. It appears that only versions 11 and later were affected by this oversight. Backpatch-through: 11 Branch --

pgsql: Revise GIN README

: Alexander Korotkov Reviewed-by: Peter Geoghegan Backpatch-through: 9.4 Branch -- REL9_5_STABLE Details --- https://git.postgresql.org/pg/commitdiff/8165384babd96258ed521c4ea2567c70a1849948 Modified Files -- src/backend/access/gin/README | 209

pgsql: Revise GIN README

: Alexander Korotkov Reviewed-by: Peter Geoghegan Backpatch-through: 9.4 Branch -- REL9_4_STABLE Details --- https://git.postgresql.org/pg/commitdiff/91ce01a6e07b27e8c293abe4d2d565e0d8ae4021 Modified Files -- src/backend/access/gin/README | 209

pgsql: Fix traversing to the deleted GIN page via downlink

other page flags are not erased once page is deleted. That helps to keep our assertions true if we arrive deleted page via downlink. Discussion: https://postgr.es/m/CAPpHfdvMvsw-NcE5bRS7R1BbvA4BxoDnVVjkXC5W0Czvy9LVrg%40mail.gmail.com Author: Alexander Korotkov Reviewed-by: Peter Geoghegan Backpatch

pgsql: Fix traversing to the deleted GIN page via downlink

other page flags are not erased once page is deleted. That helps to keep our assertions true if we arrive deleted page via downlink. Discussion: https://postgr.es/m/CAPpHfdvMvsw-NcE5bRS7R1BbvA4BxoDnVVjkXC5W0Czvy9LVrg%40mail.gmail.com Author: Alexander Korotkov Reviewed-by: Peter Geoghegan Backpatch

pgsql: Fix traversing to the deleted GIN page via downlink

other page flags are not erased once page is deleted. That helps to keep our assertions true if we arrive deleted page via downlink. Discussion: https://postgr.es/m/CAPpHfdvMvsw-NcE5bRS7R1BbvA4BxoDnVVjkXC5W0Czvy9LVrg%40mail.gmail.com Author: Alexander Korotkov Reviewed-by: Peter Geoghegan Backpatch

pgsql: Fix deadlock between ginDeletePage() and ginStepRight()

/5c332bd1.87b6.16d7c17aa98.Coremail.chjischj%40163.com Author: Alexander Korotkov Reviewed-by: Peter Geoghegan Backpatch-through: 10 Branch -- REL_10_STABLE Details --- https://git.postgresql.org/pg/commitdiff/21ad61ab31786128ae780feca8fcf766bbb6a579 Modified Files -- src/backend/access

pgsql: Revise GIN README

: Alexander Korotkov Reviewed-by: Peter Geoghegan Backpatch-through: 9.4 Branch -- REL_10_STABLE Details --- https://git.postgresql.org/pg/commitdiff/b6f57c2d7bfc2c0ddfc33158b2c42ebd0c715959 Modified Files -- src/backend/access/gin/README | 214

pgsql: Fix traversing to the deleted GIN page via downlink

other page flags are not erased once page is deleted. That helps to keep our assertions true if we arrive deleted page via downlink. Discussion: https://postgr.es/m/CAPpHfdvMvsw-NcE5bRS7R1BbvA4BxoDnVVjkXC5W0Czvy9LVrg%40mail.gmail.com Author: Alexander Korotkov Reviewed-by: Peter Geoghegan Backpatch

pgsql: Revise GIN README

: Alexander Korotkov Reviewed-by: Peter Geoghegan Backpatch-through: 9.4 Branch -- REL_11_STABLE Details --- https://git.postgresql.org/pg/commitdiff/287192bda245cbb7b7577d4c351822772b7e7373 Modified Files -- src/backend/access/gin/README | 214

pgsql: Revise GIN README

: Alexander Korotkov Reviewed-by: Peter Geoghegan Backpatch-through: 9.4 Branch -- REL9_6_STABLE Details --- https://git.postgresql.org/pg/commitdiff/84dcf5235984f45458d13a9e0e486caf97f152ea Modified Files -- src/backend/access/gin/README | 209

pgsql: Fix deadlock between ginDeletePage() and ginStepRight()

/5c332bd1.87b6.16d7c17aa98.Coremail.chjischj%40163.com Author: Alexander Korotkov Reviewed-by: Peter Geoghegan Backpatch-through: 10 Branch -- REL_12_STABLE Details --- https://git.postgresql.org/pg/commitdiff/051c50c01c32ceb498d53e78f48297713744b7cb Modified Files -- src/backend/access

pgsql: Fix traversing to the deleted GIN page via downlink

other page flags are not erased once page is deleted. That helps to keep our assertions true if we arrive deleted page via downlink. Discussion: https://postgr.es/m/CAPpHfdvMvsw-NcE5bRS7R1BbvA4BxoDnVVjkXC5W0Czvy9LVrg%40mail.gmail.com Author: Alexander Korotkov Reviewed-by: Peter Geoghegan Backpatch

pgsql: Revise GIN README

: Alexander Korotkov Reviewed-by: Peter Geoghegan Backpatch-through: 9.4 Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/32ca32d0bed4b95e5cd63998478a7816a89cd43d Modified Files -- src/backend/access/gin/README | 214

pgsql: Fix deadlock between ginDeletePage() and ginStepRight()

/5c332bd1.87b6.16d7c17aa98.Coremail.chjischj%40163.com Author: Alexander Korotkov Reviewed-by: Peter Geoghegan Backpatch-through: 10 Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/e14641197a5690d92cc48446d0d40f1aec07bac7 Modified Files -- src/backend/access/gin

pgsql: Fix deadlock between ginDeletePage() and ginStepRight()

/5c332bd1.87b6.16d7c17aa98.Coremail.chjischj%40163.com Author: Alexander Korotkov Reviewed-by: Peter Geoghegan Backpatch-through: 10 Branch -- REL_11_STABLE Details --- https://git.postgresql.org/pg/commitdiff/9f292798992ee8efe3281ba61db3c53ea7007b1a Modified Files -- src/backend/access

pgsql: Fix traversing to the deleted GIN page via downlink

other page flags are not erased once page is deleted. That helps to keep our assertions true if we arrive deleted page via downlink. Discussion: https://postgr.es/m/CAPpHfdvMvsw-NcE5bRS7R1BbvA4BxoDnVVjkXC5W0Czvy9LVrg%40mail.gmail.com Author: Alexander Korotkov Reviewed-by: Peter Geoghegan Backpatch

pgsql: Revise GIN README

: Alexander Korotkov Reviewed-by: Peter Geoghegan Backpatch-through: 9.4 Branch -- REL_12_STABLE Details --- https://git.postgresql.org/pg/commitdiff/ca05fa5375eb3124660e24346f1bdc3990c118f2 Modified Files -- src/backend/access/gin/README | 214

pgsql: Fix traversing to the deleted GIN page via downlink

other page flags are not erased once page is deleted. That helps to keep our assertions true if we arrive deleted page via downlink. Discussion: https://postgr.es/m/CAPpHfdvMvsw-NcE5bRS7R1BbvA4BxoDnVVjkXC5W0Czvy9LVrg%40mail.gmail.com Author: Alexander Korotkov Reviewed-by: Peter Geoghegan Backpatch

pgsql: Refactor timestamp2timestamptz_opt_error()

handling in jsonpath easier. That should also save us some CPU cycles. Discussion: https://postgr.es/m/CAPpHfdvRPRh_mTGar5WmDeRZ%3DU5dOXHdxspYYD%3D76m3knNGjXA%40mail.gmail.com Author: Alexander Korotkov Reviewed-by: Tom Lane Branch -- master Details --- https://git.postgresql.org/pg

pgsql: Refactor jsonpath's compareDatetime()

. Reported-by: Tom Lane Discussion: https://postgr.es/m/32308.1569455803%40sss.pgh.pa.us Discussion: https://postgr.es/m/a5629d0c-8162-7559-16aa-0c8390d6ba5f%40postgrespro.ru Author: Nikita Glukhov, Alexander Korotkov Branch -- master Details --- https://git.postgresql.org/pg/commitdiff

Re: pgsql: Implement jsonpath .datetime() method

On Mon, Oct 14, 2019 at 5:36 AM Alexander Korotkov wrote: > On Sun, Oct 13, 2019 at 5:24 AM Tom Lane wrote: > > Alexander Korotkov writes: > > > This patch also changes the way timestamp to timestamptz cast works. > > > Previously it did timestamp2tm() then tm2t

Re: pgsql: Implement jsonpath .datetime() method

On Sun, Oct 13, 2019 at 5:24 AM Tom Lane wrote: > Alexander Korotkov writes: > > This patch also changes the way timestamp to timestamptz cast works. > > Previously it did timestamp2tm() then tm2timestamp(). Instead, after > > timestamp2tm() it calculates timezo

Re: pgsql: Implement jsonpath .datetime() method

On Thu, Oct 3, 2019 at 4:48 PM Robert Haas wrote: > On Tue, Oct 1, 2019 at 1:41 PM Alexander Korotkov > wrote: > > So, basically standard requires us to suppress any error happening in > > filter expression. > > Sounds like the standard is dumb, then. :-) > > >

Re: pgsql: Implement jsonpath .datetime() method

On Mon, Sep 30, 2019 at 10:56 PM Robert Haas wrote: > On Sun, Sep 29, 2019 at 10:30 AM Alexander Korotkov > wrote: > > So, jsonpath behaves like 100 is not greater than 2020. This > > looks like plain false. And user can't expect that unless she is > > familiar wi

Re: pgsql: Implement jsonpath .datetime() method

like plain false. And user can't expect that unless she is familiar with our particular issues. Now I got opinion that such errors shouldn't be suppressed. We can't suppress *every* error. If trying to do this, we can come to an idea to suppress OOM error and return garbage then, which i

Re: pgsql: Implement jsonpath .datetime() method

On Thu, Sep 26, 2019 at 2:57 AM Tom Lane wrote: > Alexander Korotkov writes: > > On Thu, Sep 26, 2019 at 2:12 AM Tom Lane wrote: > >> The proximate problem seems to be that compareItems() is insufficiently > >> careful to ensure that both values are non-null b

Re: pgsql: Implement jsonpath .datetime() method

On Thu, Sep 26, 2019 at 2:12 AM Tom Lane wrote: > Alexander Korotkov writes: > > I've noticed buildfarm is unhappy with my commits. > > The proximate problem seems to be that compareItems() is insufficiently > careful to ensure that both values are non-null before passing them

pgsql: Correctly cast types to Datum and back in compareDatetime()

Correctly cast types to Datum and back in compareDatetime() Discussion: https://postgr.es/m/CAPpHfdteFKW6MLpXM4md99m55YAuXs0n9_P2wiTq_EmG09doUA%40mail.gmail.com Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/7881bb14f4b23e8dc8671938cfb3f34117c12d8b Modified

Re: pgsql: Implement jsonpath .datetime() method

On Thu, Sep 26, 2019 at 12:05 AM Alexander Korotkov < a.korot...@postgrespro.ru> wrote: > > On Wed, Sep 25, 2019 at 10:52 PM Alexander Korotkov > wrote: > > Implement jsonpath .datetime() method > > I've noticed buildfarm is unhappy with my commits. > > 1. https:/

Re: pgsql: Implement jsonpath .datetime() method

On Wed, Sep 25, 2019 at 10:52 PM Alexander Korotkov wrote: > Implement jsonpath .datetime() method I've noticed buildfarm is unhappy with my commits. 1. https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=lapwing=2019-09-25%2020%3A40%3A11 2. https://buildfarm.postgresql.org/cgi-

pgsql: Error suppression support for upcoming jsonpath .datetime() meth

internal versions of date and time functions used, which support error suppression. Discussion: https://postgr.es/m/CAPpHfdsZgYEra_PeCLGNoXOWYx6iU-S3wF8aX0ObQUcZU%2B4XTw%40mail.gmail.com Author: Alexander Korotkov, Nikita Glukhov Reviewed-by: Anastasia Lubennikova, Peter Eisentraut Branch

pgsql: Implement standard datetime parsing mode

() jsonpath method. Discussion: https://postgr.es/m/CAPpHfdsZgYEra_PeCLGNoXOWYx6iU-S3wF8aX0ObQUcZU%2B4XTw%40mail.gmail.com Author: Alexander Korotkov Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/1a950f37d0a283f2a76bec63c05530ed6eb16de1 Modified Files

pgsql: Implement jsonpath .datetime() method

/CAPpHfdsZgYEra_PeCLGNoXOWYx6iU-S3wF8aX0ObQUcZU%2B4XTw%40mail.gmail.com Author: Alexander Korotkov, Nikita Glukhov, Teodor Sigaev, Oleg Bartunov, Liudmila Mantrova Reviewed-by: Anastasia Lubennikova, Peter Eisentraut Branch -- master Details --- https://git.postgresql.org/pg/commitdiff

pgsql: Allow datetime values in JsonbValue

-S3wF8aX0ObQUcZU%2B4XTw%40mail.gmail.com Author: Nikita Glukhov, Teodor Sigaev, Oleg Bartunov, Alexander Korotkov, Liudmila Mantrova Reviewed-by: Anastasia Lubennikova, Peter Eisentraut Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/6dda292d4df82a9158d1acc93feecf3b84637b59

pgsql: Implement parse_datetime() function

-S3wF8aX0ObQUcZU%2B4XTw%40mail.gmail.com Author: Nikita Glukhov, Teodor Sigaev, Oleg Bartunov, Alexander Korotkov Reviewed-by: Anastasia Lubennikova, Peter Eisentraut Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/66c74f8b6e347ba5830bf06468bef8081601c187 Modified Files

pgsql: Fix bug in pairingheap_SpGistSearchItem_cmp()

Fix bug in pairingheap_SpGistSearchItem_cmp() Our item contains only so->numberOfNonNullOrderBys of distances. Reflect that in the loop upper bound. Discussion: https://postgr.es/m/53536807-784c-e029-6e92-6da802ab8d60%40postgrespro.ru Author: Nikita Glukhov Backpatch-through: 12 Branch --

pgsql: Fix bug in pairingheap_SpGistSearchItem_cmp()

Fix bug in pairingheap_SpGistSearchItem_cmp() Our item contains only so->numberOfNonNullOrderBys of distances. Reflect that in the loop upper bound. Discussion: https://postgr.es/m/53536807-784c-e029-6e92-6da802ab8d60%40postgrespro.ru Author: Nikita Glukhov Backpatch-through: 12 Branch --

pgsql: Provide stable test for NULL-values in KNN SP-GiST

Provide stable test for NULL-values in KNN SP-GiST f5f084fc3e has removed test because of its instability. This commit provides alternative test with determined ordering using extra ORDER BY expression. Backpatch-through: 12 Branch -- REL_12_STABLE Details ---

pgsql: Provide stable test for NULL-values in KNN SP-GiST

Provide stable test for NULL-values in KNN SP-GiST f5f084fc3e has removed test because of its instability. This commit provides alternative test with determined ordering using extra ORDER BY expression. Backpatch-through: 12 Branch -- master Details ---

pgsql: Remove unstable KNN SP-GiST test

Remove unstable KNN SP-GiST test 6cae9d2c10 introduced test for NULL values in KNN SP-GiST. This test relies on undetermined ordering showing different results on various platforms. This commit removes that test. Will be replaced with better test later. Discussion:

pgsql: Remove unstable KNN SP-GiST test

Remove unstable KNN SP-GiST test 6cae9d2c10 introduced test for NULL values in KNN SP-GiST. This test relies on undetermined ordering showing different results on various platforms. This commit removes that test. Will be replaced with better test later. Discussion:

pgsql: Fix freeing old values in index_store_float8_orderby_distances()

Fix freeing old values in index_store_float8_orderby_distances() 6cae9d2c10 has added an error in freeing old values in index_store_float8_orderby_distances() function. It looks for old value in scan->xs_orderbynulls[i] after setting a new value there. This commit fixes that. Also it removes

pgsql: Fix freeing old values in index_store_float8_orderby_distances()

Fix freeing old values in index_store_float8_orderby_distances() 6cae9d2c10 has added an error in freeing old values in index_store_float8_orderby_distances() function. It looks for old value in scan->xs_orderbynulls[i] after setting a new value there. This commit fixes that. Also it removes

Re: pgsql: Improve handling of NULLs in KNN-GiST and KNN-SP-GiST

On Thu, Sep 19, 2019 at 11:43 PM Alexander Korotkov wrote: > On Thu, Sep 19, 2019 at 11:31 PM Alexander Korotkov > wrote: > > > > On Thu, Sep 19, 2019 at 11:13 PM Tom Lane wrote: > >> > >> Erik Rijkers writes: > >> > Oops: > >> &g

Re: pgsql: Improve handling of NULLs in KNN-GiST and KNN-SP-GiST

On Thu, Sep 19, 2019 at 11:31 PM Alexander Korotkov wrote: > > On Thu, Sep 19, 2019 at 11:13 PM Tom Lane wrote: >> >> Erik Rijkers writes: >> > Oops: >> > create_index ... ok 634 ms >> > create

pgsql: Fix oversight in backpatch of 6cae9d2c10

Fix oversight in backpatch of 6cae9d2c10 During backpatch of 6cae9d2c10 Float8GetDatum() was accidentally removed. This commit turns it back. Reported-by: Erik Rijkers Discussion: https://postgr.es/m/6d51305e1159241cabee132f7efc7eff%40xs4all.nl Author: Tom Lane Backpatch-through: from 11 to 9.5

pgsql: Fix oversight in backpatch of 6cae9d2c10

Fix oversight in backpatch of 6cae9d2c10 During backpatch of 6cae9d2c10 Float8GetDatum() was accidentally removed. This commit turns it back. Reported-by: Erik Rijkers Discussion: https://postgr.es/m/6d51305e1159241cabee132f7efc7eff%40xs4all.nl Author: Tom Lane Backpatch-through: from 11 to 9.5

pgsql: Fix oversight in backpatch of 6cae9d2c10

Fix oversight in backpatch of 6cae9d2c10 During backpatch of 6cae9d2c10 Float8GetDatum() was accidentally removed. This commit turns it back. Reported-by: Erik Rijkers Discussion: https://postgr.es/m/6d51305e1159241cabee132f7efc7eff%40xs4all.nl Author: Tom Lane Backpatch-through: from 11 to 9.5

pgsql: Fix oversight in backpatch of 6cae9d2c10

Fix oversight in backpatch of 6cae9d2c10 During backpatch of 6cae9d2c10 Float8GetDatum() was accidentally removed. This commit turns it back. Reported-by: Erik Rijkers Discussion: https://postgr.es/m/6d51305e1159241cabee132f7efc7eff%40xs4all.nl Author: Tom Lane Backpatch-through: from 11 to 9.5

Re: pgsql: Improve handling of NULLs in KNN-GiST and KNN-SP-GiST

s > > I'm betting the issue is breaking the Datum abstraction here: > > - scan->xs_orderbyvals[i] = > Float8GetDatum(distanceValues[i]); > + scan->xs_orderbyvals[i] = item->distances[i].value; > Overseen by me. Will fix immediatel

pgsql: Improve handling of NULLs in KNN-GiST and KNN-SP-GiST

f57ee-afc7-8977-c44c-6111d18b02ec%40postgrespro.ru Author: Nikita Glukhov Reviewed-by: Alexander Korotkov Backpatch-through: 9.4 Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/6cae9d2c10e151f741e7bc64a8b70bb2615c367c Modified Files -- src/backend/a

pgsql: Improve handling of NULLs in KNN-GiST and KNN-SP-GiST

f57ee-afc7-8977-c44c-6111d18b02ec%40postgrespro.ru Author: Nikita Glukhov Reviewed-by: Alexander Korotkov Backpatch-through: 9.4 Branch -- REL9_6_STABLE Details --- https://git.postgresql.org/pg/commitdiff/53d9cf2db5ded873fbcc031acb584a2c05e4983b Modified Files -- src/backend/access/

pgsql: Improve handling of NULLs in KNN-GiST and KNN-SP-GiST

f57ee-afc7-8977-c44c-6111d18b02ec%40postgrespro.ru Author: Nikita Glukhov Reviewed-by: Alexander Korotkov Backpatch-through: 9.4 Branch -- REL9_4_STABLE Details --- https://git.postgresql.org/pg/commitdiff/332eda5bd3d275fc14b721905b93c2b983a000d3 Modified Files -- src/backend/access/

pgsql: Improve handling of NULLs in KNN-GiST and KNN-SP-GiST

f57ee-afc7-8977-c44c-6111d18b02ec%40postgrespro.ru Author: Nikita Glukhov Reviewed-by: Alexander Korotkov Backpatch-through: 9.4 Branch -- REL_10_STABLE Details --- https://git.postgresql.org/pg/commitdiff/2da8e56db35cf3759c22b97bcb22216837dec3e1 Modified Files -- src/backend/access/

pgsql: Improve handling of NULLs in KNN-GiST and KNN-SP-GiST

f57ee-afc7-8977-c44c-6111d18b02ec%40postgrespro.ru Author: Nikita Glukhov Reviewed-by: Alexander Korotkov Backpatch-through: 9.4 Branch -- REL9_5_STABLE Details --- https://git.postgresql.org/pg/commitdiff/ad458d0cd9d90df4747b48ec60cfde455e878811 Modified Files -- src/backend/access/

pgsql: Improve handling of NULLs in KNN-GiST and KNN-SP-GiST

f57ee-afc7-8977-c44c-6111d18b02ec%40postgrespro.ru Author: Nikita Glukhov Reviewed-by: Alexander Korotkov Backpatch-through: 9.4 Branch -- REL_12_STABLE Details --- https://git.postgresql.org/pg/commitdiff/31cbd760578fc0aeb87db11422c32afaf5de129b Modified Files -- src/backend/a

pgsql: Improve handling of NULLs in KNN-GiST and KNN-SP-GiST

f57ee-afc7-8977-c44c-6111d18b02ec%40postgrespro.ru Author: Nikita Glukhov Reviewed-by: Alexander Korotkov Backpatch-through: 9.4 Branch -- REL_11_STABLE Details --- https://git.postgresql.org/pg/commitdiff/d6a90aac563ecb5b32e2a1d902c9a18d8c21671f Modified Files -- src/backend/access/

pgsql: Support for SSSSS datetime format pattern

for . Alias is added in favor of upcoming jsonpath .datetime() method. But it's also supported in to_date()/ to_timestamp() as positive side effect. Discussion: https://postgr.es/m/CAPpHfdsZgYEra_PeCLGNoXOWYx6iU-S3wF8aX0ObQUcZU%2B4XTw%40mail.gmail.com Author: Nikita Glukhov, Alexander Korotkov

pgsql: Support for FF1-FF6 datetime format patterns

, Teodor Sigaev, Oleg Bartunov, Alexander Korotkov Reviewed-by: Anastasia Lubennikova, Peter Eisentraut Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/d589f94460c24d9b7ac21887d031818d6e3f354d Modified Files -- doc/src/sgml/func.sgml| 24

pgsql: Typo fixes for documentation

Typo fixes for documentation Discussion: https://postgr.es/m/CAEkD-mDUZrRE%3Dk-FznEg4Ed2VdjpZCyHoyo%2Bp0%2B8KvHqR%3DpNVQ%40mail.gmail.com Author: Liudmila Mantrova, Alexander Lakhin Reviewed-by: Alexander Korotkov, Alvaro Herrera Backpatch-through: 12 Branch -- REL_12_STABLE Details

pgsql: Documentation improvements to jsonpath

%40mail.gmail.com Author: Liudmila Mantrova, Alexander Lakhin Reviewed-by: Alexander Korotkov, Alvaro Herrera Backpatch-through: 12 Branch -- REL_12_STABLE Details --- https://git.postgresql.org/pg/commitdiff/9f771868c446c44dae6b97c68eeb1b19da32c50a Modified Files -- doc/src/sgml/func.sgml

pgsql: Typo fixes for documentation

Typo fixes for documentation Discussion: https://postgr.es/m/CAEkD-mDUZrRE%3Dk-FznEg4Ed2VdjpZCyHoyo%2Bp0%2B8KvHqR%3DpNVQ%40mail.gmail.com Author: Liudmila Mantrova, Alexander Lakhin Reviewed-by: Alexander Korotkov, Alvaro Herrera Backpatch-through: 12 Branch -- master Details --- https

pgsql: Documentation improvements to jsonpath

%40mail.gmail.com Author: Liudmila Mantrova, Alexander Lakhin Reviewed-by: Alexander Korotkov, Alvaro Herrera Backpatch-through: 12 Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/c30fc9ddd596f7981555318d1c236fc55279cac8 Modified Files -- doc/src/sgml/func.sgml | 41

pgsql: Remove pg_trgm.strict_word_similarity_threshold doc from 9.6 and

Remove pg_trgm.strict_word_similarity_threshold doc from 9.6 and 10 9ee98cc3f added missing doc for pg_trgm.strict_word_similarity_threshold GUC. But it was accidentally backpatched to 9.6, while this GUC was introduced only in 11. This patch removes extra doc from 9.6 and 10. Discussion:

pgsql: Remove pg_trgm.strict_word_similarity_threshold doc from 9.6 and

Remove pg_trgm.strict_word_similarity_threshold doc from 9.6 and 10 9ee98cc3f added missing doc for pg_trgm.strict_word_similarity_threshold GUC. But it was accidentally backpatched to 9.6, while this GUC was introduced only in 11. This patch removes extra doc from 9.6 and 10. Discussion:

pgsql: Fix handling of non-key columns get_index_column_opclass()

that by making get_index_column_opclass() return InvalidOid in this case. Discussion: https://postgr.es/m/20190902231948.GA5343%40alvherre.pgsql Author: Nikita Glukhov, Alexander Korotkov Backpatch-through: 12 Branch -- REL_12_STABLE Details --- https://git.postgresql.org/pg/commitdiff

pgsql: Fix handling of non-key columns get_index_column_opclass()

that by making get_index_column_opclass() return InvalidOid in this case. Discussion: https://postgr.es/m/20190902231948.GA5343%40alvherre.pgsql Author: Nikita Glukhov, Alexander Korotkov Backpatch-through: 12 Branch -- master Details --- https://git.postgresql.org/pg/commitdiff

pgsql: Fix handling Inf and Nan values in GiST pairing heap comparator

Author: Alexander Korotkov Reviewed-by: Heikki Linnakangas Backpatch-through: 9.4 Branch -- REL9_5_STABLE Details --- https://git.postgresql.org/pg/commitdiff/986319d467cfefaa54b5cb72e063e28b66f04d42 Modified Files -- src/backend/access/gist/gistscan.c | 7 +-- 1 file

pgsql: Fix handling Inf and Nan values in GiST pairing heap comparator

Author: Alexander Korotkov Reviewed-by: Heikki Linnakangas Backpatch-through: 9.4 Branch -- REL9_6_STABLE Details --- https://git.postgresql.org/pg/commitdiff/b2037afec14725e4521427edbee8071d04057a2d Modified Files -- src/backend/access/gist/gistscan.c | 7 +-- 1 file

pgsql: Fix handling of NULL distances in KNN-GiST

fixes that by introducing separate array of null flags for distances. Backpatch to all supported versions. Discussion: https://postgr.es/m/CAPpHfdsNvNdA0DBS%2BwMpFrgwT6C3-q50sFVGLSiuWnV3FqOJuQ%40mail.gmail.com Author: Alexander Korotkov Backpatch-through: 9.4 Branch -- REL9_5_STABLE Details

pgsql: Fix handling of NULL distances in KNN-GiST

fixes that by introducing separate array of null flags for distances. Backpatch to all supported versions. Discussion: https://postgr.es/m/CAPpHfdsNvNdA0DBS%2BwMpFrgwT6C3-q50sFVGLSiuWnV3FqOJuQ%40mail.gmail.com Author: Alexander Korotkov Backpatch-through: 9.4 Branch -- REL9_4_STABLE Details

pgsql: Fix handling of NULL distances in KNN-GiST

fixes that by introducing separate array of null flags for distances. Backpatch to all supported versions. Discussion: https://postgr.es/m/CAPpHfdsNvNdA0DBS%2BwMpFrgwT6C3-q50sFVGLSiuWnV3FqOJuQ%40mail.gmail.com Author: Alexander Korotkov Backpatch-through: 9.4 Branch -- REL_11_STABLE Details

pgsql: Fix handling Inf and Nan values in GiST pairing heap comparator

Author: Alexander Korotkov Reviewed-by: Heikki Linnakangas Backpatch-through: 9.4 Branch -- REL9_4_STABLE Details --- https://git.postgresql.org/pg/commitdiff/111fb7e42e335bbe104939418ec44c903d3b2329 Modified Files -- src/backend/access/gist/gistscan.c | 7 +-- 1 file

pgsql: Fix handling of NULL distances in KNN-GiST

fixes that by introducing separate array of null flags for distances. Backpatch to all supported versions. Discussion: https://postgr.es/m/CAPpHfdsNvNdA0DBS%2BwMpFrgwT6C3-q50sFVGLSiuWnV3FqOJuQ%40mail.gmail.com Author: Alexander Korotkov Backpatch-through: 9.4 Branch -- master Details

pgsql: Fix handling of NULL distances in KNN-GiST

fixes that by introducing separate array of null flags for distances. Backpatch to all supported versions. Discussion: https://postgr.es/m/CAPpHfdsNvNdA0DBS%2BwMpFrgwT6C3-q50sFVGLSiuWnV3FqOJuQ%40mail.gmail.com Author: Alexander Korotkov Backpatch-through: 9.4 Branch -- REL_10_STABLE Details

pgsql: Fix handling Inf and Nan values in GiST pairing heap comparator

Author: Alexander Korotkov Reviewed-by: Heikki Linnakangas Backpatch-through: 9.4 Branch -- REL_11_STABLE Details --- https://git.postgresql.org/pg/commitdiff/749b04d1d8b8ad63d365b8f6ad9d70843f3c1239 Modified Files -- src/backend/access/gist/gistscan.c | 7 +-- 1 file

pgsql: Fix handling Inf and Nan values in GiST pairing heap comparator

Author: Alexander Korotkov Reviewed-by: Heikki Linnakangas Backpatch-through: 9.4 Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/e5d8f3596100da0d38a38513c69e803b7fe7041a Modified Files -- src/backend/access/gist/gistscan.c | 7 +-- src/test

pgsql: Fix handling Inf and Nan values in GiST pairing heap comparator

Author: Alexander Korotkov Reviewed-by: Heikki Linnakangas Backpatch-through: 9.4 Branch -- REL_12_STABLE Details --- https://git.postgresql.org/pg/commitdiff/bc67f4189a7a3381db76dbfeafca463187bfe87a Modified Files -- src/backend/access/gist/gistscan.c | 7 +-- src

pgsql: Fix handling Inf and Nan values in GiST pairing heap comparator

Author: Alexander Korotkov Reviewed-by: Heikki Linnakangas Backpatch-through: 9.4 Branch -- REL_10_STABLE Details --- https://git.postgresql.org/pg/commitdiff/8f724002e2fe0e415f5a603462440d2f297f287c Modified Files -- src/backend/access/gist/gistscan.c | 7 +-- 1 file

pgsql: Fix handling of NULL distances in KNN-GiST

fixes that by introducing separate array of null flags for distances. Backpatch to all supported versions. Discussion: https://postgr.es/m/CAPpHfdsNvNdA0DBS%2BwMpFrgwT6C3-q50sFVGLSiuWnV3FqOJuQ%40mail.gmail.com Author: Alexander Korotkov Backpatch-through: 9.4 Branch -- REL_12_STABLE Details

pgsql: Fix handling of NULL distances in KNN-GiST

fixes that by introducing separate array of null flags for distances. Backpatch to all supported versions. Discussion: https://postgr.es/m/CAPpHfdsNvNdA0DBS%2BwMpFrgwT6C3-q50sFVGLSiuWnV3FqOJuQ%40mail.gmail.com Author: Alexander Korotkov Backpatch-through: 9.4 Branch -- REL9_6_STABLE Details

Re: pgsql: Adjust string comparison in jsonpath

пн, 12 авг. 2019 г., 3:25 Thomas Munro : > On Mon, Aug 12, 2019 at 10:30 AM Alexander Korotkov > wrote: > > > > This appears to have upset prion when testing on en_US.iso885915. > > > > > > Also lapwing's "InstallCheck-fr_FR" stage crashed on this co

pgsql: Fix string comparison in jsonpath

Fix string comparison in jsonpath Take into account pg_server_to_any() may return input string "as is". Reported-by: Andrew Dunstan, Thomas Munro Discussion: https://postgr.es/m/0ed83a33-d900-466a-880a-70ef456c721f%402ndQuadrant.com Author: Alexander Korotkov, Thomas Munro Backpatch-t

Re: pgsql: Adjust string comparison in jsonpath

On Mon, Aug 12, 2019 at 1:25 AM Thomas Munro wrote: > On Mon, Aug 12, 2019 at 9:04 AM Andrew Dunstan > wrote: > > On 8/11/19 4:10 PM, Alexander Korotkov wrote: > > > Adjust string comparison in jsonpath > > > > > > We have implemented jsonpath s

pgsql: Adjust string comparison in jsonpath

operator. In future to implement strict standard conformance, we can do normalization of input JSON strings. Original patch was written by Nikita Glukhov, rewritten by me. Reported-by: Markus Winand Discussion: https://postgr.es/m/8B7FA3B4-328D-43D7-95A8-37B8891B8C78%40winand.at Author: Nikita Glukhov

pgsql: Adjust string comparison in jsonpath

operator. In future to implement strict standard conformance, we can do normalization of input JSON strings. Original patch was written by Nikita Glukhov, rewritten by me. Reported-by: Markus Winand Discussion: https://postgr.es/m/8B7FA3B4-328D-43D7-95A8-37B8891B8C78%40winand.at Author: Nikita Glukhov

pgsql: Fix some typos in jsonpath documentation

Fix some typos in jsonpath documentation Discussion: https://postgr.es/m/8B7FA3B4-328D-43D7-95A8-37B8891B8C78%40winand.at Author: Markus Winand Backpatch-through: 12 Branch -- REL_12_STABLE Details --- https://git.postgresql.org/pg/commitdiff/53d467246589de631ce1846105f990099219e737

pgsql: Fix some typos in jsonpath documentation

Fix some typos in jsonpath documentation Discussion: https://postgr.es/m/8B7FA3B4-328D-43D7-95A8-37B8891B8C78%40winand.at Author: Markus Winand Backpatch-through: 12 Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/1f33f211bc531d257f84fefb9208dd43e8718972 Modified

Re: pgsql: Forgotten catversion bump

On Sun, Jul 14, 2019 at 3:28 PM Alexander Korotkov wrote: > 6254c55f81, c085e1c1cb and 075f0a880f all change system catalog. But > catversion bump is missed in all of them. So, do catversion bump now. > > Also, I need mention patch reviewer Fabien Coelho, who has been missed

pgsql: Forgotten catversion bump

Forgotten catversion bump 6254c55f81, c085e1c1cb and 075f0a880f all change system catalog. But catversion bump is missed in all of them. So, do catversion bump now. Also, I need mention patch reviewer Fabien Coelho, who has been missed in commit messages of 6254c55f81, c085e1c1cb and

pgsql: Add support for <-> (box, point) operator to SP-GiST box_ops

y: Tom Lane, Alexander Korotkov Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/075f0a880fbf790f4a3dcac83e2d5125bcad9646 Modified Files -- doc/src/sgml/spgist.sgml | 1 + src/include/catalog/pg_amop.dat| 4 ++ src/test/r

pgsql: Add missing commutators for distance operators

d9345d%40postgrespro.ru Author: Nikita Glukhov Reviewed-by: Tom Lane, Alexander Korotkov Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/6254c55f815623bb74e2cf27562437dc3b2aa2c8 Modified Files -- src/backend/utils/adt/geo_ops.c| 136 - src/include/c

pgsql: Add support for <-> (box, point) operator to GiST box_ops

d9345d%40postgrespro.ru Author: Nikita Glukhov Reviewed-by: Tom Lane, Alexander Korotkov Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/c085e1c1cb4e29637552f5d250d45ad0cb83e5cf Modified Files -- doc/src/sgml/gist.sgml | 1 + src/backend/acces

pgsql: Fixes for jsonpath filter expression elements table in docs

Fixes for jsonpath filter expression elements table in docs Reported-by: Thom Brown Discussion: https://postgr.es/m/CAA-aLv4Tggy6Z3kaG9n%2B3SHwOVGN2Yj_MJXfdfwjH_jBNZzJNA%40mail.gmail.com Backpatch-through: 12 Branch -- REL_12_STABLE Details ---

pgsql: Fixes for jsonpath filter expression elements table in docs

Fixes for jsonpath filter expression elements table in docs Reported-by: Thom Brown Discussion: https://postgr.es/m/CAA-aLv4Tggy6Z3kaG9n%2B3SHwOVGN2Yj_MJXfdfwjH_jBNZzJNA%40mail.gmail.com Backpatch-through: 12 Branch -- master Details ---

<    1   2   3   4   5   6   7   >