Re: pgsql: Fix createdb tests for C locale

2022-09-17 Thread Christoph Berg
Re: Peter Eisentraut > Fix createdb tests for C locale > > If the createdb tests run under the C locale, the database cluster > will be initialized with encoding SQL_ASCII. With the checks added in > c7db01e325a530ec38ec7ba57cd3ed32e123e33c, this will cause several > ICU-related tests to fail bec

Re: pgsql: Collations with nondeterministic comparison

2019-03-22 Thread Christoph Berg
Re: Tom Lane 2019-03-22 <17125.1553282...@sss.pgh.pa.us> > Peter Eisentraut writes: > > Collations with nondeterministic comparison > > Buildfarm member tern doesn't like this patch. I think the issue is > probably that the 012_collation.pl test script isn't being sufficiently > careful to force

Re: pgsql: Fix copy-paste error in errhint() introduced in 691d79a07933.

2018-11-07 Thread Christoph Berg
Re: Andres Freund 2018-11-05 > Fix copy-paste error in errhint() introduced in 691d79a07933. > > Reported-By: Petr Jelinek > Discussion: > https://postgr.es/m/c95a620b-34f0-7930-aeb5-f7ab804f2...@2ndquadrant.com > Backpatch: 9.4-, like the previous commit -errhint("Change wal_le

Re: pgsql: Provide overflow safe integer math inline functions.

2017-12-13 Thread Christoph Berg
Re: Andres Freund 2017-12-13 > Provide overflow safe integer math inline functions. The new _overflow functions have buggy comments: /* * If a - b overflows, return true, otherwise store the result of a + b into * *result. ^ there Christ