Re: pgsql: Track LLVM 15 changes.

Hello Thomas, This isn't an API change, it's just a missing #include that we got away with before. Per buildfarm animal seawasp. If it is a somehow *missing* include, should it be back-patched? Not sure, just asking. -- Fabien.

Re: pgsql: psql: Add test for query canceling

That looks pretty solid to me, and I can confirm that it passes on wrasse's host. The only nit I can find to pick is that this: + usleep(10_000) until -s "$tempdir/psql.pid" or ($count++ > 180 * 100 and die 'pid file did not appear'); basically assumes that psql.pid will be written ato

Re: pgsql: psql: Add test for query canceling

psql: Add test for query canceling Seems sidewinder didn’t quite like this: Nothing obvious sticks out, could it be timing related? Hmmm. Possibly, as the test is time dependent, hence the "SKIP:" section, which should mean that the test should be ignore when it fails. It seems that thi

Re: pgsql: Add pg_alterckey utility to change the cluster key

Hello Bruce, I put the thread back on hackers. The first two keys are stored in pg_cryptokeys/ in the data directory, while the third one is retrieved using a GUC for validation at server startup for the other two. Do we necessarily have to store the first level keys within the data directo

Re: pgsql: Add pg_alterckey utility to change the cluster key

Hello Bruce Tom>> Possibly these commits need more review than you think. Michaël> Shared feeling here, I think that this is still too early. Michaël> FWIW, I am surprised that this patch series includes exactly zero line of code Michaël> for tests, while the total amount of code committed is

Re: pgsql: Rework the pg_statistic_ext catalog

Hello Tom, I see that Coelho's two bleeding-edge-clang animals are reporting that failure too. Normally I'd just ignore those two; And you'd be right. they break pretty regularly. Maybe you're using an almost-bleeding-edge clang? Oh --- I managed to reproduce that failure locally on RH

Re: pgsql: Fix memory leak in pgbench

Hello Tom, I can add it in the compiler version, something like: "Ubuntu 18.04.2 LTS **EXPERIMENTAL** gcc ..." +1. Done, should be seen on next run. The list of compilers is accumulating on the "Members" page for caiman, handfish, moonjelly and seawasp. Not sure how useful it is to ke

Re: pgsql: Fix memory leak in pgbench

I can set up farm animals with bleeding age clang/gcc (compiled weekly from sources) with -Werror (seawasp & moonjelly are already running with those but without -Werror). If possible, I would not recommend using compiled versions from source, but just the latest stable versions released for

Re: pgsql: Fix memory leak in pgbench

I kinda wish the buildfarm wouldn't require manually updating compiler versions... It does not. My cron script uses the update script to keep them up to date: ./update_personality.pl --config=$PG/moonjelly.conf --compiler-version="$(gcc --version | head -1 | sed 's/gcc (GCC) //')" ./upd

Re: pgsql: Fix memory leak in pgbench

Hello Tom, Thomas Munro writes: . o O ( Is it time to run with -Werror on some BF animals yet? ) I've got -Werror turned on on longfin; I'm surprised that it's not whining about this. Perhaps -Wdeclaration-after-statement doesn't really do anything on clang? Anyway, I'd be in favor of ha

Re: pgsql: Fix memory leak in pgbench

Bonjour Michaël, This change leads a compiler warning on my machine: pgbench.c: In function ‘readCommandResponse’: pgbench.c:2730: warning: ISO C90 forbids mixed declarations and code C99 does not forbid that (see d9dd406). https://www.postgresql.org/docs/devel/source-conventions.html also

Re: pgsql: Fix memory leak in pgbench

Hello Masahiko-san, This change leads a compiler warning on my machine: pgbench.c: In function ‘readCommandResponse’: pgbench.c:2730: warning: ISO C90 forbids mixed declarations and code says: "Code in PostgreSQL should only re

Re: pgsql: Fix memory leak in pgbench

Hello Alvaro, Fix memory leak in pgbench Commit 25ee70511ec2 introduced a memory leak in pgbench: some PGresult structs were not being freed during error bailout, because we're now doing more PQgetResult() calls than previously. Indeed, I did not consider cleaning up on errors when removi

Re: pgsql: Use a separate random seed for SQL random()/setseed() functions.

Hello Tom, I'm sorry I'm a bit late back into this discussion, I was on the road. To fix this reliably, we need random() and setseed() to use their own private random state variable. Ok. Standard random(3) isn't amenable to such usage, so let's switch to pg_erand48(). Hmmm… bad idea? It

Re: pgsql: Set random seed for pgbench.

I assumed that pg_strong_random is always available, ... which is wrong. Every other call of it is wrapped in #ifdef HAVE_STRONG_RANDOM, and so must this one be. Indeed, I clearly misunderstood its usage pattern. I looked at its source ("src/port/pg_strong_random.c") where the function is

Re: pgsql: Set random seed for pgbench.

Hello Tom, Set random seed for pgbench. So this patch has ignored the possibility of not having pg_strong_random. I assumed that pg_strong_random is always available, but may fail with an error if a strong random source is not available, in which case the error message should be enough fo

Re: pgsql: Add \if support to pgbench

Teodor Sigaev writes: Add \if support to pgbench Buildfarm says you didn't account for MSVC build ... Argh. I'm responsible, but I do not know how to help on this one:-( Probably some magic in "Mkvbuild.pm"? But nothing obvious... Looking at "msvc/Install.pm", 'pgbench' is listed in @cl

Re: pgsql: Add general purpose hasing functions to pgbench.

will fix, A blind attempt, if it helps. The 32-bit members of the buildfarm aren't very happy with this, eg on dromedary: cache gcc -Wall -Wmissing-prototypes -Wpointer-arith -Wdeclaration-after-statement -Wendif-labels -Wmissing-format-attribute -Wformat-security -fno-strict-aliasing -fw

Re: pgsql: Add \if support to pgbench

Add \if support to pgbench Thanks! -- Fabien.

Re: pgsql: Add pow(), aka power(), function to pgbench.

# debug(script=0,command=31): double 8.50705917302346e+037 # doesn't match '(?^:command=31.: double 8.50705917302346e\+37\b)' # debug(script=0,command=32): double 1e+030 # doesn't match '(?^:command=32.: double 1e\+30\b)' The difference seems to be a leading zero before the exponent, s