pgsql: Stamp 17beta2.

Stamp 17beta2. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/23c5a0e7d43bc925c6001538f04a458933a11fc1 Modified Files -- configure| 18 +- configure.ac | 2 +- meson.build | 2 +- 3 files changed, 11 insertions(+), 11 deletions(-)

pgsql: Make contrib/tablefunc crosstab() also check typmod

Make contrib/tablefunc crosstab() also check typmod contrib/tablefunc connectby() checks both type OID and typmod for its output columns while crosstab() only checks type OID. Fix that by makeing the crosstab() check look more like the connectby() check. Reported-by: Tom Lane Reviewed-by: Tom Lan

pgsql: Add new function, PQchangePassword(), to libpq

ding to the server's password_encryption setting. Also modify the psql client to use the new function. That provides a builtin test case. Ultimately drivers built on top of libpq should expose this function and its use should be generally encouraged over doing ALTER USER directly for password

Re: pgsql: Add support for incremental backup.

On 12/20/23 09:54, Robert Haas wrote: Add support for incremental backup. \o/ Awesome! -- Joe Conway PostgreSQL Contributors Team RDS Open Source Databases Amazon Web Services: https://aws.amazon.com

Re: pgsql: Revert "Catalog NOT NULL constraints" and fallout

On 4/12/23 13:44, Alvaro Herrera wrote: Revert "Catalog NOT NULL constraints" and fallout This reverts commit e056c557aef4 and minor later fixes thereof. Seems 76c111a7f1 (as well as some other maybe) needs to be reverted as well. -- Joe Conway PostgreSQL Contributors Team RDS O

pgsql: Fix catversion

Fix catversion Commit 2fb6154fc didn't quite get the catversion correct per usual norms. Fix it. Reported by Rishu Bagga. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/ed1d3132d27503cbae0198b2da172b17c0d4f86b Modified Files -- src/include/catalog/catv

Re: pgsql: Use the terminology "WAL file" not "log file" more consistently.

r-friendly strings are spelled. We already discussed this, a mere 12 years ago, https://postgr.es/m/1283373680-sup-9...@alvh.no-ip.org for exactly the same reason. Nice! Let's just do it? +1 -- Joe Conway PostgreSQL Contributors Team RDS Open Source Databases Amazon Web

pgsql: Use has_privs_for_roles for predefined role checks: round 2

Use has_privs_for_roles for predefined role checks: round 2 Similar to commit 6198420ad, replace is_member_of_role with has_privs_for_role for predefined role access checks in recently committed basebackup code. In passing fix a double-word error in a nearby comment. Discussion: https://postgr.e

pgsql: Use has_privs_for_roles for predefined role checks

is_member_of_role with has_privs_for_role for predefined roles. Patch does not remove is_member_of_role from acl.h, but it does add a warning not to use that function for privilege checking. Not backpatched based on hackers list discussion. Author: Joshua Brindle Reviewed-by: Stephen Frost, Nathan Bossart, Joe

pgsql: Stamp 14beta2.

Stamp 14beta2. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/bafad2c5b261a1449bed60ebac9e7918ebcc42b4 Modified Files -- configure| 18 +- configure.ac | 2 +- 2 files changed, 10 insertions(+), 10 deletions(-)

pgsql: Clarify documentation of RESET ROLE

r than the session user identifier. Fix the documentation to reflect this reality. Backpatch to all supported versions. Author: Nathan Bossart Reviewed-By: Laurenz Albe, David G. Johnston, Joe Conway Reported by: Nathan Bossart Discussion: https://postgr.es/m/flat/925134DB-8212-4F60-8AB1-B1

pgsql: Clarify documentation of RESET ROLE

r than the session user identifier. Fix the documentation to reflect this reality. Backpatch to all supported versions. Author: Nathan Bossart Reviewed-By: Laurenz Albe, David G. Johnston, Joe Conway Reported by: Nathan Bossart Discussion: https://postgr.es/m/flat/925134DB-8212-4F60-8AB1-B1

pgsql: Clarify documentation of RESET ROLE

r than the session user identifier. Fix the documentation to reflect this reality. Backpatch to all supported versions. Author: Nathan Bossart Reviewed-By: Laurenz Albe, David G. Johnston, Joe Conway Reported by: Nathan Bossart Discussion: https://postgr.es/m/flat/925134DB-8212-4F60-8AB1-B1

pgsql: Clarify documentation of RESET ROLE

r than the session user identifier. Fix the documentation to reflect this reality. Backpatch to all supported versions. Author: Nathan Bossart Reviewed-By: Laurenz Albe, David G. Johnston, Joe Conway Reported by: Nathan Bossart Discussion: https://postgr.es/m/flat/925134DB-8212-4F60-8AB1-B1

pgsql: Clarify documentation of RESET ROLE

r than the session user identifier. Fix the documentation to reflect this reality. Backpatch to all supported versions. Author: Nathan Bossart Reviewed-By: Laurenz Albe, David G. Johnston, Joe Conway Reported by: Nathan Bossart Discussion: https://postgr.es/m/flat/925134DB-8212-4F60-8AB1-B1

pgsql: Clarify documentation of RESET ROLE

r than the session user identifier. Fix the documentation to reflect this reality. Backpatch to all supported versions. Author: Nathan Bossart Reviewed-By: Laurenz Albe, David G. Johnston, Joe Conway Reported by: Nathan Bossart Discussion: https://postgr.es/m/flat/925134DB-8212-4F60-8AB1-B1

pgsql: Fix has_column_privilege function corner case

a bit on the invasive side. Author: Joe Conway Reviewed-By: Tom Lane Reported by: Ian Barwick Discussion: https://postgr.es/m/flat/9b5f4311-157b-4164-7fe7-077b4fe8ed84%40joeconway.com Branch -- master Details --- https://git.postgresql.org/pg/commitdiff

pgsql: Fix "ignoring return value" complaints from commit 96d1f423f9

Fix "ignoring return value" complaints from commit 96d1f423f9 The cfbot and some BF animals are complaining about the previous read_binary_file commit because of ignoring return value of ‘fread’. So let's make everyone happy by testing the return value even though not strictly needed. Reported by

pgsql: Fix "ignoring return value" complaints from commit 96d1f423f9

Fix "ignoring return value" complaints from commit 96d1f423f9 The cfbot and some BF animals are complaining about the previous read_binary_file commit because of ignoring return value of ‘fread’. So let's make everyone happy by testing the return value even though not strictly needed. Reported by

pgsql: Fix "ignoring return value" complaints from commit 96d1f423f9

Fix "ignoring return value" complaints from commit 96d1f423f9 The cfbot and some BF animals are complaining about the previous read_binary_file commit because of ignoring return value of ‘fread’. So let's make everyone happy by testing the return value even though not strictly needed. Reported by

pgsql: Fix "ignoring return value" complaints from commit 96d1f423f9

Fix "ignoring return value" complaints from commit 96d1f423f9 The cfbot and some BF animals are complaining about the previous read_binary_file commit because of ignoring return value of ‘fread’. So let's make everyone happy by testing the return value even though not strictly needed. Reported by

pgsql: Read until EOF vice stat-reported size in read_binary_file

Read until EOF vice stat-reported size in read_binary_file read_binary_file(), used by SQL functions pg_read_file() and friends, uses stat to determine file length to read, when not passed an explicit length as an argument. This is problematic, for example, if the file being read is a virtual file

pgsql: Read until EOF vice stat-reported size in read_binary_file

Read until EOF vice stat-reported size in read_binary_file read_binary_file(), used by SQL functions pg_read_file() and friends, uses stat to determine file length to read, when not passed an explicit length as an argument. This is problematic, for example, if the file being read is a virtual file

pgsql: Read until EOF vice stat-reported size in read_binary_file

Read until EOF vice stat-reported size in read_binary_file read_binary_file(), used by SQL functions pg_read_file() and friends, uses stat to determine file length to read, when not passed an explicit length as an argument. This is problematic, for example, if the file being read is a virtual file

pgsql: Read until EOF vice stat-reported size in read_binary_file

Read until EOF vice stat-reported size in read_binary_file read_binary_file(), used by SQL functions pg_read_file() and friends, uses stat to determine file length to read, when not passed an explicit length as an argument. This is problematic, for example, if the file being read is a virtual file

pgsql: Add unlikely() to CHECK_FOR_INTERRUPTS()

Add unlikely() to CHECK_FOR_INTERRUPTS() Add the unlikely() branch hint macro to CHECK_FOR_INTERRUPTS(). Backpatch to REL_10_STABLE where we first started using unlikely(). Discussion: https://www.postgresql.org/message-id/flat/8692553c-7fe8-17d9-cbc1-7cddb758f4c6%40joeconway.com Branch --

pgsql: Add unlikely() to CHECK_FOR_INTERRUPTS()

Add unlikely() to CHECK_FOR_INTERRUPTS() Add the unlikely() branch hint macro to CHECK_FOR_INTERRUPTS(). Backpatch to REL_10_STABLE where we first started using unlikely(). Discussion: https://www.postgresql.org/message-id/flat/8692553c-7fe8-17d9-cbc1-7cddb758f4c6%40joeconway.com Branch --

pgsql: Add unlikely() to CHECK_FOR_INTERRUPTS()

Add unlikely() to CHECK_FOR_INTERRUPTS() Add the unlikely() branch hint macro to CHECK_FOR_INTERRUPTS(). Backpatch to REL_10_STABLE where we first started using unlikely(). Discussion: https://www.postgresql.org/message-id/flat/8692553c-7fe8-17d9-cbc1-7cddb758f4c6%40joeconway.com Branch --

pgsql: Add unlikely() to CHECK_FOR_INTERRUPTS()

Add unlikely() to CHECK_FOR_INTERRUPTS() Add the unlikely() branch hint macro to CHECK_FOR_INTERRUPTS(). Backpatch to REL_10_STABLE where we first started using unlikely(). Discussion: https://www.postgresql.org/message-id/flat/8692553c-7fe8-17d9-cbc1-7cddb758f4c6%40joeconway.com Branch --

pgsql: Initialize dblink remoteConn struct in all cases

Initialize dblink remoteConn struct in all cases Two of the members of rconn were left uninitialized. When dblink_open() is called without an outer transaction it handles the initialization for us, but with an outer transaction it does not. Arrange for initialization in all cases. Backpatch to all

pgsql: Initialize dblink remoteConn struct in all cases

Initialize dblink remoteConn struct in all cases Two of the members of rconn were left uninitialized. When dblink_open() is called without an outer transaction it handles the initialization for us, but with an outer transaction it does not. Arrange for initialization in all cases. Backpatch to all

pgsql: Initialize dblink remoteConn struct in all cases

Initialize dblink remoteConn struct in all cases Two of the members of rconn were left uninitialized. When dblink_open() is called without an outer transaction it handles the initialization for us, but with an outer transaction it does not. Arrange for initialization in all cases. Backpatch to all

pgsql: Initialize dblink remoteConn struct in all cases

Initialize dblink remoteConn struct in all cases Two of the members of rconn were left uninitialized. When dblink_open() is called without an outer transaction it handles the initialization for us, but with an outer transaction it does not. Arrange for initialization in all cases. Backpatch to all

pgsql: Initialize dblink remoteConn struct in all cases

Initialize dblink remoteConn struct in all cases Two of the members of rconn were left uninitialized. When dblink_open() is called without an outer transaction it handles the initialization for us, but with an outer transaction it does not. Arrange for initialization in all cases. Backpatch to all

pgsql: Initialize dblink remoteConn struct in all cases

Initialize dblink remoteConn struct in all cases Two of the members of rconn were left uninitialized. When dblink_open() is called without an outer transaction it handles the initialization for us, but with an outer transaction it does not. Arrange for initialization in all cases. Backpatch to all

pgsql: Add CHECK_FOR_INTERRUPTS() to the repeat() function

Add CHECK_FOR_INTERRUPTS() to the repeat() function The repeat() function loops for potentially a long time without ever checking for interrupts. This prevents, for example, a query cancel from interrupting until the work is all done. Fix by inserting a CHECK_FOR_INTERRUPTS() into the loop. Backp

pgsql: Add CHECK_FOR_INTERRUPTS() to the repeat() function

Add CHECK_FOR_INTERRUPTS() to the repeat() function The repeat() function loops for potentially a long time without ever checking for interrupts. This prevents, for example, a query cancel from interrupting until the work is all done. Fix by inserting a CHECK_FOR_INTERRUPTS() into the loop. Backp

pgsql: Add CHECK_FOR_INTERRUPTS() to the repeat() function

Add CHECK_FOR_INTERRUPTS() to the repeat() function The repeat() function loops for potentially a long time without ever checking for interrupts. This prevents, for example, a query cancel from interrupting until the work is all done. Fix by inserting a CHECK_FOR_INTERRUPTS() into the loop. Backp

pgsql: Add CHECK_FOR_INTERRUPTS() to the repeat() function

Add CHECK_FOR_INTERRUPTS() to the repeat() function The repeat() function loops for potentially a long time without ever checking for interrupts. This prevents, for example, a query cancel from interrupting until the work is all done. Fix by inserting a CHECK_FOR_INTERRUPTS() into the loop. Backp

pgsql: Add CHECK_FOR_INTERRUPTS() to the repeat() function

Add CHECK_FOR_INTERRUPTS() to the repeat() function The repeat() function loops for potentially a long time without ever checking for interrupts. This prevents, for example, a query cancel from interrupting until the work is all done. Fix by inserting a CHECK_FOR_INTERRUPTS() into the loop. Backp

pgsql: Add CHECK_FOR_INTERRUPTS() to the repeat() function

Add CHECK_FOR_INTERRUPTS() to the repeat() function The repeat() function loops for potentially a long time without ever checking for interrupts. This prevents, for example, a query cancel from interrupting until the work is all done. Fix by inserting a CHECK_FOR_INTERRUPTS() into the loop. Backp

pgsql: Disallow null category in crosstab_hash

Disallow null category in crosstab_hash While building a hash map of categories in load_categories_hash, resulting category names have not thus far been checked to ensure they are not null. Prior to pg12 null category names worked to the extent that they did not crash on some platforms. This is be

pgsql: Disallow null category in crosstab_hash

Disallow null category in crosstab_hash While building a hash map of categories in load_categories_hash, resulting category names have not thus far been checked to ensure they are not null. Prior to pg12 null category names worked to the extent that they did not crash on some platforms. This is be

pgsql: Disallow null category in crosstab_hash

Disallow null category in crosstab_hash While building a hash map of categories in load_categories_hash, resulting category names have not thus far been checked to ensure they are not null. Prior to pg12 null category names worked to the extent that they did not crash on some platforms. This is be

pgsql: Disallow null category in crosstab_hash

Disallow null category in crosstab_hash While building a hash map of categories in load_categories_hash, resulting category names have not thus far been checked to ensure they are not null. Prior to pg12 null category names worked to the extent that they did not crash on some platforms. This is be

pgsql: Disallow null category in crosstab_hash

Disallow null category in crosstab_hash While building a hash map of categories in load_categories_hash, resulting category names have not thus far been checked to ensure they are not null. Prior to pg12 null category names worked to the extent that they did not crash on some platforms. This is be

pgsql: Disallow null category in crosstab_hash

Disallow null category in crosstab_hash While building a hash map of categories in load_categories_hash, resulting category names have not thus far been checked to ensure they are not null. Prior to pg12 null category names worked to the extent that they did not crash on some platforms. This is be

pgsql: Disallow null category in crosstab_hash

Disallow null category in crosstab_hash While building a hash map of categories in load_categories_hash, resulting category names have not thus far been checked to ensure they are not null. Prior to pg12 null category names worked to the extent that they did not crash on some platforms. This is be

pgsql: Update sepgsql to add mandatory access control for TRUNCATE

: Yuli Khodorkovskiy Reviewed-by: Joe Conway Discussion: https://postgr.es/m/CAFL5wJcomybj1Xdw7qWmPJRpGuFukKgNrDb6uVBaCMgYS9dkaA%40mail.gmail.com Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/4f66c93f61439b4db866b21cc1ecd5bf815564ef Modified Files -- cont

pgsql: Add object TRUNCATE hook

by me. Based on the discussion not back-patched. A separate patch will exercise the hook in the sepgsql extension. Author: Yuli Khodorkovskiy Reviewed-by: Joe Conway Discussion: https://postgr.es/m/CAFL5wJcomybj1Xdw7qWmPJRpGuFukKgNrDb6uVBaCMgYS9dkaA%40mail.gmail.com Branch -- master Details

Re: pgsql: Add viewBox attribute to storage page layout SVG image

On 4/29/19 2:06 AM, Peter Eisentraut wrote: > On 2019-04-27 17:37, Joe Conway wrote: >> Add viewBox attribute to storage page layout SVG image > > The SVG images are not supposed to be edited. This needs a different > solution. If the viewBox attribute is needed to make this w

pgsql: Add viewBox attribute to storage page layout SVG image

Add viewBox attribute to storage page layout SVG image Recently added SVG image for storage page layout lacks a viewBox attribute which seems necessary to ensure propoer rendering. Add it. Author: Jonathan Katz Discussion: https://postgr.es/m/ba31e0e1-4c9b-b309-70e8-8e7ac14fc87e%40postgresql.org

pgsql: Add guidance on making documentation SVG images responsive

Add guidance on making documentation SVG images responsive Recently added guidance on adding SVG images to the documentation sources lacks advice on making the images responsive when rendered in a variety of media types and viewports. Add some. Patch by Jonathan Katz with some editorialization by

pgsql: Correct the URL pointing to PL/R

Correct the URL pointing to PL/R As pointed out by documentation comment, the URL for PL/R needs to be updated to the correct current repository. Back-patch to all supported branches. Branch -- REL9_6_STABLE Details --- https://git.postgresql.org/pg/commitdiff/870ce7e315e7f9568398c60ea2a

pgsql: Correct the URL pointing to PL/R

Correct the URL pointing to PL/R As pointed out by documentation comment, the URL for PL/R needs to be updated to the correct current repository. Back-patch to all supported branches. Branch -- REL9_5_STABLE Details --- https://git.postgresql.org/pg/commitdiff/e729d0b8c7f3be459d56b984c97

pgsql: Correct the URL pointing to PL/R

Correct the URL pointing to PL/R As pointed out by documentation comment, the URL for PL/R needs to be updated to the correct current repository. Back-patch to all supported branches. Branch -- REL9_4_STABLE Details --- https://git.postgresql.org/pg/commitdiff/17947af968b82ffba7aa2bde047

pgsql: Correct the URL pointing to PL/R

Correct the URL pointing to PL/R As pointed out by documentation comment, the URL for PL/R needs to be updated to the correct current repository. Back-patch to all supported branches. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/cf3ff97a15c184bf6a665b891f41349c8a

pgsql: Correct the URL pointing to PL/R

Correct the URL pointing to PL/R As pointed out by documentation comment, the URL for PL/R needs to be updated to the correct current repository. Back-patch to all supported branches. Branch -- REL_10_STABLE Details --- https://git.postgresql.org/pg/commitdiff/fc732e006a130feb5ec2ce771c3

pgsql: Correct the URL pointing to PL/R

Correct the URL pointing to PL/R As pointed out by documentation comment, the URL for PL/R needs to be updated to the correct current repository. Back-patch to all supported branches. Branch -- REL_11_STABLE Details --- https://git.postgresql.org/pg/commitdiff/d51cfb0eaf4808c6041f4e36d61

pgsql: Make get_controlfile not leak file descriptors

there have been no complaints from the field, and an intermittent failure low risk, no backpatch. Hard failure would of course be bad, but in that case these functions are probably the least of your worries. Author: Joe Conway Reviewed-By: Michael Paquier Reported by: Michael Paquier Discussion

pgsql: Fix documentation for dblink_error_message() return value

Fix documentation for dblink_error_message() return value The dblink documentation claims that an empty string is returned if there has been no error, however OK is actually returned in that case. Also, clarify that an async error may not be seen unless dblink_is_busy() or dblink_get_result() have

pgsql: Fix documentation for dblink_error_message() return value

Fix documentation for dblink_error_message() return value The dblink documentation claims that an empty string is returned if there has been no error, however OK is actually returned in that case. Also, clarify that an async error may not be seen unless dblink_is_busy() or dblink_get_result() have

pgsql: Fix documentation for dblink_error_message() return value

Fix documentation for dblink_error_message() return value The dblink documentation claims that an empty string is returned if there has been no error, however OK is actually returned in that case. Also, clarify that an async error may not be seen unless dblink_is_busy() or dblink_get_result() have

pgsql: Fix documentation for dblink_error_message() return value

Fix documentation for dblink_error_message() return value The dblink documentation claims that an empty string is returned if there has been no error, however OK is actually returned in that case. Also, clarify that an async error may not be seen unless dblink_is_busy() or dblink_get_result() have

pgsql: Fix documentation for dblink_error_message() return value

Fix documentation for dblink_error_message() return value The dblink documentation claims that an empty string is returned if there has been no error, however OK is actually returned in that case. Also, clarify that an async error may not be seen unless dblink_is_busy() or dblink_get_result() have

pgsql: Fix documentation for dblink_error_message() return value

Fix documentation for dblink_error_message() return value The dblink documentation claims that an empty string is returned if there has been no error, however OK is actually returned in that case. Also, clarify that an async error may not be seen unless dblink_is_busy() or dblink_get_result() have

pgsql: Mark pg_config() stable rather than immutable

Mark pg_config() stable rather than immutable pg_config() has been marked immutable since its inception. As part of a larger discussion around the definition of immutable versus stable and related implications for marking functions parallel safe raised by Andres, the consensus was clearly that pg_

pgsql: Document aclitem functions and operators

Document aclitem functions and operators aclitem functions and operators have been heretofore undocumented. Fix that. While at it, ensure the non-operator aclitem functions have pg_description strings. Does not seem worthwhile to back-patch. Author: Fabien Coelho, with pg_description from John N

pgsql: Make has_sequence_privilege support WITH GRANT OPTION

Make has_sequence_privilege support WITH GRANT OPTION The various has_*_privilege() functions all support an optional WITH GRANT OPTION added to the supported privilege types to test whether the privilege is held with grant option. That is, all except has_sequence_privilege() variations. Fix that.

pgsql: Make has_sequence_privilege support WITH GRANT OPTION

Make has_sequence_privilege support WITH GRANT OPTION The various has_*_privilege() functions all support an optional WITH GRANT OPTION added to the supported privilege types to test whether the privilege is held with grant option. That is, all except has_sequence_privilege() variations. Fix that.

pgsql: Make has_sequence_privilege support WITH GRANT OPTION

Make has_sequence_privilege support WITH GRANT OPTION The various has_*_privilege() functions all support an optional WITH GRANT OPTION added to the supported privilege types to test whether the privilege is held with grant option. That is, all except has_sequence_privilege() variations. Fix that.

pgsql: Make has_sequence_privilege support WITH GRANT OPTION

Make has_sequence_privilege support WITH GRANT OPTION The various has_*_privilege() functions all support an optional WITH GRANT OPTION added to the supported privilege types to test whether the privilege is held with grant option. That is, all except has_sequence_privilege() variations. Fix that.

pgsql: Make has_sequence_privilege support WITH GRANT OPTION

Make has_sequence_privilege support WITH GRANT OPTION The various has_*_privilege() functions all support an optional WITH GRANT OPTION added to the supported privilege types to test whether the privilege is held with grant option. That is, all except has_sequence_privilege() variations. Fix that.

pgsql: Make has_sequence_privilege support WITH GRANT OPTION

Make has_sequence_privilege support WITH GRANT OPTION The various has_*_privilege() functions all support an optional WITH GRANT OPTION added to the supported privilege types to test whether the privilege is held with grant option. That is, all except has_sequence_privilege() variations. Fix that.