should be backpatched to v15
https://www.postgresql.org/docs/15/app-createdb.html
On Sat, Apr 20, 2024 at 05:00:21PM +, Tomas Vondra wrote:
> createdb: Correct parameter name in SGML docs
>
> Commit 9c08aea6a309 introduced -S/--strategy option, but forgot to
> rename the parameter when copyin
On Sat, Mar 25, 2023 at 11:03:10AM -0700, Andres Freund wrote:
> Hi,
>
> On 2023-03-25 12:51:32 -0500, Justin Pryzby wrote:
> > On Fri, Mar 24, 2023 at 04:30:52AM +, Andres Freund wrote:
> > > meson: add install-{quiet, world} targets
> >
> > if docs.l
On Fri, Mar 24, 2023 at 04:30:52AM +, Andres Freund wrote:
> meson: add install-{quiet, world} targets
if docs.length() == 0
run_target('docs', command: [missing, 'xsltproc'])
else
alias_target('docs', docs)
+ alias_target('install-docs', installdocs)
endif
This fails to handle inst
On Fri, Jan 27, 2023 at 08:27:40AM -0500, Andrew Dunstan wrote:
> On 2023-01-26 Th 22:18, Tom Lane wrote:
> > Michael Paquier writes:
> >> On Thu, Jan 26, 2023 at 09:08:23PM -0500, Tom Lane wrote:
> >>> Is it worth checking for leftover regress_xxx tablespaces as well as
> >>> roles?
> >> Guess so
On Thu, Jan 26, 2023 at 09:46:07AM -0500, Andrew Dunstan wrote:
>
> On 2023-01-26 Th 08:00, Robert Haas wrote:
> > On Thu, Jan 26, 2023 at 6:58 AM Alvaro Herrera
> > wrote:
> >> On 2023-Jan-24, Robert Haas wrote:
> >>
> >>> Adjust interaction of CREATEROLE with role properties.
> >> This commit
On Wed, Jan 18, 2023 at 02:40:06PM -0600, Justin Pryzby wrote:
> On Wed, Jan 18, 2023 at 03:35:41PM -0500, Tom Lane wrote:
> > Andres Freund writes:
> > > On 2023-01-18 15:08:38 -0500, Tom Lane wrote:
> > >> Huh, I wonder why the cfbot never complained about that w
On Wed, Jan 18, 2023 at 03:35:41PM -0500, Tom Lane wrote:
> Andres Freund writes:
> > On 2023-01-18 15:08:38 -0500, Tom Lane wrote:
> >> Huh, I wonder why the cfbot never complained about that when
> >> it was testing this patch ... maybe it doesn't use win1252?
>
> > This is the same environment
On Thu, Dec 22, 2022 at 07:21:50AM +, Peter Eisentraut wrote:
> Remove dead code
>
> The second appearance of NamespaceRelationId in this if-else chain is
> in error and can be removed.
This caused me to notice various wrong-looking elog()s.
diff --git a/src/backend/catalog/aclchk.c b/src/ba
On Thu, Nov 03, 2022 at 03:41:56PM +, Alvaro Herrera wrote:
> Resolve partition strategy during early parsing
>
> This has little practical value, but there's no reason to let the
> partition strategy names travel through DDL as strings.
>
> Reviewed-by: Japin Li
> Discussion: https://postgr
On Wed, Oct 26, 2022 at 11:15:16AM +1300, Thomas Munro wrote:
> On Wed, Oct 26, 2022 at 10:31 AM Justin Pryzby wrote:
> > On Tue, Oct 25, 2022 at 04:21:02PM -0500, Justin Pryzby wrote:
> > > > Restore that behavior with an explicit check, to see if it fixes the
> > &g
On Tue, Oct 25, 2022 at 04:21:02PM -0500, Justin Pryzby wrote:
> > Restore that behavior with an explicit check, to see if it fixes the
> > occasional 'directory not empty' failures seen in the pg_upgrade tests
> > on CI. Further improvements are possible with pro
t; modern Windows APIs that would replace this convoluted code.
>
> Reported-by: Justin Pryzby
> Reviewed-by: Michael Paquier
> Discussion: https://postgr.es/m/20220920013122.GA31833%40telsasoft.com
> Discussion:
> https://postgr.es/m/CA%2BhUKG%2BajSQ_8eu2AogTncOnZ5me2D-Cn66iN_-wZnRjL
This seems to be breaking cfbot:
https://cirrus-ci.com/github/postgresql-cfbot/postgresql
For example:
https://cirrus-ci.com/task/6720256776339456
Some other minor issues:
thais is only used during
=> this
+ elog(ERROR, "unexpected relnumber " UINT64_FORMAT "that
is bigg
On Wed, Sep 07, 2022 at 11:11:37AM +0200, Peter Eisentraut wrote:
> On 06.09.22 08:27, Michael Paquier wrote:
> > On Tue, Sep 06, 2022 at 01:57:53AM -0400, Tom Lane wrote:
> > > Peter Eisentraut writes:
> > > > I think renumbering this makes sense. We could just leave the comment
> > > > as is if
On Fri, Aug 26, 2022 at 02:02:33PM +, Peter Eisentraut wrote:
> Remove unnecessary casts in free() and pfree()
This seems to be breaking cfbot's "warnings" test.
[07:49:48.983] label.c:665:10: error: passing argument 1 of ‘pfree’ discards
‘const’ qualifier from pointer target type [-Werror=d
Thanks for taking care of these
On Thu, Aug 04, 2022 at 09:11:48AM +, John Naylor wrote:
> Fix assorted doc typos
>
> Erik Rijkers and Justin Pryzby
>
> Backpatch to v14
>
> Discussion:
> https://www.postgresql.org/message-id/b79bfeff-d0e3-29a3-2576-0e325848dede
On Sun, Jul 17, 2022 at 07:01:55PM -0700, Andres Freund wrote:
> On 2022-07-17 18:39:35 -0700, Andres Freund wrote:
> > On 2022-07-18 01:05:56 +, Andres Freund wrote:
> > > Default to hidden visibility for extension libraries where possible
> >
> > Looking at the odd failures, not sure what wen
On Sat, Jul 16, 2022 at 06:26:57PM -0400, Tom Lane wrote:
> Andres Freund writes:
> > On 2022-07-16 17:33:47 -0400, Tom Lane wrote:
> >> Anyway, if Peter doesn't answer pretty soon I'll go do that.
>
> > It's about midnight in Germany, so unlikely to come soon...
>
> Done now.
I think this is s
On Sat, Jul 16, 2022 at 01:57:25PM +0200, Peter Eisentraut wrote:
> On 16.07.22 13:37, Justin Pryzby wrote:
> > On Fri, Jul 15, 2022 at 03:35:28PM +, Peter Eisentraut wrote:
> > > Log details for client certificate failures
> >
> > This seems to be causing cfbot
On Sat, Jul 16, 2022 at 06:53:16AM +, Peter Eisentraut wrote:
> Replace many MemSet calls with struct initialization
This failed
https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=lapwing&dt=2022-07-16%2008%3A40%3A14
It avoids the warning here to use {{0}}.
But it doesn't seem worth it t
On Fri, Jul 15, 2022 at 03:35:28PM +, Peter Eisentraut wrote:
> Log details for client certificate failures
This seems to be causing cfbot/linux to fail since yesterday.
--
Justin
On Wed, Mar 16, 2022 at 09:52:41AM -0400, Robert Haas wrote:
> On Wed, Mar 16, 2022 at 5:36 AM Michael Paquier wrote:
> > I have noticed that this commit produces a warning when building with
> > MSVC, as of the end of BaseBackupGetTargetHandle() when the target
> > cannot be found. I guess that
On Thu, Jan 27, 2022 at 02:19:30PM -0500, Robert Haas wrote:
> On Thu, Jan 27, 2022 at 12:45 PM Justin Pryzby wrote:
> > If I'm not wrong, this is causing failures on cfbot.
> > https://cirrus-ci.com/task/6312181619752960?logs=build#L2056
> >
> > [17:24:48.348] c
On Thu, Jan 27, 2022 at 04:15:45PM +, Robert Haas wrote:
> pg_basebackup: Fix a couple of recently-introduced bugs.
>
> The server expects the compression level to be between 1 and 9, but
> Z_DEFAULT_COMPRESSION is -1, so we must not try to send that value
> to the server.
If I'm not wrong, t
I think cipher_failure() should be marked pg_attribute_noreturn().
gcc -Wall -Wmissing-prototypes -Wpointer-arith -Wdeclaration-after-statement
-Werror=vla -Wendif-labels -Wmissing-format-attribute -Wimplicit-fallthrough=3
-Wcast-function-type -Wformat-security -fno-strict-aliasing -fwrapv
-fex
Thanks for applying
On Tue, Nov 05, 2019 at 01:19:41AM +, Michael Paquier wrote:
> Doc: Improve description around ALTER TABLE ATTACH PARTITION
>
> This clarifies more how to use and how to take advantage of constraints
> when attaching a new partition.
>
> Author: Justin
26 matches
Mail list logo
