pgsql: Move new SLRU buffers GUCs to a better place in postgresql.conf.

2024-06-05 Thread Peter Eisentraut
Move new SLRU buffers GUCs to a better place in postgresql.conf.sample They were under "File Locations", which doesn't make sense. Move them to Resource Usage / Memory, which matches their categorization in the source code and in the documentation. Branch -- master Details ---

pgsql: jsonapi: Some message style fixes

2024-05-23 Thread Peter Eisentraut
jsonapi: Some message style fixes Add missing punctuation, and un-gettext-mark an internal error. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/da32f5c4bca7f3447b869de2afbbfa0b74443d45 Modified Files -- src/common/jsonapi.c | 8 1 file

pgsql: doc: Clean up title case use

2024-05-23 Thread Peter Eisentraut
doc: Clean up title case use Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/6ef762938eead1a42024b219311f6ede5dc2104a Modified Files -- doc/src/sgml/file-fdw.sgml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

pgsql: Translation updates

2024-05-20 Thread Peter Eisentraut
Translation updates Source-Git-URL: https://git.postgresql.org/git/pgtranslation/messages.git Source-Git-Hash: 647792ce18e56f51614f7559106ad15362c5d1cc Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/18cbed13d51316184976068f3d8e8da50fc41213 Modified Files

pgsql: A few follow-up fixes for GUC name quoting

2024-05-17 Thread Peter Eisentraut
A few follow-up fixes for GUC name quoting Fixups for 17974ec259: Some messages were missed (and some were new since the patch was originally proposed), and there was a typo introduced. Branch -- master Details ---

pgsql: Revise GUC names quoting in messages again

2024-05-17 Thread Peter Eisentraut
Revise GUC names quoting in messages again After further review, we want to move in the direction of always quoting GUC names in error messages, rather than the previous (PG16) wildly mixed practice or the intermittent (mid-PG17) idea of doing this depending on how possibly confusing the GUC name

pgsql: Remove unused typedefs

2024-05-16 Thread Peter Eisentraut
Remove unused typedefs There were a few typedefs that were never used to define a variable or field. This had the effect that the buildfarm's typedefs.list would not include them, and so they would need to be re-added manually to keep the overall pgindent result perfectly clean. We can easily

pgsql: pg_amcheck: Put new options in consistent order in --help and ma

2024-05-16 Thread Peter Eisentraut
pg_amcheck: Put new options in consistent order in --help and man page Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/94af84f00c5fd3ea840759d85a73204d64e28248 Modified Files -- doc/src/sgml/ref/pg_amcheck.sgml | 22 +++---

pgsql: Revert temporal primary keys and foreign keys

2024-05-16 Thread Peter Eisentraut
Revert temporal primary keys and foreign keys This feature set did not handle empty ranges correctly, and it's now too late for PostgreSQL 17 to fix it. The following commits are reverted: 6db4598fcb8 Add stratnum GiST support function 46a0cd4cefb Add temporal PRIMARY KEY and UNIQUE

pgsql: Re-forbid underscore in positional parameters

2024-05-15 Thread Peter Eisentraut
Re-forbid underscore in positional parameters Underscores were added to numeric literals in faff8f8e47. This change also affected the positional parameters (e.g., $1) rule, which uses the same production for its digits. But this did not actually work, because the digits for parameters are

pgsql: Re-forbid underscore in positional parameters

2024-05-15 Thread Peter Eisentraut
Re-forbid underscore in positional parameters Underscores were added to numeric literals in faff8f8e47. This change also affected the positional parameters (e.g., $1) rule, which uses the same production for its digits. But this did not actually work, because the digits for parameters are

pgsql: doc: Remove claims that initdb and pg_ctl use libpq environment

2024-05-15 Thread Peter Eisentraut
doc: Remove claims that initdb and pg_ctl use libpq environment variables Erroneously introduced by 571df93cff8. Reviewed-by: Daniel Gustafsson Discussion: https://www.postgresql.org/message-id/flat/8458c9c5-18f1-46d7-94c4-1c30e4f44908%40eisentraut.org Branch -- REL_15_STABLE Details

pgsql: doc: Remove claims that initdb and pg_ctl use libpq environment

2024-05-15 Thread Peter Eisentraut
doc: Remove claims that initdb and pg_ctl use libpq environment variables Erroneously introduced by 571df93cff8. Reviewed-by: Daniel Gustafsson Discussion: https://www.postgresql.org/message-id/flat/8458c9c5-18f1-46d7-94c4-1c30e4f44908%40eisentraut.org Branch -- REL_14_STABLE Details

pgsql: doc: Remove claims that initdb and pg_ctl use libpq environment

2024-05-15 Thread Peter Eisentraut
doc: Remove claims that initdb and pg_ctl use libpq environment variables Erroneously introduced by 571df93cff8. Reviewed-by: Daniel Gustafsson Discussion: https://www.postgresql.org/message-id/flat/8458c9c5-18f1-46d7-94c4-1c30e4f44908%40eisentraut.org Branch -- REL_12_STABLE Details

pgsql: doc: Remove claims that initdb and pg_ctl use libpq environment

2024-05-15 Thread Peter Eisentraut
doc: Remove claims that initdb and pg_ctl use libpq environment variables Erroneously introduced by 571df93cff8. Reviewed-by: Daniel Gustafsson Discussion: https://www.postgresql.org/message-id/flat/8458c9c5-18f1-46d7-94c4-1c30e4f44908%40eisentraut.org Branch -- REL_16_STABLE Details

pgsql: doc: Remove claims that initdb and pg_ctl use libpq environment

2024-05-15 Thread Peter Eisentraut
doc: Remove claims that initdb and pg_ctl use libpq environment variables Erroneously introduced by 571df93cff8. Reviewed-by: Daniel Gustafsson Discussion: https://www.postgresql.org/message-id/flat/8458c9c5-18f1-46d7-94c4-1c30e4f44908%40eisentraut.org Branch -- master Details ---

pgsql: doc: Add standard Environment section to pg_amcheck ref page

2024-05-15 Thread Peter Eisentraut
doc: Add standard Environment section to pg_amcheck ref page Reviewed-by: Daniel Gustafsson Discussion: https://www.postgresql.org/message-id/flat/8458c9c5-18f1-46d7-94c4-1c30e4f44908%40eisentraut.org Branch -- master Details ---

pgsql: doc: Add standard Environment section to pg_upgrade ref page

2024-05-15 Thread Peter Eisentraut
doc: Add standard Environment section to pg_upgrade ref page Reviewed-by: Daniel Gustafsson Discussion: https://www.postgresql.org/message-id/flat/8458c9c5-18f1-46d7-94c4-1c30e4f44908%40eisentraut.org Branch -- master Details ---

pgsql: doc: Remove claims that initdb and pg_ctl use libpq environment

2024-05-15 Thread Peter Eisentraut
doc: Remove claims that initdb and pg_ctl use libpq environment variables Erroneously introduced by 571df93cff8. Reviewed-by: Daniel Gustafsson Discussion: https://www.postgresql.org/message-id/flat/8458c9c5-18f1-46d7-94c4-1c30e4f44908%40eisentraut.org Branch -- REL_13_STABLE Details

pgsql: Remove stray blank line among gram.y keywords

2024-05-15 Thread Peter Eisentraut
Remove stray blank line among gram.y keywords introduced by de3600452b Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/54cf0c51184fde6e4c01059be0080b5a60ce6802 Modified Files -- src/backend/parser/gram.y | 1 - 1 file changed, 1 deletion(-)

pgsql: Make all Perl warnings fatal, catch-up

2024-05-15 Thread Peter Eisentraut
Make all Perl warnings fatal, catch-up Apply c5385929593 to new Perl files that had missed the note. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/cc70e170c0213977c106a61c8cedeaac83136c3d Modified Files -- src/bin/pg_walsummary/t/001_basic.pl

pgsql: Add missing gettext triggers

2024-05-14 Thread Peter Eisentraut
Add missing gettext triggers Commit d6607016c7 moved all the jsonapi.c error messages into token_error(). This needs to be added to the various nls.mk files that use this. Since that makes token_error() effectively a globally known symbol, the name seems a bit too general, so rename to

pgsql: Add missing source files to pg_combinebackup/nls.mk

2024-05-14 Thread Peter Eisentraut
Add missing source files to pg_combinebackup/nls.mk Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/9eb54a258f53dd1d7f198e74c1b11b516ad2e98a Modified Files -- src/bin/pg_combinebackup/nls.mk | 12 +--- 1 file changed, 9 insertions(+), 3

pgsql: Add missing gettext triggers

2024-05-14 Thread Peter Eisentraut
Add missing gettext triggers Due to commit dc212340058, which added use of src/common/parse_manifest.c in the backend. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/ab4d7a38c36dba3997e9b585448837ccf6384aed Modified Files -- src/backend/nls.mk | 7

pgsql: Make formatting in nls.mk files more consistent

2024-05-14 Thread Peter Eisentraut
Make formatting in nls.mk files more consistent Some of the nls.mk files used different indentation or line breaks than the majority, which makes editing these files unnecessarily confusing. Branch -- master Details ---

pgsql: Fix ON CONFLICT DO NOTHING/UPDATE for temporal indexes

2024-05-10 Thread Peter Eisentraut
Fix ON CONFLICT DO NOTHING/UPDATE for temporal indexes A PRIMARY KEY or UNIQUE constraint with WITHOUT OVERLAPS will be a GiST index, not a B-Tree, but it will still have indisunique set. The code for ON CONFLICT fails if it sees a non-btree index that has indisunique. This commit fixes that

pgsql: psql: Add missing punctuation in help output

2024-05-09 Thread Peter Eisentraut
psql: Add missing punctuation in help output Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/e2d5508c501a3cfd47df49ce88669bec7df2e426 Modified Files -- src/bin/psql/help.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

pgsql: doc: Use better placeholder in COPY synopsis

2024-05-09 Thread Peter Eisentraut
doc: Use better placeholder in COPY synopsis Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/1c4429e703b2caf7fc865c2fc0a94f3557e5b356 Modified Files -- doc/src/sgml/ref/copy.sgml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

pgsql: Add test for REPLICA IDENTITY with a temporal key

2024-05-08 Thread Peter Eisentraut
Add test for REPLICA IDENTITY with a temporal key You can only use REPLICA IDENTITY USING INDEX with a unique B-tree index. This commit just adds a test showing that you cannot use it with a WITHOUT OVERLAPS index (which is GiST). Author: Paul A. Jungwirth Discussion:

pgsql: doc: Improve order of options on pg_upgrade reference page

2024-05-08 Thread Peter Eisentraut
doc: Improve order of options on pg_upgrade reference page Put the new long-only options in a location that is consistent with the existing long-only options and also the --help output. Branch -- master Details ---

pgsql: Fix incorrect format placeholder

2024-05-08 Thread Peter Eisentraut
Fix incorrect format placeholder Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/6d716adf8569b734eb8849094e9b3edab084c7f8 Modified Files -- src/backend/replication/logical/slotsync.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

pgsql: Fix assorted bugs related to identity column in partitioned tabl

2024-05-07 Thread Peter Eisentraut
Fix assorted bugs related to identity column in partitioned tables When changing the data type of a column of a partitioned table, craft the ALTER SEQUENCE command only once. Partitions do not have identity sequences of their own and thus do not need a ALTER SEQUENCE command for each partition.

pgsql: doc: Improve order of options on pgbench reference page

2024-05-07 Thread Peter Eisentraut
doc: Improve order of options on pgbench reference page Both the pgbench --help output and the reference page have sections for initialization options, benchmarking options, and common options. But the --debug option ended up in the wrong place on the reference page. Fix that by making the

pgsql: Translation updates

2024-05-06 Thread Peter Eisentraut
Translation updates Source-Git-URL: https://git.postgresql.org/git/pgtranslation/messages.git Source-Git-Hash: be182cc55e6f72c66215fd9b38851969e3ce5480 Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/7a31eb2aaa6be61ef4e78efe5eaacb4a43dfc4c5 Modified Files

pgsql: Translation updates

2024-05-06 Thread Peter Eisentraut
Translation updates Source-Git-URL: https://git.postgresql.org/git/pgtranslation/messages.git Source-Git-Hash: ffc021363d88b4368b4046d42d2ed4d1a9b90384 Branch -- REL_13_STABLE Details --- https://git.postgresql.org/pg/commitdiff/38993fe3a2bbc16c812b1a9633063129130860c5 Modified Files

pgsql: Translation updates

2024-05-06 Thread Peter Eisentraut
Translation updates Source-Git-URL: https://git.postgresql.org/git/pgtranslation/messages.git Source-Git-Hash: 1b538923febd744ce5e21dba22102793396e2bcb Branch -- REL_16_STABLE Details --- https://git.postgresql.org/pg/commitdiff/dde58eccae71c578f39255c72c351f3b0976c6a2 Modified Files

pgsql: Translation updates

2024-05-06 Thread Peter Eisentraut
Translation updates Source-Git-URL: https://git.postgresql.org/git/pgtranslation/messages.git Source-Git-Hash: 141c2cc465bc7bd1e2d43243cf81215b0b14abd4 Branch -- REL_15_STABLE Details --- https://git.postgresql.org/pg/commitdiff/3672c6cdfd7cb2cb82837cf4a341bf7c0a60bd59 Modified Files

pgsql: Translation updates

2024-05-06 Thread Peter Eisentraut
Translation updates Source-Git-URL: https://git.postgresql.org/git/pgtranslation/messages.git Source-Git-Hash: 9a37846122eee9aa9c8f8d1cea1bbe7afb28796b Branch -- REL_12_STABLE Details --- https://git.postgresql.org/pg/commitdiff/51da12633a3d7b4b9f715c41deac4d7d4c94248b Modified Files

pgsql: Translation updates

2024-05-06 Thread Peter Eisentraut
Translation updates Source-Git-URL: https://git.postgresql.org/git/pgtranslation/messages.git Source-Git-Hash: c5f76beb79ef3e1424902905d99033b6c1e659b5 Branch -- REL_14_STABLE Details --- https://git.postgresql.org/pg/commitdiff/0288acb0c61f6b0d68d3a625c92bcc54a655442e Modified Files

pgsql: doc: Improve order of options on initdb reference page

2024-05-06 Thread Peter Eisentraut
doc: Improve order of options on initdb reference page Both the initdb --help output and the reference page have a section for options and a section for less commonly used options. But some recently added options were sprinkled around inconsistently. Fix that by making the documentation match

pgsql: Fix expected test output

2024-05-03 Thread Peter Eisentraut
Fix expected test output For builds without lz4, for 8f0a97dfff. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/4a044b9497093f349605fb9912446c5f1bcf228c Modified Files -- src/test/regress/expected/compression_1.out | 10 +++--- 1 file changed, 7

pgsql: Fix segmentation fault in MergeInheritedAttribute()

2024-05-03 Thread Peter Eisentraut
Fix segmentation fault in MergeInheritedAttribute() While converting a pg_attribute tuple into a ColumnDef, ColumnDef::compression remains NULL if there is no compression method set fot the attribute. Calling strcmp() with NULL ColumnDef::compression, when comparing compression methods of

pgsql: Rename libpq trace internal functions

2024-05-02 Thread Peter Eisentraut
Rename libpq trace internal functions libpq's pqTraceOutputMessage() used to look like this: case 'Z': /* Ready For Query */ pqTraceOutputZ(conn->Pfdebug, message, ); break; Commit f4b54e1ed98 introduced macros for protocol characters, so now it looks like

Re: pgsql: Support C.UTF-8 locale in the new builtin collation provider.

2024-05-02 Thread Peter Eisentraut
On 19.03.24 23:29, Jeff Davis wrote: Support C.UTF-8 locale in the new builtin collation provider. This commit changed the functions builtin_locale_encoding() and builtin_validate_locale() in pg_locale.c, but did not update the comments that claim that "C" is the only supported locale name.

pgsql: doc: Fix description of deterministic flag of CREATE COLLATION

2024-05-02 Thread Peter Eisentraut
doc: Fix description of deterministic flag of CREATE COLLATION The documentation said that you need to pick a suitable LC_COLLATE setting in addition to setting the DETERMINISTIC flag. This would have been correct if the libc provider supported nondeterministic collations, but since it doesn't,

pgsql: doc: Fix description of deterministic flag of CREATE COLLATION

2024-05-02 Thread Peter Eisentraut
doc: Fix description of deterministic flag of CREATE COLLATION The documentation said that you need to pick a suitable LC_COLLATE setting in addition to setting the DETERMINISTIC flag. This would have been correct if the libc provider supported nondeterministic collations, but since it doesn't,

pgsql: doc: Fix description of deterministic flag of CREATE COLLATION

2024-05-02 Thread Peter Eisentraut
doc: Fix description of deterministic flag of CREATE COLLATION The documentation said that you need to pick a suitable LC_COLLATE setting in addition to setting the DETERMINISTIC flag. This would have been correct if the libc provider supported nondeterministic collations, but since it doesn't,

pgsql: doc: Fix description of deterministic flag of CREATE COLLATION

2024-05-02 Thread Peter Eisentraut
doc: Fix description of deterministic flag of CREATE COLLATION The documentation said that you need to pick a suitable LC_COLLATE setting in addition to setting the DETERMINISTIC flag. This would have been correct if the libc provider supported nondeterministic collations, but since it doesn't,

pgsql: doc: Fix description of deterministic flag of CREATE COLLATION

2024-05-02 Thread Peter Eisentraut
doc: Fix description of deterministic flag of CREATE COLLATION The documentation said that you need to pick a suitable LC_COLLATE setting in addition to setting the DETERMINISTIC flag. This would have been correct if the libc provider supported nondeterministic collations, but since it doesn't,

pgsql: doc: Fix description of deterministic flag of CREATE COLLATION

2024-05-02 Thread Peter Eisentraut
doc: Fix description of deterministic flag of CREATE COLLATION The documentation said that you need to pick a suitable LC_COLLATE setting in addition to setting the DETERMINISTIC flag. This would have been correct if the libc provider supported nondeterministic collations, but since it doesn't,

pgsql: doc: Fix description of configure --with-icu option

2024-05-02 Thread Peter Eisentraut
doc: Fix description of configure --with-icu option It was claiming that the ICU locale provider is used by default, which is not correct. (From commit fcb21b3acdc; it was once contemplated to make it the default, but it wouldn't have been part of that patch in any case.) Reviewed-by: Kashif

pgsql: doc: Fix description of configure --with-icu option

2024-05-02 Thread Peter Eisentraut
doc: Fix description of configure --with-icu option It was claiming that the ICU locale provider is used by default, which is not correct. (From commit fcb21b3acdc; it was once contemplated to make it the default, but it wouldn't have been part of that patch in any case.) Reviewed-by: Kashif

pgsql: Revert "Add GUC backtrace_on_internal_error"

2024-04-29 Thread Peter Eisentraut
Revert "Add GUC backtrace_on_internal_error" This reverts commit a740b213d4b4d3360ad0cac696e47e5ec0eb8864. Subsequent discussion showed that there was interest in a more general facility to configure when server log events would produce backtraces, and this existing limited way couldn't be

pgsql: doc: Add link to table

2024-04-25 Thread Peter Eisentraut
doc: Add link to table Formal tables should generally have an xref in the text that points to them. Add them here. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/e03ec4641d2493db6fbfc60ff78d0f0b36d2ead1 Modified Files -- doc/src/sgml/func.sgml | 2 +-

pgsql: Remove unnecessary code from be_lo_put()

2024-04-25 Thread Peter Eisentraut
Remove unnecessary code from be_lo_put() A permission check is performed in be_lo_put() just after returning from inv_open(), but the permission is already checked in inv_open(), so we can remove the second check. This check was added in 8d9881911f0, but then the refactoring in ae20b23a9e7

Re: pgsql: Refactor libpq state machine for negotiating encryption

2024-04-24 Thread Peter Eisentraut
On 08.04.24 03:25, Heikki Linnakangas wrote: Refactor libpq state machine for negotiating encryption This fixes the few corner cases noted in commit 705843d294, as shown by the changes in the test. Either this or something nearby appears to have broken the error reporting from psql or libpq

pgsql: doc: Fix up spacing around verbatim DocBook elements

2024-04-24 Thread Peter Eisentraut
doc: Fix up spacing around verbatim DocBook elements Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/b53d58097d7d5712d819d06e0416dec0a7db2479 Modified Files -- doc/src/sgml/func.sgml | 32

pgsql: pg_combinebackup: Add --version to --help output

2024-04-24 Thread Peter Eisentraut
pg_combinebackup: Add --version to --help output (It was already on the man page.) Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/83751691e9c89af15103220b62d78cf5be73dbfd Modified Files -- src/bin/pg_combinebackup/pg_combinebackup.c | 1 + 1 file

pgsql: doc: Correct jsonpath string literal escapes description

2024-04-24 Thread Peter Eisentraut
doc: Correct jsonpath string literal escapes description The paragraph describing the JavaScript string literals allowed in jsonpath expressions unnecessarily mentions JSON by erroneously listing \v as allowed by JSON and mentioning the \xNN and \u{N...} backslash escapes as deviations from JSON

pgsql: doc: Correct jsonpath string literal escapes description

2024-04-24 Thread Peter Eisentraut
doc: Correct jsonpath string literal escapes description The paragraph describing the JavaScript string literals allowed in jsonpath expressions unnecessarily mentions JSON by erroneously listing \v as allowed by JSON and mentioning the \xNN and \u{N...} backslash escapes as deviations from JSON

pgsql: doc: Correct jsonpath string literal escapes description

2024-04-24 Thread Peter Eisentraut
doc: Correct jsonpath string literal escapes description The paragraph describing the JavaScript string literals allowed in jsonpath expressions unnecessarily mentions JSON by erroneously listing \v as allowed by JSON and mentioning the \xNN and \u{N...} backslash escapes as deviations from JSON

pgsql: doc: Correct jsonpath string literal escapes description

2024-04-24 Thread Peter Eisentraut
doc: Correct jsonpath string literal escapes description The paragraph describing the JavaScript string literals allowed in jsonpath expressions unnecessarily mentions JSON by erroneously listing \v as allowed by JSON and mentioning the \xNN and \u{N...} backslash escapes as deviations from JSON

pgsql: doc: Correct jsonpath string literal escapes description

2024-04-24 Thread Peter Eisentraut
doc: Correct jsonpath string literal escapes description The paragraph describing the JavaScript string literals allowed in jsonpath expressions unnecessarily mentions JSON by erroneously listing \v as allowed by JSON and mentioning the \xNN and \u{N...} backslash escapes as deviations from JSON

pgsql: doc: Correct jsonpath string literal escapes description

2024-04-24 Thread Peter Eisentraut
doc: Correct jsonpath string literal escapes description The paragraph describing the JavaScript string literals allowed in jsonpath expressions unnecessarily mentions JSON by erroneously listing \v as allowed by JSON and mentioning the \xNN and \u{N...} backslash escapes as deviations from JSON

pgsql: pg_combinebackup: Put newer options in consistent order in --hel

2024-04-24 Thread Peter Eisentraut
pg_combinebackup: Put newer options in consistent order in --help and man page Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/3886530caa01cac7179fed6b6e1d303710c027d9 Modified Files -- doc/src/sgml/ref/pg_combinebackup.sgml | 90

pgsql: pg_dump: Put new options in consistent order in --help and man p

2024-04-24 Thread Peter Eisentraut
pg_dump: Put new options in consistent order in --help and man page Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/256b4b060614f4e54e49bb43a54404af4f1ef61d Modified Files -- doc/src/sgml/ref/pg_dump.sgml | 42 +-

pgsql: doc: Fix order of options on pg_createsubscriber man page

2024-04-24 Thread Peter Eisentraut
doc: Fix order of options on pg_createsubscriber man page Some options were listed in an order that was inconsistent with the --help output and everything else. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/286eea5d3ae33a8c22d46a051f8ac6069c8b779d Modified Files

pgsql: pg_walsummary: Document --version option

2024-04-24 Thread Peter Eisentraut
pg_walsummary: Document --version option It was working, but it was not shown in the --help output or on the man page. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/f994ed89a98b9aed405c760f157a10125eb8d567 Modified Files --

pgsql: Remove obsolete symbol from ecpg_config.h.in

2024-04-24 Thread Peter Eisentraut
Remove obsolete symbol from ecpg_config.h.in HAVE_LONG_LONG_INT was not added to ecpg_config.h.in by the meson build system, but rather than add it there, we decided to remove it from the makefile build system, to make both consistent that way. There is no documentation or examples that suggest

Re: pgsql: Introduce "builtin" collation provider.

2024-04-23 Thread Peter Eisentraut
On 14.03.24 07:39, Jeff Davis wrote: Introduce "builtin" collation provider. Jeff, I think I found a small bug in this commit. The new code in dbcommands.c createdb() reads like this: + /* validate provider-specific parameters */ + if (dblocprovider != COLLPROVIDER_BUILTIN) + { +

pgsql: Update Unicode data to CLDR 45

2024-04-22 Thread Peter Eisentraut
Update Unicode data to CLDR 45 No actual changes result. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/9e2e4f08bb6cc86710cb84459b7fd0f407e596a7 Modified Files -- src/Makefile.global.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

pgsql: Update src/common/unicode/.gitignore

2024-04-22 Thread Peter Eisentraut
Update src/common/unicode/.gitignore for new downloaded files and new build results. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/7e44ac3741dd2ebf8c668d6ac6a10fa6ed7301b3 Modified Files -- src/common/unicode/.gitignore | 4 1 file changed, 4

pgsql: Update src/tools/pginclude/README to match recent changes to cpl

2024-04-18 Thread Peter Eisentraut
Update src/tools/pginclude/README to match recent changes to cpluspluscheck Commit 7b8e2ae2f has turned cpluspluscheck from separate script into a --cplusplus option for headerscheck. Update README correspondingly. Author: Anton Voloshin Discussion:

pgsql: meson: Add some missing LLVM function checks

2024-04-17 Thread Peter Eisentraut
meson: Add some missing LLVM function checks The checks for HAVE_DECL_LLVMCREATEGDBREGISTRATIONLISTENER and HAVE_DECL_LLVMCREATEPERFJITEVENTLISTENER are in configure but are missing on the meson side. This adds those. Reported-by: Heikki Linnakangas Discussion:

pgsql: Remove dead code

2024-04-17 Thread Peter Eisentraut
Remove dead code The configure check for HAVE_DECL_LLVMORCREGISTERPERF was removed by e9a9843e138, but some code guarded by it was left. (That commit removed the "register" calls but left the "unregister" calls.) That code cannot be reached anymore, so remove it. Reported-by: Heikki

pgsql: Add missing source file to libpq/nls.mk

2024-04-17 Thread Peter Eisentraut
Add missing source file to libpq/nls.mk Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/2e75492b3c33beaf226981b796d81b6127544fea Modified Files -- src/interfaces/libpq/nls.mk | 1 + 1 file changed, 1 insertion(+)

pgsql: Mark some new location fields as ParseLoc

2024-04-16 Thread Peter Eisentraut
Mark some new location fields as ParseLoc Some new code probably didn't see 605721f819f and continued to use type int for parse location fields. Fix those. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/2ea5d8bece85518b4b8c052ff134c294c21543e0 Modified Files

pgsql: psql: Make output of \dD more stable

2024-04-15 Thread Peter Eisentraut
psql: Make output of \dD more stable \dD showed domain check constraints in arbitrary order, which can cause regression test failures, which was exposed by commit 9895b35cb8. To fix, order the constraints by conname, which matches what psql does in other queries listing constraints. Branch

pgsql: Fix ALTER DOMAIN NOT NULL syntax

2024-04-15 Thread Peter Eisentraut
Fix ALTER DOMAIN NOT NULL syntax This addresses a few problems with commit e5da0fe3c22 ("Catalog domain not-null constraints"). In CREATE DOMAIN, a NOT NULL constraint looks like CREATE DOMAIN d1 AS int [ CONSTRAINT conname ] NOT NULL (Before e5da0fe3c22, the constraint name was accepted

pgsql: meson: Remove obsolete function test

2024-04-11 Thread Peter Eisentraut
meson: Remove obsolete function test The test for pstat was removed from configure by 9db300ce6e3 but not from meson.build. Do that now. Branch -- REL_16_STABLE Details --- https://git.postgresql.org/pg/commitdiff/3ceb2f96d2d1e2a2e9b884c86c705419e80f39ec Modified Files --

pgsql: meson: Remove obsolete function test

2024-04-11 Thread Peter Eisentraut
meson: Remove obsolete function test The test for pstat was removed from configure by 9db300ce6e3 but not from meson.build. Do that now. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/87840b9741864dfdb9f63b0056e2783cdb49b8a5 Modified Files --

Re: pgsql: Add tests for libpq gssencmode and sslmode options

2024-04-10 Thread Peter Eisentraut
On 08.04.24 01:50, Heikki Linnakangas wrote: Add tests for libpq gssencmode and sslmode options Why aren't these tests at src/interfaces/libpq/t/nnn_negotiate_encryption.pl ? Test all combinations of gssencmode, sslmode, whether the server supports SSL and/or GSSAPI encryption, and whether

Re: pgsql: Introduce a bump memory allocator

2024-04-10 Thread Peter Eisentraut
On 10.04.24 01:11, David Rowley wrote: On Wed, 10 Apr 2024 at 00:05, Peter Eisentraut wrote: This patch introduces in bump.c the macro BumpBlockIsValid(), but it's not used anywhere. Can we remove it? I've just pushed a patch to remove it. Was that spotted by eagle eyes or tooling? I

pgsql: Fix incorrect format placeholders

2024-04-09 Thread Peter Eisentraut
Fix incorrect format placeholders Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/27074bce08e994daf6b8fe9a84877ac257210fdd Modified Files -- src/backend/commands/explain.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)

pgsql: Update config.guess and config.sub

2024-04-09 Thread Peter Eisentraut
Update config.guess and config.sub Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/cfd6ea3ac04113b756e3e722af5d9247ff2da35f Modified Files -- config/config.guess | 62 +++--- config/config.sub | 232

Re: pgsql: Introduce a bump memory allocator

2024-04-09 Thread Peter Eisentraut
On 07.04.24 14:03, David Rowley wrote: Introduce a bump memory allocator This patch introduces in bump.c the macro BumpBlockIsValid(), but it's not used anywhere. Can we remove it? (If we don't remove it, I suggest to make it an inline function, so it's easier to tell what it's supposed

pgsql: Fix whitespace

2024-04-09 Thread Peter Eisentraut
Fix whitespace Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/43a9cab4844b9c933f1a24e24a38311ee24deefd Modified Files -- doc/src/sgml/ddl.sgml| 2 +- src/test/modules/test_json_parser/t/003_test_semantic.pl | 6 --

pgsql: pg_upgrade: Fix typo in message

2024-04-04 Thread Peter Eisentraut
pg_upgrade: Fix typo in message Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/a9d6c3868451a494641b498a15f9ee1c151949a7 Modified Files -- src/bin/pg_upgrade/check.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

pgsql: Silence meson warning

2024-04-04 Thread Peter Eisentraut
Silence meson warning Commit 619bc23a1a introduced WARNING: Project targets '>=0.54' but uses feature introduced in '0.55.0': Passing executable/found program object to script parameter of add_dist_script Work around that by wrapping the offending line in a meson version check. Author:

pgsql: Remove ObjectClass type

2024-03-26 Thread Peter Eisentraut
Remove ObjectClass type ObjectClass is an enum whose values correspond to catalog OIDs. But the extra layer of redirection, which is used only in small parts of the code, and the similarity to ObjectType, are confusing and cumbersome. One advantage has been that some switches processing the

Re: pgsql: pg_createsubscriber: creates a new logical replica from a standb

2024-03-26 Thread Peter Eisentraut
I have committed your patch to tidy this up. Thanks. On 26.03.24 06:01, Kyotaro Horiguchi wrote: Hello. This commit added the following error message: pg_createsubscriber.c: 375 pg_fatal("could not access directory \"%s\": %s", datadir,

pgsql: Message fixes for pg_createsubscriber

2024-03-26 Thread Peter Eisentraut
Message fixes for pg_createsubscriber Author: Kyotaro Horiguchi Discussion: https://www.postgresql.org/message-id/20240326.140116.1116279856046587865.horikyota@gmail.com Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/8c4f2d5475b9f0411baf38590c054ba1fb566780

Re: pgsql: make dist uses git archive

2024-03-26 Thread Peter Eisentraut
On 25.03.24 23:20, Andrew Dunstan wrote: The problem occurs because except in vpath mode the buildfarm operates on a copy of the code, and for efficiency reasons we don't copy the ,git directory. The simplest fix is probably to change the machine's config to use a vpath build. In the

Re: pgsql: make dist uses git archive

2024-03-25 Thread Peter Eisentraut
On 25.03.24 10:04, Magnus Hagander wrote: This seems to have broken buildfarm member guaibasaurus, which I believe is the only one that runs "make dist" as part of the buildfarm. And as a result,t hat breaks the snapshot build uploads. I don't know exactly how it does it, it appears to not

pgsql: pg_createsubscriber: creates a new logical replica from a standb

2024-03-25 Thread Peter Eisentraut
Khanna Reviewed-by: Ashutosh Bapat Reviewed-by: Peter Eisentraut Discussion: https://www.postgresql.org/message-id/flat/5ac50071-f2ed-4ace-a8fd-b892cffd3...@www.fastmail.com Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/d44032d0146306971cd5ccf232fe37269717d6f2

pgsql: make dist uses git archive

2024-03-24 Thread Peter Eisentraut
make dist uses git archive This changes "make dist" to directly use "git archive", rather than the custom shell script it currently runs. This is to make the creation of the distribution tarball more directly traceable to the git repository. That is why we removed the "make distprep" step.

pgsql: ci: freebsd repartition script didn't copy .git directory

2024-03-24 Thread Peter Eisentraut
ci: freebsd repartition script didn't copy .git directory We need a slightly different "cp" incantation to make sure top-level "dot" files, such as ".git", are also copied. This is relevant for example if a script wants to execute a git command. This currently does not happen, but it has come

pgsql: Add temporal FOREIGN KEY contraints

2024-03-24 Thread Peter Eisentraut
, but it works on PostgreSQL's native ranges instead of SQL's "periods", which don't exist in PostgreSQL (yet). Reference actions ON {UPDATE,DELETE} {CASCADE,SET NULL,SET DEFAULT} are not supported yet. Author: Paul A. Jungwirth Reviewed-by: Peter Eisentraut Reviewed-by: jian he Discussi

pgsql: Do not output actual value of location fields in node serializat

2024-03-22 Thread Peter Eisentraut
Do not output actual value of location fields in node serialization by default This changes nodeToString() to not output the actual value of location fields in nodes, but instead it writes -1. This mirrors the fact that stringToNode() also does not read location field values but always stores

pgsql: Make RangeTblEntry dump order consistent

2024-03-22 Thread Peter Eisentraut
Make RangeTblEntry dump order consistent Put the fields alias and eref earlier in the struct, so that it matches the order in _outRangeTblEntry()/_readRangeTblEntry(). This helps if we ever want to fully automate out/read of RangeTblEntry. Also, it makes dumps in the debugger easier to read in

  1   2   3   4   5   6   7   8   9   10   >