Re: pgsql: Add function to pump IPC process until string match

2022-04-01 Thread Andres Freund
On 2022-03-31 00:00:52 +0200, Daniel Gustafsson wrote: > I'll add diag output on failures along the lines of the diff from earlier > today > but with the regex as well (which Alvarao also requested), but tomorrow > morning > once coffee has been consumed. Thanks for doing that!

Re: pgsql: Add function to pump IPC process until string match

2022-03-30 Thread Daniel Gustafsson
> On 30 Mar 2022, at 18:09, Andres Freund wrote: >> Would adding back something like the (right now untested) below be what >> you're >> after? Looking at the perldoc I didn't see any other debugging aids we can >> emit other than the stream and type of error. > > I found showing the regex fro

Re: pgsql: Add function to pump IPC process until string match

2022-03-30 Thread Andres Freund
Hi, On 2022-03-30 09:10:17 +0200, Daniel Gustafsson wrote: > > On 30 Mar 2022, at 00:58, Andres Freund wrote: > > On 2022-02-23 13:32:03 +, Daniel Gustafsson wrote: > > >> Add function to pump IPC process until string match > >> > >> Refactor the recovery tests to not carry a local duplicat

Re: pgsql: Add function to pump IPC process until string match

2022-03-30 Thread Alvaro Herrera
On 2022-Mar-30, Daniel Gustafsson wrote: > Would adding back something like the (right now untested) below be what you're > after? Looking at the perldoc I didn't see any other debugging aids we can > emit other than the stream and type of error. I think you could also show the $until that wasn'

Re: pgsql: Add function to pump IPC process until string match

2022-03-30 Thread Daniel Gustafsson
> On 30 Mar 2022, at 00:58, Andres Freund wrote: > On 2022-02-23 13:32:03 +, Daniel Gustafsson wrote: >> Add function to pump IPC process until string match >> >> Refactor the recovery tests to not carry a local duplicated copy of >> the pump_until function which pumps a process until a defi

Re: pgsql: Add function to pump IPC process until string match

2022-03-29 Thread Andres Freund
Hi, On 2022-02-23 13:32:03 +, Daniel Gustafsson wrote: > Add function to pump IPC process until string match > > Refactor the recovery tests to not carry a local duplicated copy of > the pump_until function which pumps a process until a defined string > is seen on a stream. This reduces dupli