Re: pgsql: Allow parallel CREATE INDEX for GIN indexes

2025-04-02 Thread Tomas Vondra
On 4/1/25 15:30, Peter Eisentraut wrote: > On 07.03.25 22:22, Peter Eisentraut wrote: >> The new tuplesort_getgintuple() in tuplesortvariants.c has a branch >> that does "return false" even though the function's return type is >> GinTuple *.  That is probably a mistake.  Check please. >> >> Also, t

Re: pgsql: Allow parallel CREATE INDEX for GIN indexes

2025-04-01 Thread Peter Eisentraut
On 07.03.25 22:22, Peter Eisentraut wrote: The new tuplesort_getgintuple() in tuplesortvariants.c has a branch that does "return false" even though the function's return type is GinTuple *.  That is probably a mistake.  Check please. Also, this code contains a "pgrminclude ignore", but we don'

Re: pgsql: Allow parallel CREATE INDEX for GIN indexes

2025-03-07 Thread Peter Eisentraut
The new tuplesort_getgintuple() in tuplesortvariants.c has a branch that does "return false" even though the function's return type is GinTuple *. That is probably a mistake. Check please. Also, this code contains a "pgrminclude ignore", but we don't use those anymore. On 03.03.25 17:10,