Re: pgsql: Fix up misuse of "volatile" in contrib/xml2.

2025-07-10 Thread Tom Lane
Jacob Champion writes: > On Wed, Jul 9, 2025 at 8:55 PM Michael Paquier wrote: >> On Wed, Jul 09, 2025 at 11:49:55AM -0400, Tom Lane wrote: >>> Not sure. Yesterday I saw such warnings from arowana, >>> boa, dhole, rhinoceros, and shelduck, eg >> They are all using some gcc 4.X flavor, most with

Re: pgsql: Fix up misuse of "volatile" in contrib/xml2.

2025-07-10 Thread Jacob Champion
On Wed, Jul 9, 2025 at 8:55 PM Michael Paquier wrote: > > On Wed, Jul 09, 2025 at 11:49:55AM -0400, Tom Lane wrote: > > Not sure. Yesterday I saw such warnings from arowana, > > boa, dhole, rhinoceros, and shelduck, eg > > > > arowana | 2025-07-08 04:54:18 | xpath.c:274:6: warning: 'worksp

Re: pgsql: Fix up misuse of "volatile" in contrib/xml2.

2025-07-09 Thread Michael Paquier
On Wed, Jul 09, 2025 at 11:49:55AM -0400, Tom Lane wrote: > Not sure. Yesterday I saw such warnings from arowana, > boa, dhole, rhinoceros, and shelduck, eg > > arowana | 2025-07-08 04:54:18 | xpath.c:274:6: warning: 'workspace' > may be used uninitialized in this function [-Wmaybe-uninit

Re: pgsql: Fix up misuse of "volatile" in contrib/xml2.

2025-07-09 Thread Tom Lane
Michael Paquier writes: > On Tue, Jul 08, 2025 at 09:00:39PM +, Tom Lane wrote: >> Also fix a number of places where variables that are assigned to >> within a PG_TRY and then used after it were not initialized or >> not marked as volatile. (A few buildfarm members were issuing >> "may be use

Re: pgsql: Fix up misuse of "volatile" in contrib/xml2.

2025-07-08 Thread Michael Paquier
On Tue, Jul 08, 2025 at 09:00:39PM +, Tom Lane wrote: > Fix up misuse of "volatile" in contrib/xml2. > > Also fix a number of places where variables that are assigned to > within a PG_TRY and then used after it were not initialized or > not marked as volatile. (A few buildfarm members were is