Amit Kapila writes:
> Fair enough. Do you mind being consistent in this regard for logical
> replication-related code?
As long as not too many individual changes are involved, sure.
But consistency of this sort doesn't seem worth creating a lot
of back-patching land mines, IMO.
> BTW, is there a
On Thu, Sep 8, 2022 at 7:28 PM Tom Lane wrote:
>
> Amit Kapila writes:
> > I feel it is better to be consistent across the entire code base
> > unless there is a reason for doing it differently. Does anyone else
> > have any thoughts on this matter?
>
> That sounds like it would be a pretty massi
Amit Kapila writes:
> I feel it is better to be consistent across the entire code base
> unless there is a reason for doing it differently. Does anyone else
> have any thoughts on this matter?
That sounds like it would be a pretty massive and unnecessary patch.
regards, t
On Thu, Sep 8, 2022 at 2:38 PM Masahiko Sawada wrote:
>
> On Thu, Sep 8, 2022 at 4:23 PM Amit Kapila wrote:
> >
> > On Thu, Sep 8, 2022 at 12:22 PM Masahiko Sawada
> > wrote:
> > >
> > >
> > > Should the tables and the function in this query be schema-qualified?
> > > Looking at other code in s
On Thu, Sep 8, 2022 at 4:23 PM Amit Kapila wrote:
>
> On Thu, Sep 8, 2022 at 12:22 PM Masahiko Sawada wrote:
> >
> > On Thu, Sep 8, 2022 at 10:39 AM Amit Kapila wrote:
> > >
> > > Raise a warning if there is a possibility of data from multiple origins.
> > >
> > > This commit raises a warning me
On Thu, 8 Sept 2022 at 12:22, Masahiko Sawada wrote:
>
> On Thu, Sep 8, 2022 at 10:39 AM Amit Kapila wrote:
> >
> > Raise a warning if there is a possibility of data from multiple origins.
> >
> > This commit raises a warning message for a combination of options
> > ('copy_data = true' and 'origi
On Thu, Sep 8, 2022 at 12:22 PM Masahiko Sawada wrote:
>
> On Thu, Sep 8, 2022 at 10:39 AM Amit Kapila wrote:
> >
> > Raise a warning if there is a possibility of data from multiple origins.
> >
> > This commit raises a warning message for a combination of options
> > ('copy_data = true' and 'ori
On Thu, Sep 8, 2022 at 10:39 AM Amit Kapila wrote:
>
> Raise a warning if there is a possibility of data from multiple origins.
>
> This commit raises a warning message for a combination of options
> ('copy_data = true' and 'origin = none') during CREATE/ALTER subscription
> operations if the publ
