Re: pgsql: Rename files and headers related to index AM

2019-12-28 Thread Tom Lane
Andres Freund writes: > On 2019-12-27 08:20:17 +0900, Michael Paquier wrote: >> Hm, I am not sure that it is actually that much used, such stuff is >> very specialized. > That's true for some of this, but e.g. genam.h is pretty widely > included. I mean, you had to adapt like 100+ files and while

Re: pgsql: Rename files and headers related to index AM

2019-12-28 Thread Andres Freund
Hi, On 2019-12-27 08:20:17 +0900, Michael Paquier wrote: > On Thu, Dec 26, 2019 at 10:26:51AM -0800, Peter Geoghegan wrote: > > On Thu, Dec 26, 2019 at 10:15 AM Andres Freund wrote: > >> Yea, this seems like a much bigger move than warranted. Especially > >> without a backward compat header put i

Re: pgsql: Rename files and headers related to index AM

2019-12-26 Thread Michael Paquier
On Thu, Dec 26, 2019 at 10:26:51AM -0800, Peter Geoghegan wrote: > On Thu, Dec 26, 2019 at 10:15 AM Andres Freund wrote: >> Yea, this seems like a much bigger move than warranted. Especially >> without a backward compat header put into place. Hm, I am not sure that it is actually that much used,

Re: pgsql: Rename files and headers related to index AM

2019-12-26 Thread Peter Geoghegan
On Thu, Dec 26, 2019 at 10:15 AM Andres Freund wrote: > Yea, this seems like a much bigger move than warranted. Especially > without a backward compat header put into place. > > Imo this ought to be reverted. I agree. -- Peter Geoghegan

Re: pgsql: Rename files and headers related to index AM

2019-12-26 Thread Andres Freund
Hi, On 2019-12-26 11:46:06 -0300, Alvaro Herrera wrote: > On 2019-Dec-25, Michael Paquier wrote: > > > Rename files and headers related to index AM > > > > The following renaming is done so as source files related to index > > access methods are more consistent with table access methods (the > >

Re: pgsql: Rename files and headers related to index AM

2019-12-26 Thread Alvaro Herrera
On 2019-Dec-25, Michael Paquier wrote: > Rename files and headers related to index AM > > The following renaming is done so as source files related to index > access methods are more consistent with table access methods (the > original names used for index AMs ware too generic, and could be > con