Re: pgsql: pg_regress: Don't use absolute paths for the diff

2019-02-23 Thread Peter Eisentraut
OK, reverted. -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

Re: pgsql: pg_regress: Don't use absolute paths for the diff

2019-02-22 Thread Stephen Frost
Greetings, * Michael Paquier (mich...@paquier.xyz) wrote: > On Fri, Feb 22, 2019 at 03:26:35PM -0800, Andres Freund wrote: > > that's useless, because I can't trivially copy the result file into the > > expected file anymore. I have to figure out where in the tree it > > is. Which isn't exactly pr

Re: pgsql: pg_regress: Don't use absolute paths for the diff

2019-02-22 Thread Michael Paquier
On Fri, Feb 22, 2019 at 03:26:35PM -0800, Andres Freund wrote: > that's useless, because I can't trivially copy the result file into the > expected file anymore. I have to figure out where in the tree it > is. Which isn't exactly predictable, between the different tests we > have as they locate the

Re: pgsql: pg_regress: Don't use absolute paths for the diff

2019-02-22 Thread Andres Freund
On 2019-02-22 15:18:51 -0800, Peter Geoghegan wrote: > On Thu, Feb 21, 2019 at 10:01 AM Peter Eisentraut > wrote: > > pg_regress: Don't use absolute paths for the diff > > > > Don't expand inputfile and outputfile to absolute paths globally, just > > where needed. In particular, pass them as is

Re: pgsql: pg_regress: Don't use absolute paths for the diff

2019-02-22 Thread Peter Geoghegan
On Thu, Feb 21, 2019 at 10:01 AM Peter Eisentraut wrote: > pg_regress: Don't use absolute paths for the diff > > Don't expand inputfile and outputfile to absolute paths globally, just > where needed. In particular, pass them as is to the file name > arguments of the diff command, so that we don't