Re: pgsql: pgstat: run pgindent on pgstat.c/h.

2022-03-19 Thread Peter Geoghegan
On Sat, Mar 19, 2022 at 12:42 PM Andres Freund wrote: > Pushed an update including the two revs already discussed here, as well as > ed43677e20369040ca4e50c698010c39d5ac0f47 # 2021-01-19 08:10:13 +0530 > # pgindent worker.c. Thanks. > I think a lot of pgindent runs are just to reindent changes d

Re: pgsql: pgstat: run pgindent on pgstat.c/h.

2022-03-19 Thread Tom Lane
Andres Freund writes: > On 2022-03-19 12:36:29 -0700, Peter Geoghegan wrote: >> Ideally there would be some kind of reminder built into the >> pgindent tooling to make it less likely. > I think a lot of pgindent runs are just to reindent changes during > development, so that'd probably just join

Re: pgsql: pgstat: run pgindent on pgstat.c/h.

2022-03-19 Thread Andres Freund
Hi, Pushed an update including the two revs already discussed here, as well as ed43677e20369040ca4e50c698010c39d5ac0f47 # 2021-01-19 08:10:13 +0530 # pgindent worker.c. On 2022-03-19 12:36:29 -0700, Peter Geoghegan wrote: > Ideally there would be some kind of reminder built into the > pgindent t

Re: pgsql: pgstat: run pgindent on pgstat.c/h.

2022-03-19 Thread Peter Geoghegan
On Sat, Mar 19, 2022 at 12:27 PM Andres Freund wrote: > I was actually wondering what our policy around that is for smaller runs like > this. Do we do that in bulk occasionally? Just after? That's not completely clear, but I think that it makes sense to do it right afterwards. We haven't been mai

Re: pgsql: pgstat: run pgindent on pgstat.c/h.

2022-03-19 Thread Andres Freund
On 2022-03-19 12:08:42 -0700, Peter Geoghegan wrote: > On Sat, Mar 19, 2022 at 11:45 AM Andres Freund wrote: > > pgstat: run pgindent on pgstat.c/h. > > Reminder: please add this commit to the .git-blame-ignore-revs file. I was actually wondering what our policy around that is for smaller runs li

Re: pgsql: pgstat: run pgindent on pgstat.c/h.

2022-03-19 Thread Peter Geoghegan
On Sat, Mar 19, 2022 at 11:45 AM Andres Freund wrote: > pgstat: run pgindent on pgstat.c/h. Reminder: please add this commit to the .git-blame-ignore-revs file. -- Peter Geoghegan