Re: pgsql: Add option to use ICU as global locale provider

2022-03-18 Thread Peter Eisentraut
On 18.03.22 18:29, Tom Lane wrote: I found a different problem with src/test/icu/: it fails altogether if the prevailing locale is "C", because then the database encoding defaults to SQL_ASCII which our ICU code won't cope with. I'm not sure if that explains any of the buildfarm failures, but it

Re: pgsql: Add option to use ICU as global locale provider

2022-03-18 Thread Tom Lane
I found a different problem with src/test/icu/: it fails altogether if the prevailing locale is "C", because then the database encoding defaults to SQL_ASCII which our ICU code won't cope with. I'm not sure if that explains any of the buildfarm failures, but it broke my local build (yeah, I'm that

Re: pgsql: Add option to use ICU as global locale provider

2022-03-18 Thread Tom Lane
Julien Rouhaud writes: > That being said, we could save the result and explicitly close the collator. > That wouldn't make much difference in initdb (but may be a bit cleaner), but I > see that there's a similar coding in createdb(), which seems like it could > leak > some memory according to uco

Re: pgsql: Add option to use ICU as global locale provider

2022-03-18 Thread Julien Rouhaud
On Fri, Mar 18, 2022 at 02:36:48PM +0800, Julien Rouhaud wrote: > On Fri, Mar 18, 2022 at 06:15:47PM +1300, Thomas Munro wrote: > > > > No idea what's happening here but one observation is that that animal > > is running an older distro that shipped with ICU 5.0. Commit b8f9a2a6 > > may hold a clu

Re: pgsql: Add option to use ICU as global locale provider

2022-03-17 Thread Julien Rouhaud
On Fri, Mar 18, 2022 at 06:15:47PM +1300, Thomas Munro wrote: > > No idea what's happening here but one observation is that that animal > is running an older distro that shipped with ICU 5.0. Commit b8f9a2a6 > may hold a clue... Right. I'm setting up a similar podman environment, hopefully more

Re: pgsql: Add option to use ICU as global locale provider

2022-03-17 Thread Thomas Munro
On Fri, Mar 18, 2022 at 4:12 PM Julien Rouhaud wrote: > On Fri, Mar 18, 2022 at 11:01:11AM +0900, Michael Paquier wrote: > > FYI, prion is complaining here: > > https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=prion&dt=2022-03-18%2001%3A43%3A13 > > > > Some details: > > # Failed test 'fai

Re: pgsql: Add option to use ICU as global locale provider

2022-03-17 Thread Julien Rouhaud
Hi, On Fri, Mar 18, 2022 at 11:01:11AM +0900, Michael Paquier wrote: > > FYI, prion is complaining here: > https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=prion&dt=2022-03-18%2001%3A43%3A13 > > Some details: > # Failed test 'fails for invalid ICU locale: matches' > # at t/001_initdb.p

Re: pgsql: Add option to use ICU as global locale provider

2022-03-17 Thread Michael Paquier
Hi Peter, On Thu, Mar 17, 2022 at 10:22:32AM +, Peter Eisentraut wrote: > Add option to use ICU as global locale provider > > This adds the option to use ICU as the default locale provider for > either the whole cluster or a database. New options for initdb, > createdb, and CREATE DATABASE a

pgsql: Add option to use ICU as global locale provider

2022-03-17 Thread Peter Eisentraut
Add option to use ICU as global locale provider This adds the option to use ICU as the default locale provider for either the whole cluster or a database. New options for initdb, createdb, and CREATE DATABASE are used to select this. Since some (legacy) code still uses the libc locale facilities