Re: pgsql: Add pgindent commit to git-blame-ignore-revs file.

2021-06-28 Thread Peter Geoghegan
On Mon, Jun 28, 2021 at 12:53 PM Tom Lane wrote: > > How about the approach taken in the attached patch? > > WFM. Pushed. Thanks. -- Peter Geoghegan

Re: pgsql: Add pgindent commit to git-blame-ignore-revs file.

2021-06-28 Thread Tom Lane
Peter Geoghegan writes: > On Mon, Jun 28, 2021 at 9:47 AM Tom Lane wrote: >> The instructions for "Starting a New Development Cycle" perhaps need >> a specific "see src/tools/pgindent/README". I'd be inclined to >> remove the separate mention of .git-blame-ignore-revs from "Pre-Beta >> Tasks", t

Re: pgsql: Add pgindent commit to git-blame-ignore-revs file.

2021-06-28 Thread Peter Geoghegan
On Mon, Jun 28, 2021 at 9:47 AM Tom Lane wrote: > The instructions for "Starting a New Development Cycle" perhaps need > a specific "see src/tools/pgindent/README". I'd be inclined to > remove the separate mention of .git-blame-ignore-revs from "Pre-Beta > Tasks", too. If you didn't read pginden

Re: pgsql: Add pgindent commit to git-blame-ignore-revs file.

2021-06-28 Thread Peter Geoghegan
On Mon, Jun 28, 2021 at 9:43 AM Alvaro Herrera wrote: > ... and now that I look at running that command, I notice that the date > format it generates for me is different from what it did for you: This is because our global git configs differ. > Is it worth documenting whatever is causing the out

Re: pgsql: Add pgindent commit to git-blame-ignore-revs file.

2021-06-28 Thread Tom Lane
Peter Geoghegan writes: > On Mon, Jun 28, 2021 at 9:31 AM Andrew Dunstan wrote: >> Hmm, did I miss something or do we need to update some instructions >> somewhere? > I did update the instructions in commit 8e638845, but perhaps I > omitted to update something. What do you think? The instructio

Re: pgsql: Add pgindent commit to git-blame-ignore-revs file.

2021-06-28 Thread Alvaro Herrera
On 2021-Jun-28, Peter Geoghegan wrote: > On Mon, Jun 28, 2021 at 9:31 AM Andrew Dunstan wrote: > > Hmm, did I miss something or do we need to update some instructions > > somewhere? > > (Responded on the other committers thread just now too.) > > I did update the instructions in commit 8e638845

Re: pgsql: Add pgindent commit to git-blame-ignore-revs file.

2021-06-28 Thread Peter Geoghegan
On Mon, Jun 28, 2021 at 9:31 AM Andrew Dunstan wrote: > Hmm, did I miss something or do we need to update some instructions > somewhere? (Responded on the other committers thread just now too.) I did update the instructions in commit 8e638845, but perhaps I omitted to update something. What do y

Re: pgsql: Add pgindent commit to git-blame-ignore-revs file.

2021-06-28 Thread Andrew Dunstan
On 6/28/21 12:26 PM, Peter Geoghegan wrote: > Add pgindent commit to git-blame-ignore-revs file. > > Add entry for recent commit e1c1c30f. > Hmm, did I miss something or do we need to update some instructions somewhere? cheers andrew -- Andrew Dunstan EDB: https://www.enterprisedb.com

pgsql: Add pgindent commit to git-blame-ignore-revs file.

2021-06-28 Thread Peter Geoghegan
Add pgindent commit to git-blame-ignore-revs file. Add entry for recent commit e1c1c30f. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/ba135fa537ab5c2fca0d589c826ebb3ecf98b2f1 Modified Files -- .git-blame-ignore-revs | 5 - 1 file changed, 4 insert