Re: pgsql: Add standard collation UNICODE

2023-03-13 Thread Jeff Davis
On Sat, 2023-03-11 at 15:47 -0500, Tom Lane wrote: > In general, I see no good reason for our regression tests to be > making > assumptions about exactly how ICU's root locale behaves, so I'd > suggest > just lobotomizing this test case so it doesn't depend on upper/lower > sort order. [ Looks lik

Re: pgsql: Add standard collation UNICODE

2023-03-13 Thread Tom Lane
Andrew Dunstan writes: > How would I discover that? Or if it's quicker I can give you access to > one or two machines which exhibit the issue. Looks like Peter already found the answer -- several of the unhappy animals have gone green since d72900bde. regards, tom lane

Re: pgsql: Add standard collation UNICODE

2023-03-13 Thread Andrew Dunstan
On 2023-03-12 Su 18:47, Thomas Munro wrote: On Mon, Mar 13, 2023 at 9:10 AM Tom Lane wrote: Andrew Dunstan writes: On 2023-03-11 Sa 15:47, Tom Lane wrote: In general, I see no good reason for our regression tests to be making assumptions about exactly how ICU's root locale behaves, so I'd s

Re: pgsql: Add standard collation UNICODE

2023-03-12 Thread Thomas Munro
On Mon, Mar 13, 2023 at 9:10 AM Tom Lane wrote: > Andrew Dunstan writes: > > On 2023-03-11 Sa 15:47, Tom Lane wrote: > >> In general, I see no good reason for our regression tests to be making > >> assumptions about exactly how ICU's root locale behaves, so I'd suggest > >> just lobotomizing this

Re: pgsql: Add standard collation UNICODE

2023-03-12 Thread Tom Lane
Andrew Dunstan writes: > On 2023-03-11 Sa 15:47, Tom Lane wrote: >> In general, I see no good reason for our regression tests to be making >> assumptions about exactly how ICU's root locale behaves, so I'd suggest >> just lobotomizing this test case so it doesn't depend on upper/lower >> sort orde

Re: pgsql: Add standard collation UNICODE

2023-03-12 Thread Andrew Dunstan
On 2023-03-11 Sa 15:47, Tom Lane wrote: Jeff Davis writes: On Sat, 2023-03-11 at 08:31 -0500, Andrew Dunstan wrote: It's fairly old: $ rpm -q -a | grep icu  libicu-50.2-4.0.amzn1.x86_64  libicu-devel-50.2-4.0.amzn1.x86_64 FWIW I tried ICU 50.2 (built from sources) and the root locale still

Re: pgsql: Add standard collation UNICODE

2023-03-12 Thread Andrew Dunstan
On 2023-03-11 Sa 17:05, Andres Freund wrote: Hi, On 2023-03-11 10:20:33 -0800, Jeff Davis wrote: On Sat, 2023-03-11 at 08:31 -0500, Andrew Dunstan wrote: It's fairly old: $ rpm -q -a | grep icu  libicu-50.2-4.0.amzn1.x86_64  libicu-devel-50.2-4.0.amzn1.x86_64 FWIW I tried ICU 50.2 (built

Re: pgsql: Add standard collation UNICODE

2023-03-11 Thread Andrew Dunstan
> On Mar 11, 2023, at 5:05 PM, Andres Freund wrote: > > Hi, > >> On 2023-03-11 10:20:33 -0800, Jeff Davis wrote: >> On Sat, 2023-03-11 at 08:31 -0500, Andrew Dunstan wrote: >>> It's fairly old: >>> >>> $ rpm -q -a | grep icu >>> libicu-50.2-4.0.amzn1.x86_64 >>> libicu-devel-50.2-4.0

Re: pgsql: Add standard collation UNICODE

2023-03-11 Thread Andres Freund
Hi, On 2023-03-11 10:20:33 -0800, Jeff Davis wrote: > On Sat, 2023-03-11 at 08:31 -0500, Andrew Dunstan wrote: > > > > > It's fairly old: > > > > $ rpm -q -a | grep icu > >  libicu-50.2-4.0.amzn1.x86_64 > >  libicu-devel-50.2-4.0.amzn1.x86_64 > > FWIW I tried ICU 50.2 (built from sources) and t

Re: pgsql: Add standard collation UNICODE

2023-03-11 Thread Tom Lane
Jeff Davis writes: > On Sat, 2023-03-11 at 08:31 -0500, Andrew Dunstan wrote: >> It's fairly old: >> $ rpm -q -a | grep icu >>  libicu-50.2-4.0.amzn1.x86_64 >>  libicu-devel-50.2-4.0.amzn1.x86_64 > FWIW I tried ICU 50.2 (built from sources) and the root locale still > sorts lowercase first. snap

Re: pgsql: Add standard collation UNICODE

2023-03-11 Thread Jeff Davis
On Sat, 2023-03-11 at 08:31 -0500, Andrew Dunstan wrote: > > > It's fairly old: > > $ rpm -q -a | grep icu >  libicu-50.2-4.0.amzn1.x86_64 >  libicu-devel-50.2-4.0.amzn1.x86_64 FWIW I tried ICU 50.2 (built from sources) and the root locale still sorts lowercase first. Regards, Jeff Davi

Re: pgsql: Add standard collation UNICODE

2023-03-11 Thread Andrew Dunstan
On 2023-03-10 Fr 14:44, Jeff Davis wrote: On Fri, 2023-03-10 at 12:42 +, Peter Eisentraut wrote: Add standard collation UNICODE https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=prion&dt=2023-03-10%2018%3A58%3A04 Looks like there's still a failure, even after subsequent fix 3e623ebc

Re: pgsql: Add standard collation UNICODE

2023-03-10 Thread Jeff Davis
On Fri, 2023-03-10 at 11:52 -0800, Jonathan S. Katz wrote: > > The capitals should be first. That is not true in a lot of natural language locales, whether libc or ICU. The following return true for me (collencoding UTF-8): select 'abc' collate "en_US" < 'ABC' collate "en_US"; select 'abc' c

Re: pgsql: Add standard collation UNICODE

2023-03-10 Thread Jonathan S. Katz
> On Mar 10, 2023, at 11:44 AM, Jeff Davis wrote: > > On Fri, 2023-03-10 at 12:42 +, Peter Eisentraut wrote: >>> Add standard collation UNICODE > > https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=prion&dt=2023-03-10%2018%3A58%3A04 > > Looks like there's still a failure, even afte

Re: pgsql: Add standard collation UNICODE

2023-03-10 Thread Jeff Davis
On Fri, 2023-03-10 at 12:42 +, Peter Eisentraut wrote: > > Add standard collation UNICODE https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=prion&dt=2023-03-10%2018%3A58%3A04 Looks like there's still a failure, even after subsequent fix 3e623ebc7a. I'm wondering how that diff happens, b

pgsql: Add standard collation UNICODE

2023-03-10 Thread Peter Eisentraut
Add standard collation UNICODE This adds a new predefined collation named UNICODE, which sorts by the default Unicode collation algorithm specifications, per SQL standard. This only works if ICU support is built. Reviewed-by: Jeff Davis Discussion: https://www.postgresql.org/message-id/flat/12