Re: pgsql: Add support for basic NUMA awareness

2025-04-16 Thread Jacob Champion
On Wed, Apr 16, 2025 at 9:30 AM Daniel Gustafsson wrote: > It seems like this commit didn't run autoheader, which leaves a trivial diff > in > pg_config.h.in carried over for future callers. It doesn't change anuything > really as the HAVE_LIBNUMA macro isn't used, but for completeness sake we >

Re: pgsql: Add support for basic NUMA awareness

2025-04-16 Thread Daniel Gustafsson
> On 16 Apr 2025, at 20:15, Tomas Vondra wrote: > > On 4/16/25 18:34, Jacob Champion wrote: >> On Wed, Apr 16, 2025 at 9:30 AM Daniel Gustafsson wrote: >>> It seems like this commit didn't run autoheader, which leaves a trivial >>> diff in >>> pg_config.h.in carried over for future callers. It

Re: pgsql: Add support for basic NUMA awareness

2025-04-16 Thread Tomas Vondra
On 4/16/25 18:34, Jacob Champion wrote: > On Wed, Apr 16, 2025 at 9:30 AM Daniel Gustafsson wrote: >> It seems like this commit didn't run autoheader, which leaves a trivial diff >> in >> pg_config.h.in carried over for future callers. It doesn't change anuything >> really as the HAVE_LIBNUMA ma

Re: pgsql: Add support for basic NUMA awareness

2025-04-15 Thread Daniel Gustafsson
> On 7 Apr 2025, at 23:18, Tomas Vondra wrote: > > Add support for basic NUMA awareness It seems like this commit didn't run autoheader, which leaves a trivial diff in pg_config.h.in carried over for future callers. It doesn't change anuything really as the HAVE_LIBNUMA macro isn't used, but fo

Re: pgsql: Add support for basic NUMA awareness

2025-04-10 Thread Andres Freund
Hi, Walther, adding you because of the failure on buildfarm animal dogfish. The main issue is something unrelated to your animal (except it was the only one to catch it), but there's one oddity: On 2025-04-08 10:36:32 -0400, Tom Lane wrote: > Andres Freund writes: > > On April 8, 2025 10:05:48

Re: pgsql: Add support for basic NUMA awareness

2025-04-08 Thread Tom Lane
Andres Freund writes: > On April 8, 2025 10:05:48 AM EDT, Tom Lane wrote: >> I noticed this a little further up in dogfish's log: >> >> ninja: bad depfile: expected ':', saw 's' > I noticed that too - but it happened even before the hard failures. Will look > at it in a bit. After catching up

Re: pgsql: Add support for basic NUMA awareness

2025-04-08 Thread Wolfgang Walther
Andres Freund: But it'd be nice to add a note to the buildfarm animal indicating it's using samurai instead of ninja (setnotes.pl). Did that! Best, Wolfgang

Re: pgsql: Add support for basic NUMA awareness

2025-04-08 Thread Wolfgang Walther
Andres Freund: But I'm rather bewildered - I can't actually build with the professed version of ninja, it errors out: ninja-1.9.0 src/bin/psql/sql_help.c ninja: error: build.ninja:8462: multiple outputs aren't (yet?) supported by depslog; bring this up on the mailing list if it affects you So

Re: pgsql: Add support for basic NUMA awareness

2025-04-08 Thread Andres Freund
Hi, On 2025-04-08 17:17:21 +0200, Wolfgang Walther wrote: > Andres Freund: > > But I'm rather bewildered - I can't actually build with the professed > > version > > of ninja, it errors out: > > > > ninja-1.9.0 src/bin/psql/sql_help.c > > ninja: error: build.ninja:8462: multiple outputs aren't (y

Re: pgsql: Add support for basic NUMA awareness

2025-04-08 Thread Andres Freund
Hi, On April 8, 2025 10:05:48 AM EDT, Tom Lane wrote: >Daniel Gustafsson writes: >>> On 7 Apr 2025, at 23:18, Tomas Vondra wrote: >>> Add support for basic NUMA awareness > >> dogfish is a little bit upset it seems. > >Hm, but why isn't anything else? I assume it's a question of degree of para

Re: pgsql: Add support for basic NUMA awareness

2025-04-08 Thread Tom Lane
Daniel Gustafsson writes: >> On 7 Apr 2025, at 23:18, Tomas Vondra wrote: >> Add support for basic NUMA awareness > dogfish is a little bit upset it seems. Hm, but why isn't anything else? I noticed this a little further up in dogfish's log: ninja: bad depfile: expected ':', saw 's' I wonder

Re: pgsql: Add support for basic NUMA awareness

2025-04-08 Thread Daniel Gustafsson
> On 7 Apr 2025, at 23:18, Tomas Vondra wrote: > > Add support for basic NUMA awareness dogfish is a little bit upset it seems. ninja: job failed: ccache gcc -Isrc/port/libpgport.a.p -Isrc/include -I../pgsql/src/include -fdiagnostics-color=always -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -O2

pgsql: Add support for basic NUMA awareness

2025-04-07 Thread Tomas Vondra
Add support for basic NUMA awareness Add basic NUMA awareness routines, using a minimal src/port/pg_numa.c portability wrapper and an optional build dependency, enabled by --with-libnuma configure option. For now this is Linux-only, other platforms may be supported later. A built-in SQL function