Re: pgsql: Add support for multivariate MCV lists

2019-04-02 Thread Tomas Vondra
On Fri, Mar 29, 2019 at 08:25:10PM +0100, Tomas Vondra wrote: On Fri, Mar 29, 2019 at 12:06:26PM -0700, Peter Geoghegan wrote: On Fri, Mar 29, 2019 at 11:20 AM Tomas Vondra wrote: I've pushed a fix for this. The short version is that the serialized representation was not respecting memory alig

Re: pgsql: Add support for multivariate MCV lists

2019-03-29 Thread Tomas Vondra
On Fri, Mar 29, 2019 at 12:06:26PM -0700, Peter Geoghegan wrote: On Fri, Mar 29, 2019 at 11:20 AM Tomas Vondra wrote: I've pushed a fix for this. The short version is that the serialized representation was not respecting memory alignment requirements, which was causing issues in machines sensit

Re: pgsql: Add support for multivariate MCV lists

2019-03-29 Thread Peter Geoghegan
On Fri, Mar 29, 2019 at 11:20 AM Tomas Vondra wrote: > I've pushed a fix for this. The short version is that the serialized > representation was not respecting memory alignment requirements, which was > causing issues in machines sensitive to this (ia64, sparc, hppa). It's a > blind attempt, as I

Re: pgsql: Add support for multivariate MCV lists

2019-03-29 Thread Tomas Vondra
On Thu, Mar 28, 2019 at 08:37:11PM +0100, Tomas Vondra wrote: On Thu, Mar 28, 2019 at 07:33:36PM +0100, Tomas Vondra wrote: On Thu, Mar 28, 2019 at 11:29:12AM -0700, Peter Geoghegan wrote: On Wed, Mar 27, 2019 at 6:27 PM Tomas Vondra wrote: It's a bit too late for pushing emergency fixes over

Re: pgsql: Add support for multivariate MCV lists

2019-03-28 Thread Tomas Vondra
On Thu, Mar 28, 2019 at 07:33:36PM +0100, Tomas Vondra wrote: On Thu, Mar 28, 2019 at 11:29:12AM -0700, Peter Geoghegan wrote: On Wed, Mar 27, 2019 at 6:27 PM Tomas Vondra wrote: It's a bit too late for pushing emergency fixes over here, so I'll do more testing tomorrow and then push. The bu

Re: pgsql: Add support for multivariate MCV lists

2019-03-28 Thread Tomas Vondra
On Thu, Mar 28, 2019 at 11:29:12AM -0700, Peter Geoghegan wrote: On Wed, Mar 27, 2019 at 6:27 PM Tomas Vondra wrote: It's a bit too late for pushing emergency fixes over here, so I'll do more testing tomorrow and then push. The buildfarm is still almost all-red now. Can you estimate how long

Re: pgsql: Add support for multivariate MCV lists

2019-03-28 Thread Peter Geoghegan
On Wed, Mar 27, 2019 at 6:27 PM Tomas Vondra wrote: > It's a bit too late for pushing emergency fixes over here, so I'll do > more testing tomorrow and then push. The buildfarm is still almost all-red now. Can you estimate how long it will take to push a fix? -- Peter Geoghegan

Re: pgsql: Add support for multivariate MCV lists

2019-03-28 Thread Tomas Vondra
On Wed, Mar 27, 2019 at 08:15:35PM -0700, Andres Freund wrote: Hi, On 2019-03-27 21:13:46 +0100, Tomas Vondra wrote: On Wed, Mar 27, 2019 at 12:32:34PM -0700, Peter Geoghegan wrote: > On Wed, Mar 27, 2019 at 12:04 PM Andres Freund wrote: > > Congrats, this was long in the making! > > +1 > Tha

Re: pgsql: Add support for multivariate MCV lists

2019-03-27 Thread Andres Freund
Hi, On 2019-03-27 21:13:46 +0100, Tomas Vondra wrote: > On Wed, Mar 27, 2019 at 12:32:34PM -0700, Peter Geoghegan wrote: > > On Wed, Mar 27, 2019 at 12:04 PM Andres Freund wrote: > > > Congrats, this was long in the making! > > > > +1 > > > > Thanks! I guess it's a Gordie Howe of our patches.

Re: pgsql: Add support for multivariate MCV lists

2019-03-27 Thread David Fetter
On Wed, Mar 27, 2019 at 07:02:01PM +, Tomas Vondra wrote: > Add support for multivariate MCV lists Kudos! Best, David. -- David Fetter http://fetter.org/ Phone: +1 415 235 3778 Remember to vote! Consider donating to Postgres: http://www.postgresql.org/about/donate

Re: pgsql: Add support for multivariate MCV lists

2019-03-27 Thread Tomas Vondra
On Wed, Mar 27, 2019 at 09:33:53PM +0100, Tomas Vondra wrote: On Wed, Mar 27, 2019 at 09:13:46PM +0100, Tomas Vondra wrote: On Wed, Mar 27, 2019 at 12:32:34PM -0700, Peter Geoghegan wrote: On Wed, Mar 27, 2019 at 12:04 PM Andres Freund wrote: Congrats, this was long in the making! +1 Tha

Re: pgsql: Add support for multivariate MCV lists

2019-03-27 Thread Tomas Vondra
On Wed, Mar 27, 2019 at 09:13:46PM +0100, Tomas Vondra wrote: On Wed, Mar 27, 2019 at 12:32:34PM -0700, Peter Geoghegan wrote: On Wed, Mar 27, 2019 at 12:04 PM Andres Freund wrote: Congrats, this was long in the making! +1 Thanks! I guess it's a Gordie Howe of our patches. Buildfarm mem

Re: pgsql: Add support for multivariate MCV lists

2019-03-27 Thread Tomas Vondra
On Wed, Mar 27, 2019 at 12:32:34PM -0700, Peter Geoghegan wrote: On Wed, Mar 27, 2019 at 12:04 PM Andres Freund wrote: Congrats, this was long in the making! +1 Thanks! I guess it's a Gordie Howe of our patches. Buildfarm member aye-aye has a problem with this patch, though: https://bui

Re: pgsql: Add support for multivariate MCV lists

2019-03-27 Thread Peter Geoghegan
On Wed, Mar 27, 2019 at 12:04 PM Andres Freund wrote: > Congrats, this was long in the making! +1 Buildfarm member aye-aye has a problem with this patch, though: https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=aye-aye&dt=2019-03-27%2019%3A07%3A53 -- Peter Geoghegan

Re: pgsql: Add support for multivariate MCV lists

2019-03-27 Thread Andres Freund
On 2019-03-27 19:02:01 +, Tomas Vondra wrote: > Add support for multivariate MCV lists > > Introduce a third extended statistic type, supported by the CREATE > STATISTICS command - MCV lists, a generalization of the statistic > already built and used for individual columns. > > Compared to th

pgsql: Add support for multivariate MCV lists

2019-03-27 Thread Tomas Vondra
Add support for multivariate MCV lists Introduce a third extended statistic type, supported by the CREATE STATISTICS command - MCV lists, a generalization of the statistic already built and used for individual columns. Compared to the already supported types (n-distinct coefficients and functiona