On Mon, Mar 21, 2022 at 6:38 AM Magnus Hagander wrote:
> This one has a tiny copy/paste error where the idenfiication comment
> for basebackup_target.c claims it's basebackup_gzip.c. I've pushed a
> fix.
Thanks. If that's the extent of the problems we're doing well!
--
Robert Haas
EDB: http://w
On Tue, Mar 15, 2022 at 7:33 PM Robert Haas wrote:
>
> Allow extensions to add new backup targets.
>
> Commit 3500ccc39b0dadd1068a03938e4b8ff562587ccc allowed for base backup
> targets, meaning that we could do something with the backup other than
> send it to the client, but all of those targets
On Wed, Mar 16, 2022 at 09:52:41AM -0400, Robert Haas wrote:
> It sucks that I keep missing this point.
So do I. No worries. Thanks for fixing it!
--
Michael
signature.asc
Description: PGP signature
On Wed, Mar 16, 2022 at 09:52:41AM -0400, Robert Haas wrote:
> On Wed, Mar 16, 2022 at 5:36 AM Michael Paquier wrote:
> > I have noticed that this commit produces a warning when building with
> > MSVC, as of the end of BaseBackupGetTargetHandle() when the target
> > cannot be found. I guess that
On Wed, Mar 16, 2022 at 5:36 AM Michael Paquier wrote:
> I have noticed that this commit produces a warning when building with
> MSVC, as of the end of BaseBackupGetTargetHandle() when the target
> cannot be found. I guess that you'd better add a fake return NULL to
> keep such compilers quiet ab
Hi Robert,
On Tue, Mar 15, 2022 at 05:33:12PM +, Robert Haas wrote:
> Allow extensions to add new backup targets.
>
> Commit 3500ccc39b0dadd1068a03938e4b8ff562587ccc allowed for base backup
> targets, meaning that we could do something with the backup other than
> send it to the client, but a
Allow extensions to add new backup targets.
Commit 3500ccc39b0dadd1068a03938e4b8ff562587ccc allowed for base backup
targets, meaning that we could do something with the backup other than
send it to the client, but all of those targets had to be baked in to
the core code. This commit makes it possi
