Re: pgsql: Allow some recovery parameters to be changed with reload

2019-02-11 Thread Michael Paquier
On Sat, Feb 09, 2019 at 01:35:52PM -0500, Stephen Frost wrote: > While I agree that we don't really have a formal policy, there are > certainly some who do (or, at least did) seem to care quite a bit about > this and that's why I've been using '--ignore-date' for quite some time > in my workflow: >

Re: pgsql: Allow some recovery parameters to be changed with reload

2019-02-09 Thread Stephen Frost
Greetings, * Tom Lane (t...@sss.pgh.pa.us) wrote: > Alvaro Herrera writes: > > On 2019-Feb-08, Michael Paquier wrote: > >> The timestamp of this commit is a bit messed up: > >> commit: 13b89f96d07ad3da67b57f66c134c3609bd3e98f > >> author: Peter Eisentraut > >> date: Mon, 4 Feb 2019 09:28:17 +010

Re: pgsql: Allow some recovery parameters to be changed with reload

2019-02-08 Thread Tom Lane
Alvaro Herrera writes: > On 2019-Feb-08, Michael Paquier wrote: >> The timestamp of this commit is a bit messed up: >> commit: 13b89f96d07ad3da67b57f66c134c3609bd3e98f >> author: Peter Eisentraut >> date: Mon, 4 Feb 2019 09:28:17 +0100 >> committer: Peter Eisentraut >> date: Thu, 7 Feb 2019 08:3

Re: pgsql: Allow some recovery parameters to be changed with reload

2019-02-08 Thread Peter Eisentraut
On 08/02/2019 08:45, Michael Paquier wrote: > The timestamp of this commit is a bit messed up: Where you say "a bit messed up" one might also say "accurately reflecting history". :) -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Tra

Re: pgsql: Allow some recovery parameters to be changed with reload

2019-02-08 Thread Alvaro Herrera
On 2019-Feb-08, Michael Paquier wrote: > The timestamp of this commit is a bit messed up: > commit: 13b89f96d07ad3da67b57f66c134c3609bd3e98f > author: Peter Eisentraut > date: Mon, 4 Feb 2019 09:28:17 +0100 > committer: Peter Eisentraut > date: Thu, 7 Feb 2019 08:34:48 +0100 > > Perhaps you ove

Re: pgsql: Allow some recovery parameters to be changed with reload

2019-02-07 Thread Michael Paquier
On Thu, Feb 07, 2019 at 07:52:13AM +, Peter Eisentraut wrote: > Allow some recovery parameters to be changed with reload > > Change > > archive_cleanup_command > promote_trigger_file > recovery_end_command > recovery_min_apply_delay > > from PGC_POSTMASTER to PGC_SIGHUP. This did not requir

pgsql: Allow some recovery parameters to be changed with reload

2019-02-06 Thread Peter Eisentraut
Allow some recovery parameters to be changed with reload Change archive_cleanup_command promote_trigger_file recovery_end_command recovery_min_apply_delay from PGC_POSTMASTER to PGC_SIGHUP. This did not require any further changes. Reviewed-by: Michael Paquier Discussion: https://www.postgre