Re: pgsql: Build all Flex files standalone

2022-09-05 Thread John Naylor
I see why I couldn't reproduce: I neglected to add jsonpath_gram.h to the backend's maintainer-clean so it failed to be deleted. Working on the fix now. -- John Naylor EDB: http://www.enterprisedb.com

Re: pgsql: Build all Flex files standalone

2022-09-05 Thread John Naylor
On Tue, Sep 6, 2022 at 11:49 AM Tom Lane wrote: > > crake is still unhappy: > > Sep 06 00:09:55 In file included from /tmp/headerscheck.AwLxya/test.c:2: > Sep 06 00:09:55 > /home/andrew/bf/root/HEAD/pgsql.build/../pgsql/src/backend/utils/adt/jsonpath_internal.h:26:10: > fatal error: jsonpath_gra

Re: pgsql: Build all Flex files standalone

2022-09-05 Thread Tom Lane
John Naylor writes: > On Tue, Sep 6, 2022 at 10:54 AM Andres Freund wrote: >> Presumably it only happens if you previously triggered the parsers to be >> generated. > If you attempt to run the check before building, the first thing you get is > fatal error: utils/errcodes.h: No such file or dir

Re: pgsql: Build all Flex files standalone

2022-09-05 Thread John Naylor
On Tue, Sep 6, 2022 at 10:54 AM Andres Freund wrote: > >I just tried a vpath build and the failing check doesn't reproduce for > >me there. Any ideas? > > Presumably it only happens if you previously triggered the parsers to be > generated. If you attempt to run the check before building, the fi

Re: pgsql: Build all Flex files standalone

2022-09-05 Thread Andres Freund
Hi, On September 5, 2022 8:33:37 PM PDT, John Naylor wrote: >On Sun, Sep 4, 2022 at 8:34 PM Andrew Dunstan wrote: >> >> >> On 2022-09-04 Su 02:19, John Naylor wrote: >> > Crake fails with >> > >> > headerscheck: >> > Sep 04 01:56:01 In file included from /tmp/headerscheck.UNgmKy/test.c:2: >>

Re: pgsql: Build all Flex files standalone

2022-09-05 Thread John Naylor
On Sun, Sep 4, 2022 at 8:34 PM Andrew Dunstan wrote: > > > On 2022-09-04 Su 02:19, John Naylor wrote: > > Crake fails with > > > > headerscheck: > > Sep 04 01:56:01 In file included from /tmp/headerscheck.UNgmKy/test.c:2: > > Sep 04 01:56:01 > > /home/andrew/bf/root/HEAD/pgsql.build/../pgsql/src/b

Re: pgsql: Build all Flex files standalone

2022-09-04 Thread John Naylor
On Sun, Sep 4, 2022 at 8:34 PM Andrew Dunstan wrote: > Probably happens because crake does vpath builds. I think you're going > to have to set up EXTRAINCLUDES for it - see near the bottom of the > headerscheck script. Possibly something like > > > src/backend/utils/adt/*) > > EXTRAINCLUDE

Re: pgsql: Build all Flex files standalone

2022-09-04 Thread Andres Freund
Hi, On 2022-09-04 13:19:56 +0700, John Naylor wrote: > Crake fails with > > headerscheck: > Sep 04 01:56:01 In file included from /tmp/headerscheck.UNgmKy/test.c:2: > Sep 04 01:56:01 > /home/andrew/bf/root/HEAD/pgsql.build/../pgsql/src/backend/utils/adt/jsonpath_internal.h:26:10: > fatal error: j

Re: pgsql: Build all Flex files standalone

2022-09-04 Thread Andres Freund
Hi, On 2022-09-04 18:04:13 +0700, John Naylor wrote: > On Sun, Sep 4, 2022 at 4:36 PM John Naylor > wrote: > > > > For this, Mkvcbuild.pm specifies specparse.c explicitly, so maybe > > something like the following is needed: > > > > --- a/src/tools/msvc/Mkvcbuild.pm > > +++ b/src/tools/msvc/Mkvc

Re: pgsql: Build all Flex files standalone

2022-09-04 Thread Andrew Dunstan
On 2022-09-04 Su 02:19, John Naylor wrote: > Crake fails with > > headerscheck: > Sep 04 01:56:01 In file included from /tmp/headerscheck.UNgmKy/test.c:2: > Sep 04 01:56:01 > /home/andrew/bf/root/HEAD/pgsql.build/../pgsql/src/backend/utils/adt/jsonpath_internal.h:26:10: > fatal error: jsonpath_gr

Re: pgsql: Build all Flex files standalone

2022-09-04 Thread John Naylor
On Sun, Sep 4, 2022 at 4:36 PM John Naylor wrote: > > For this, Mkvcbuild.pm specifies specparse.c explicitly, so maybe > something like the following is needed: > > --- a/src/tools/msvc/Mkvcbuild.pm > +++ b/src/tools/msvc/Mkvcbuild.pm > @@ -362,6 +362,7 @@ sub mkvcbuild > $isolation_teste

Re: pgsql: Build all Flex files standalone

2022-09-04 Thread John Naylor
The second failure is on drongo (MSVC): "c:\\prog\\bf\\root\\HEAD\\pgsql.build\\pgsql.sln" (default target) (1) -> "c:\\prog\\bf\\root\\HEAD\\pgsql.build\\isolationtester.vcxproj" (default target) (13) -> (Link target) -> specparse.obj : error LNK2019: unresolved external symbol spec_yylex refer

Re: pgsql: Build all Flex files standalone

2022-09-03 Thread John Naylor
Crake fails with headerscheck: Sep 04 01:56:01 In file included from /tmp/headerscheck.UNgmKy/test.c:2: Sep 04 01:56:01 /home/andrew/bf/root/HEAD/pgsql.build/../pgsql/src/backend/utils/adt/jsonpath_internal.h:26:10: fatal error: jsonpath_gram.h: No such file or directory Sep 04 01:56:0126 | #i

pgsql: Build all Flex files standalone

2022-09-03 Thread John Naylor
Build all Flex files standalone The proposed Meson build system will need a way to ignore certain generated files in order to coexist with the autoconf build system, and C files generated by Flex which are #include'd into .y files make this more difficult. In similar vein to 72b1e3a21, arrange for