Re: pgsql: Check for STATUS_DELETE_PENDING on Windows.

Andrew Dunstan writes: > Done See > > crake will now run this as part of its normal runs on HEAD. Great, thanks! regards, tom lane

Re: pgsql: Check for STATUS_DELETE_PENDING on Windows.

On 1/11/22 16:54, Tom Lane wrote: > Andrew Dunstan writes: >> On 1/11/22 16:22, Thomas Munro wrote: >>> Those scripts aren't really on my radar... would it be a good idea to >>> run them as steps in the CompilerWarnings CI task? >> Or in a buildfarm module (c.f. the perl checks) > +1 for one or

Re: pgsql: Check for STATUS_DELETE_PENDING on Windows.

Andrew Dunstan writes: > On 1/11/22 16:22, Thomas Munro wrote: >> Those scripts aren't really on my radar... would it be a good idea to >> run them as steps in the CompilerWarnings CI task? > Or in a buildfarm module (c.f. the perl checks) +1 for one or the other, because we break that regularly

Re: pgsql: Check for STATUS_DELETE_PENDING on Windows.

On 1/11/22 16:22, Thomas Munro wrote: > 2. headerscheck and cpluspluscheck don't like it, at least >> not on non-Windows: >> >> $ src/tools/pginclude/headerscheck >> In file included from /tmp/headerscheck.WKh8cz/test.c:2: >> ./src/include/port/win32ntdll.h:20:10: fatal error: ntstatus.h: No such

Re: pgsql: Check for STATUS_DELETE_PENDING on Windows.

On Wed, Jan 12, 2022 at 8:36 AM Tom Lane wrote: > 1. It lacks the usual anti-multiple-inclusion guard, i.e. > #ifndef WIN32NTDLL_H > or the like. Was there a specific reason to omit that? Oops. Fixed. > 2. headerscheck and cpluspluscheck don't like it, at least > not on non-Windows: >

Re: pgsql: Check for STATUS_DELETE_PENDING on Windows.

Thomas Munro writes: > Check for STATUS_DELETE_PENDING on Windows. The src/include/port/win32ntdll.h file added by this commit has a couple of deficiencies: 1. It lacks the usual anti-multiple-inclusion guard, i.e. #ifndef WIN32NTDLL_H or the like. Was there a specific reason to omit th

pgsql: Check for STATUS_DELETE_PENDING on Windows.

Check for STATUS_DELETE_PENDING on Windows. 1. Update our open() wrapper to check for NT's STATUS_DELETE_PENDING and translate it to Unix-like errors. This is done with RtlGetLastNtStatus(), which is dynamically loaded from ntdll. A new file win32ntdll.c centralizes lookup of NT functions, in c