Re: pgsql: Disk-based Hash Aggregation.

2020-03-23 Thread Tom Lane
Jeff Davis writes: > On Mon, 2020-03-23 at 02:05 -0400, Tom Lane wrote: >> If there's no way to test the feature in some significantly-cheaper >> way, >> perhaps we should move this test out to a separate script that's not >> run >> by default. > I'll rework the tests. I wanted to be a bit more a

Re: pgsql: Disk-based Hash Aggregation.

2020-03-23 Thread Jeff Davis
On Mon, 2020-03-23 at 02:05 -0400, Tom Lane wrote: > If there's no way to test the feature in some significantly-cheaper > way, > perhaps we should move this test out to a separate script that's not > run > by default. I'll rework the tests. I wanted to be a bit more aggressive about testing right

Re: pgsql: Disk-based Hash Aggregation.

2020-03-22 Thread Tom Lane
Jeff Davis writes: > Disk-based Hash Aggregation. I noticed that the regression tests seemed suddenly slower than they have been. A bit of poking around reveals that this patch made groupingsets.sql take approximately 8X longer than it used to, and more than twice as long as any other core regre

pgsql: Disk-based Hash Aggregation.

2020-03-18 Thread Jeff Davis
Disk-based Hash Aggregation. While performing hash aggregation, track memory usage when adding new groups to a hash table. If the memory usage exceeds work_mem, enter "spill mode". In spill mode, new groups are not created in the hash table(s), but existing groups continue to be advanced if input