Re: pgsql: Fix arrays comparison in CompareOpclassOptions()

2024-11-11 Thread Alexander Korotkov
On Tue, Nov 12, 2024 at 3:10 AM Tom Lane wrote: > Alexander Korotkov writes: > > On Tue, Nov 12, 2024 at 2:09 AM Tom Lane wrote: > >> Umm ... you do realize we're still in release freeze? > > > Oh, I specially visited the wiki page, but misread the sentence on > > when the release freeze stops.

Re: pgsql: Fix arrays comparison in CompareOpclassOptions()

2024-11-11 Thread Tom Lane
Alexander Korotkov writes: > On Tue, Nov 12, 2024 at 2:09 AM Tom Lane wrote: >> Umm ... you do realize we're still in release freeze? > Oh, I specially visited the wiki page, but misread the sentence on > when the release freeze stops. Obviously yes, tags aren't pushed, > that are just stamps.

Re: pgsql: Fix arrays comparison in CompareOpclassOptions()

2024-11-11 Thread Alexander Korotkov
On Tue, Nov 12, 2024 at 2:09 AM Tom Lane wrote: > Alexander Korotkov writes: > > Fix arrays comparison in CompareOpclassOptions() > > Umm ... you do realize we're still in release freeze? > > https://wiki.postgresql.org/wiki/Committing_checklist#Release_freezes > > Hopefully it will not make a di

Re: pgsql: Fix arrays comparison in CompareOpclassOptions()

2024-11-11 Thread Tom Lane
Alexander Korotkov writes: > Fix arrays comparison in CompareOpclassOptions() Umm ... you do realize we're still in release freeze? https://wiki.postgresql.org/wiki/Committing_checklist#Release_freezes Hopefully it will not make a difference, but this really should have waited another day.

pgsql: Fix arrays comparison in CompareOpclassOptions()

2024-11-11 Thread Alexander Korotkov
Fix arrays comparison in CompareOpclassOptions() The current code calls array_eq() and does not provide FmgrInfo. This commit provides initialization of FmgrInfo and uses C collation as the safe option for text comparison because we don't know anything about the semantics of opclass options. Bac

pgsql: Fix arrays comparison in CompareOpclassOptions()

2024-11-11 Thread Alexander Korotkov
Fix arrays comparison in CompareOpclassOptions() The current code calls array_eq() and does not provide FmgrInfo. This commit provides initialization of FmgrInfo and uses C collation as the safe option for text comparison because we don't know anything about the semantics of opclass options. Bac

pgsql: Fix arrays comparison in CompareOpclassOptions()

2024-11-11 Thread Alexander Korotkov
Fix arrays comparison in CompareOpclassOptions() The current code calls array_eq() and does not provide FmgrInfo. This commit provides initialization of FmgrInfo and uses C collation as the safe option for text comparison because we don't know anything about the semantics of opclass options. Bac

pgsql: Fix arrays comparison in CompareOpclassOptions()

2024-11-11 Thread Alexander Korotkov
Fix arrays comparison in CompareOpclassOptions() The current code calls array_eq() and does not provide FmgrInfo. This commit provides initialization of FmgrInfo and uses C collation as the safe option for text comparison because we don't know anything about the semantics of opclass options. Bac

pgsql: Fix arrays comparison in CompareOpclassOptions()

2024-11-11 Thread Alexander Korotkov
Fix arrays comparison in CompareOpclassOptions() The current code calls array_eq() and does not provide FmgrInfo. This commit provides initialization of FmgrInfo and uses C collation as the safe option for text comparison because we don't know anything about the semantics of opclass options. Bac

pgsql: Fix arrays comparison in CompareOpclassOptions()

2024-11-11 Thread Alexander Korotkov
Fix arrays comparison in CompareOpclassOptions() The current code calls array_eq() and does not provide FmgrInfo. This commit provides initialization of FmgrInfo and uses C collation as the safe option for text comparison because we don't know anything about the semantics of opclass options. Bac