Re: pgsql: Fix assorted bugs in ecpg's macro mechanism.

2024-04-18 Thread Tom Lane
Andrew Dunstan writes: > On 2024-04-16 Tu 12:31, Tom Lane wrote: >> Fix assorted bugs in ecpg's macro mechanism. > Buildfarm animals running the old MSVC build system don't like this. Oh, duh, I'd already forgotten about that... > It looks to me like we'll need an adjustment in > src/tools/msv

Re: pgsql: Fix assorted bugs in ecpg's macro mechanism.

2024-04-18 Thread Andrew Dunstan
On 2024-04-16 Tu 12:31, Tom Lane wrote: Fix assorted bugs in ecpg's macro mechanism. Buildfarm animals running the old MSVC build system don't like this. It looks to me like we'll need an adjustment in src/tools/msvc/ecpg_regression.proj to replicate the special rules surrounding define.c

pgsql: Fix assorted bugs in ecpg's macro mechanism.

2024-04-16 Thread Tom Lane
Fix assorted bugs in ecpg's macro mechanism. The code associated with EXEC SQL DEFINE was unreadable and full of bugs, notably: * It'd attempt to free a non-malloced string if the ecpg program tries to redefine a macro that was defined on the command line. * Possible memory stomp if user writes

pgsql: Fix assorted bugs in ecpg's macro mechanism.

2024-04-16 Thread Tom Lane
Fix assorted bugs in ecpg's macro mechanism. The code associated with EXEC SQL DEFINE was unreadable and full of bugs, notably: * It'd attempt to free a non-malloced string if the ecpg program tries to redefine a macro that was defined on the command line. * Possible memory stomp if user writes

pgsql: Fix assorted bugs in ecpg's macro mechanism.

2024-04-16 Thread Tom Lane
Fix assorted bugs in ecpg's macro mechanism. The code associated with EXEC SQL DEFINE was unreadable and full of bugs, notably: * It'd attempt to free a non-malloced string if the ecpg program tries to redefine a macro that was defined on the command line. * Possible memory stomp if user writes

pgsql: Fix assorted bugs in ecpg's macro mechanism.

2024-04-16 Thread Tom Lane
Fix assorted bugs in ecpg's macro mechanism. The code associated with EXEC SQL DEFINE was unreadable and full of bugs, notably: * It'd attempt to free a non-malloced string if the ecpg program tries to redefine a macro that was defined on the command line. * Possible memory stomp if user writes

pgsql: Fix assorted bugs in ecpg's macro mechanism.

2024-04-16 Thread Tom Lane
Fix assorted bugs in ecpg's macro mechanism. The code associated with EXEC SQL DEFINE was unreadable and full of bugs, notably: * It'd attempt to free a non-malloced string if the ecpg program tries to redefine a macro that was defined on the command line. * Possible memory stomp if user writes

pgsql: Fix assorted bugs in ecpg's macro mechanism.

2024-04-16 Thread Tom Lane
Fix assorted bugs in ecpg's macro mechanism. The code associated with EXEC SQL DEFINE was unreadable and full of bugs, notably: * It'd attempt to free a non-malloced string if the ecpg program tries to redefine a macro that was defined on the command line. * Possible memory stomp if user writes