Re: pgsql: Fix error handling of vacuumdb and reindexdb when running out of

2019-08-26 Thread Michael Paquier
On Tue, Aug 27, 2019 at 09:18:27AM +0900, Michael Paquier wrote: > Thanks Andrew for looking at the patch. I have now committed it on > all the impacted branches, after running vcregress bincheck for all of > them with MSVC. bowerbird has turned back to green on 9.5 and 9.6 now, so it seems that

Re: pgsql: Fix error handling of vacuumdb and reindexdb when running out of

2019-08-26 Thread Michael Paquier
On Mon, Aug 26, 2019 at 11:36:50AM -0400, Andrew Dunstan wrote: > Looks OK. Thanks Andrew for looking at the patch. I have now committed it on all the impacted branches, after running vcregress bincheck for all of them with MSVC. -- Michael signature.asc Description: PGP signature

Re: pgsql: Fix error handling of vacuumdb and reindexdb when running out of

2019-08-26 Thread Andrew Dunstan
On 8/26/19 1:40 AM, Michael Paquier wrote: > On Mon, Aug 26, 2019 at 02:17:06AM +, Michael Paquier wrote: >> Fix error handling of vacuumdb and reindexdb when running out of fds >> >> When trying to use a high number of jobs, vacuumdb (and more recently >> reindexdb) has only checked for a ma

Re: pgsql: Fix error handling of vacuumdb and reindexdb when running out of

2019-08-25 Thread Michael Paquier
On Mon, Aug 26, 2019 at 02:17:06AM +, Michael Paquier wrote: > Fix error handling of vacuumdb and reindexdb when running out of fds > > When trying to use a high number of jobs, vacuumdb (and more recently > reindexdb) has only checked for a maximum number of jobs used, causing > confusing fai

pgsql: Fix error handling of vacuumdb and reindexdb when running out of

2019-08-25 Thread Michael Paquier
Fix error handling of vacuumdb and reindexdb when running out of fds When trying to use a high number of jobs, vacuumdb (and more recently reindexdb) has only checked for a maximum number of jobs used, causing confusing failures when running out of file descriptors when the jobs open connections t