pgsql: Fix outdated comment for IndexInfo

2025-07-01 Thread Peter Eisentraut
Fix outdated comment for IndexInfo Commit 78416235713 removed the ii_OpclassOptions field, but the comment was not updated. Author: Japin Li Reviewed-by: Richard Guo Discussion: https://www.postgresql.org/message-id/flat/ME0P300MB04453E6C7EA635F0ECF41BFCB6832%40ME0P300MB0445.AUSP300.PROD.OUTLO

pgsql: Fix outdated comment for IndexInfo

2025-07-01 Thread Peter Eisentraut
Fix outdated comment for IndexInfo Commit 78416235713 removed the ii_OpclassOptions field, but the comment was not updated. Author: Japin Li Reviewed-by: Richard Guo Discussion: https://www.postgresql.org/message-id/flat/ME0P300MB04453E6C7EA635F0ECF41BFCB6832%40ME0P300MB0445.AUSP300.PROD.OUTLO

pgsql: Fix outdated comment for IndexInfo

2025-07-01 Thread Peter Eisentraut
Fix outdated comment for IndexInfo Commit 78416235713 removed the ii_OpclassOptions field, but the comment was not updated. Author: Japin Li Reviewed-by: Richard Guo Discussion: https://www.postgresql.org/message-id/flat/ME0P300MB04453E6C7EA635F0ECF41BFCB6832%40ME0P300MB0445.AUSP300.PROD.OUTLO

pgsql: Fix outdated comment

2025-03-04 Thread Heikki Linnakangas
Fix outdated comment Commit bc971f4025 replaced the latch-setting mechanism that the comment talked about with a condition variable. And before that, commit 2258e76f90 moved the code so that the comment got detached from the loop that it talked about, so move the comment closer to the loop. Branc

pgsql: Fix outdated comment of scram_build_secret()

2024-12-09 Thread Michael Paquier
Fix outdated comment of scram_build_secret() This routine documented that "iterations" would use a default value if set to 0 by the caller. However, the iteration should always be set by the caller to a value strictly more than 0, as documented by an assertion. Oversight in b577743000cd, that ha

pgsql: Fix outdated comment of scram_build_secret()

2024-12-09 Thread Michael Paquier
Fix outdated comment of scram_build_secret() This routine documented that "iterations" would use a default value if set to 0 by the caller. However, the iteration should always be set by the caller to a value strictly more than 0, as documented by an assertion. Oversight in b577743000cd, that ha

pgsql: Fix outdated comment of scram_build_secret()

2024-12-09 Thread Michael Paquier
Fix outdated comment of scram_build_secret() This routine documented that "iterations" would use a default value if set to 0 by the caller. However, the iteration should always be set by the caller to a value strictly more than 0, as documented by an assertion. Oversight in b577743000cd, that ha

pgsql: Fix outdated comment; all running bgworkers are in BackendList

2024-08-01 Thread Heikki Linnakangas
Fix outdated comment; all running bgworkers are in BackendList Before commit 8a02b3d732, only bgworkers that connected to a database had an entry in the Backendlist. Commit 8a02b3d732 changed that, but forgot to update this comment. Discussion: https://www.postgresql.org/message-id/835232c0-a5f7

pgsql: Fix outdated comment in smgrtruncate()

2024-07-29 Thread Heikki Linnakangas
Fix outdated comment in smgrtruncate() Commit c5315f4f44 replaced smgr_fsm_nblocks and smgr_vm_nblocks with smgr_cached_nblocks, but forgot to update this comment. Author: Kirill Reshke Discussion: https://www.postgresql.org/message-id/caldssph9va6sdsvjrcmspeyramf%2brfisk7gqjo1dtrnd3vd...@mail.g

pgsql: Fix outdated comment after removal of direct SSL fallback

2024-07-08 Thread Heikki Linnakangas
Fix outdated comment after removal of direct SSL fallback The option to fall back from direct SSL to negotiated SSL or a plaintext connection was removed in commit fb5718f35f. Discussion: https://www.postgresql.org/message-id/c82ad227-e049-4e18-8898-475a748b5...@iki.fi Branch -- REL_17_STAB

pgsql: Fix outdated comment after removal of direct SSL fallback

2024-07-08 Thread Heikki Linnakangas
Fix outdated comment after removal of direct SSL fallback The option to fall back from direct SSL to negotiated SSL or a plaintext connection was removed in commit fb5718f35f. Discussion: https://www.postgresql.org/message-id/c82ad227-e049-4e18-8898-475a748b5...@iki.fi Branch -- master Det

pgsql: Fix outdated comment in ExecDelete

2022-11-17 Thread Alvaro Herrera
Fix outdated comment in ExecDelete This commend references a struct that disappeared before MERGE was merged ... and ExecDelete is not called by the committed MERGE anyway. Revert to the original wording. Backpatch to 15 Branch -- master Details --- https://git.postgresql.org/pg/commitd

pgsql: Fix outdated comment in ExecDelete

2022-11-17 Thread Alvaro Herrera
Fix outdated comment in ExecDelete This commend references a struct that disappeared before MERGE was merged ... and ExecDelete is not called by the committed MERGE anyway. Revert to the original wording. Backpatch to 15 Branch -- REL_15_STABLE Details --- https://git.postgresql.org/pg/

pgsql: Fix outdated comment in tuplesort.h

2022-11-01 Thread David Rowley
Fix outdated comment in tuplesort.h This was outdated by 77bae396d. Backpatch-through: 15, where 77bae396d was added Branch -- REL_15_STABLE Details --- https://git.postgresql.org/pg/commitdiff/23f44276123031d21cffeb699d9863149e1c734f Modified Files -- src/include/utils/tup

pgsql: Fix outdated comment in tuplesort.h

2022-11-01 Thread David Rowley
Fix outdated comment in tuplesort.h This was outdated by 77bae396d. Backpatch-through: 15, where 77bae396d was added Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/3712e0ed47d126e9aa656a34dd56d52770b672b7 Modified Files -- src/include/utils/tuplesort.

pgsql: Fix outdated comment that talked about seek position of WAL file

2021-06-16 Thread Heikki Linnakangas
Fix outdated comment that talked about seek position of WAL file. Since commit c24dcd0cfd, we have been using pg_pread() to read the WAL file, which doesn't change the seek position (unless we fall back to the implementation in src/port/pread.c). Update comment accordingly. Backpatch-through: 12,

pgsql: Fix outdated comment that talked about seek position of WAL file

2021-06-16 Thread Heikki Linnakangas
Fix outdated comment that talked about seek position of WAL file. Since commit c24dcd0cfd, we have been using pg_pread() to read the WAL file, which doesn't change the seek position (unless we fall back to the implementation in src/port/pread.c). Update comment accordingly. Backpatch-through: 12,

pgsql: Fix outdated comment that talked about seek position of WAL file

2021-06-16 Thread Heikki Linnakangas
Fix outdated comment that talked about seek position of WAL file. Since commit c24dcd0cfd, we have been using pg_pread() to read the WAL file, which doesn't change the seek position (unless we fall back to the implementation in src/port/pread.c). Update comment accordingly. Backpatch-through: 12,

pgsql: Fix outdated comment

2019-01-19 Thread Peter Eisentraut
Fix outdated comment The issue the comment is referring to was fixed by 08859bb5c2cebc132629ca838113d27bb31b990c. Branch -- REL_11_STABLE Details --- https://git.postgresql.org/pg/commitdiff/5279c8d097a1346e3dddbed7c0002c735aa23f73 Modified Files -- src/backend/executor/exec

pgsql: Fix outdated comment

2019-01-19 Thread Peter Eisentraut
Fix outdated comment The issue the comment is referring to was fixed by 08859bb5c2cebc132629ca838113d27bb31b990c. Branch -- REL_10_STABLE Details --- https://git.postgresql.org/pg/commitdiff/7cfd1dd031fe3baf6a500c98b62069ce317b664f Modified Files -- src/backend/executor/exec

pgsql: Fix outdated comment

2019-01-19 Thread Peter Eisentraut
Fix outdated comment The issue the comment is referring to was fixed by 08859bb5c2cebc132629ca838113d27bb31b990c. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/3bed67bed171701e86417ec5a201e2f2e82356fb Modified Files -- src/backend/executor/execReplica