Re: pgsql: Fix page modification outside of critical section in GIN

2020-02-10 Thread Tom Lane
Alexander Korotkov writes: > Sorry for delayed response. Yes, my fix for oversight contain > oversight itself. I confirm the fix you've committed is correct. > Thank you! Thanks for checking! regards, tom lane

Re: pgsql: Fix page modification outside of critical section in GIN

2020-02-10 Thread Alexander Korotkov
On Sun, Feb 9, 2020 at 8:05 PM Tom Lane wrote: > > I wrote: > > Alexander Korotkov writes: > >> Fix page modification outside of critical section in GIN > > > I happened to notice, while reviewing stuff for the release notes, > > that this patch does not do what the commit message says. The > >

Re: pgsql: Fix page modification outside of critical section in GIN

2020-02-09 Thread Tom Lane
I wrote: > Alexander Korotkov writes: >> Fix page modification outside of critical section in GIN > I happened to notice, while reviewing stuff for the release notes, > that this patch does not do what the commit message says. The > previous code modified the pd_prune_xid of the "dBuffer" page,

Re: pgsql: Fix page modification outside of critical section in GIN

2020-02-07 Thread Tom Lane
Alexander Korotkov writes: > Fix page modification outside of critical section in GIN > By oversight 52ac6cd2d0 makes ginDeletePage() sets pd_prune_xid of page to be > deleted before entering the critical section. It appears that only versions > 11 > and later were affected by this oversight. I

pgsql: Fix page modification outside of critical section in GIN

2019-11-19 Thread Alexander Korotkov
Fix page modification outside of critical section in GIN By oversight 52ac6cd2d0 makes ginDeletePage() sets pd_prune_xid of page to be deleted before entering the critical section. It appears that only versions 11 and later were affected by this oversight. Backpatch-through: 11 Branch -- ma

pgsql: Fix page modification outside of critical section in GIN

2019-11-19 Thread Alexander Korotkov
Fix page modification outside of critical section in GIN By oversight 52ac6cd2d0 makes ginDeletePage() sets pd_prune_xid of page to be deleted before entering the critical section. It appears that only versions 11 and later were affected by this oversight. Backpatch-through: 11 Branch -- RE

pgsql: Fix page modification outside of critical section in GIN

2019-11-19 Thread Alexander Korotkov
Fix page modification outside of critical section in GIN By oversight 52ac6cd2d0 makes ginDeletePage() sets pd_prune_xid of page to be deleted before entering the critical section. It appears that only versions 11 and later were affected by this oversight. Backpatch-through: 11 Branch -- RE