On 2022-09-13 Tu 05:25, John Naylor wrote:
> On Mon, Sep 12, 2022 at 4:54 PM Dagfinn Ilmari Mannsåker
> wrote:
>
>>> eval "\$hash_ref = $_"; ## no critic (ProhibitStringyEval)
>> I didn't see this until it got committed, since I'm not subscribed to
>> -committers, but I think it would be even b
On Mon, Sep 12, 2022 at 4:54 PM Dagfinn Ilmari Mannsåker
wrote:
> > eval "\$hash_ref = $_"; ## no critic (ProhibitStringyEval)
>
> I didn't see this until it got committed, since I'm not subscribed to
> -committers, but I think it would be even better to rely on the fact
> that eval returns the
Andrew Dunstan writes:
> On Fri, Sep 9, 2022 at 10:44 PM John Naylor
> wrote:
>
>> On Fri, Sep 9, 2022 at 3:32 AM Andrew Dunstan wrote:
>>
>> > A better way do do this IMNSHO is to put the eval in a block on its own
>> along with the no critic marker on its own line, like this:
>> >
>> > {
>> >
On Fri, Sep 9, 2022 at 10:44 PM John Naylor
wrote:
> On Fri, Sep 9, 2022 at 3:32 AM Andrew Dunstan wrote:
>
> > A better way do do this IMNSHO is to put the eval in a block on its own
> along with the no critic marker on its own line, like this:
> >
> > {
> >## no critic (ProhibitStringyEval
On Fri, Sep 9, 2022 at 3:32 AM Andrew Dunstan wrote:
> A better way do do this IMNSHO is to put the eval in a block on its own along
> with the no critic marker on its own line, like this:
>
> {
>## no critic (ProhibitStringyEval)
>eval ...
> }
>
> perlcritic respects block boundaries fo
On Thu, Sep 8, 2022 at 5:23 AM Alvaro Herrera
wrote:
> Fix perltidy breaking perlcritic
>
> perltidying a "##no critic" line moves the marker to where it becomes
> useless. Put the line back to how it was, and protect it from further
> malfeasance.
>
>
>
A better way do do this IMNSHO is to put
Fix perltidy breaking perlcritic
perltidying a "##no critic" line moves the marker to where it becomes
useless. Put the line back to how it was, and protect it from further
malfeasance.
Per buildfarm member crake.
Branch
--
master
Details
---
https://git.postgresql.org/pg/commitdiff/12
